RFC: Convert VCA to asynchronous implementations#3538
Draft
wmaroneAMD wants to merge 3 commits intoDMTF:mainfrom
Draft
RFC: Convert VCA to asynchronous implementations#3538wmaroneAMD wants to merge 3 commits intoDMTF:mainfrom
wmaroneAMD wants to merge 3 commits intoDMTF:mainfrom
Conversation
Signed-off-by: Manjeet Singh <itsmanjeet1998@gmail.com>
Following the patterns in GET CAPABILITIES and NEGOTIATE ALGORITHMS, this splits GET VERSION into a send and receive half, wrapped currently behind libspdm_try_get_version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts VCA try implementations into two separate functions handling command submission and response processing. These functions are hidden behind a shell try function and are not yet exported to be visible to the user.
This PR is not intended to merge, but to solicit comments and discuss the design pattern within.