Skip to content

Revert "Use ACE_ERROR"#2506

Merged
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-debugmacro
Feb 23, 2026
Merged

Revert "Use ACE_ERROR"#2506
jwillemsen merged 1 commit intoDOCGroup:masterfrom
jwillemsen:jwi-debugmacro

Conversation

@jwillemsen
Copy link
Member

@jwillemsen jwillemsen commented Feb 23, 2026

This reverts commit f28c00b.

Summary by CodeRabbit

  • Tests
    • Adjusted logging verbosity in compiler feature tests.

This reverts commit f28c00b.
@jwillemsen jwillemsen merged commit ffb39cd into DOCGroup:master Feb 23, 2026
33 checks passed
@jwillemsen jwillemsen deleted the jwi-debugmacro branch February 23, 2026 08:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9027d0c and 88610d1.

📒 Files selected for processing (1)
  • ACE/tests/Compiler_Features_43_Test.cpp

Walkthrough

A logging level change in a compiler features test file, where an error-level log statement in a catch block is demoted to debug level. No control flow or functional behavior is altered.

Changes

Cohort / File(s) Summary
Logging Level Adjustment
ACE/tests/Compiler_Features_43_Test.cpp
Changed ACE_ERROR to ACE_DEBUG in outer catch block exception handler, reducing log severity without altering exception handling logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A log line changed from red to grey,
No logic harmed along the way,
Debug instead of error's cry,
Quieter whispers—we pass by! ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant