Conversation
|
It is a bit weird to let |
eldering
left a comment
There was a problem hiding this comment.
I didn't fully review the parser, but in general looks ok. Maybe good to have some tests to see that it accepts and rejects a reasonable set of (in)valid regex strings.
|
Also added a bunch of tests now. IMO this is ready to be merged. |
|
I've pushed 2 commits on your branch. One with a testcase that breaks on your code, but worked before. I guess there's more incompatibility between regex implementations, also in specifying character classes. |
|
thx for the typo fixes :D
Yes, currently the mini spec I wrote intentionally excluded the special case of "if Do you think this is an important case that should be included? Personally I would say this is one of the cases where its good to be more restrictive... |
closes #32