Conversation
Adds DSN locations for JNSQ
DRVeyl
left a comment
DRVeyl
left a comment
There was a problem hiding this comment.
Looks pretty good! Could you make a couple changes?
| // author: Grimmas | ||
| // | ||
|
|
||
| @Kopernicus:FOR[JNSQ]:NEEDS[Kopernicus,JNSQ] |
There was a problem hiding this comment.
Please change to BEFORE[JNSQ] or AFTER[JNSQ].
Doing FOR[JNSQ] is a bad practice, since it will declare the JNSQ pass as existing! Thus making NEEDS[JNSQ] always true.
There was a problem hiding this comment.
Keeping in line with the other patch structures; RSS does this:
@Kopernicus:FOR[RealSolarSystem_Late]:NEEDS[Kopernicus,RealSolarSystem]
So might be best to use:
@Kopernicus:FOR[JNSQ_Late]:NEEDS[Kopernicus,JNSQ]
It should be fine to declare JNSQ_Late since... nothing should be looking for that. If we want to be overly careful, perhaps JNSQ_RealAntennas
| !City2[*TrackingStation],* {} | ||
| //!City2[GenericTrackingStation],* {} | ||
|
|
||
| City2 |
| City2 | ||
| { | ||
| name = GenericTrackingStation | ||
| objectName = Northern Dish | ||
| isKSC = False | ||
| commnetStation = True | ||
| snapToSurface = True | ||
| lat = 50 | ||
| lon = 20 | ||
| alt = 0 | ||
| snapHeightOffset = 0 | ||
| up = 0.0, 1.0, 0.0 | ||
| rotation = 0 | ||
| order = 100 | ||
| enabled = True | ||
| } | ||
|
|
||
| City2 | ||
| { | ||
| name = GenericTrackingStation | ||
| objectName = Southern Dish | ||
| isKSC = False | ||
| commnetStation = True | ||
| snapToSurface = True | ||
| lat = -65 | ||
| lon = 90 | ||
| alt = 5 | ||
| snapHeightOffset = 0 | ||
| up = 0.0, 1.0, 0.0 | ||
| rotation = 0 | ||
| order = 100 | ||
| enabled = True | ||
| } | ||
|
|
||
| @City2[*TrackingStation],* | ||
| { | ||
| commnetStation = True | ||
| snapToSurface = True | ||
| snapHeightOffset = 0 | ||
| up = 0.0, 1.0, 0.0 | ||
| rotation = 0 | ||
| order = 100 | ||
| } | ||
| @City2[*TrackingStation],* |
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
requested fixes
|
I've added the changes you requested. The indenting thing is weird. It looked fine in my editor and usually I don't have that issue. I tried with another editor, hopefully it is fixed now. BTW in the issues tracker there is a much more complete, RO-like JNSQ patch from another user. |
2 participants
The stock RA config places DSN dishes in the middle of the ocean when used with JNSQ (Kerbin changes a lot there) so I wrote my own basic config.
This patch adds a few DSN locations along the equator, two on islands east of KSC to support eastward launches and one west of the desert airfield. I've also added two L-band dishes, one in the northern hemisphere and one in the south.
I might add more to this at some point but I plan to start playing JNSQ with this config for now. I've tested the locations (in that the dishes show up as objects on the ground and can be acquired from orbit) but additional testing is welcome.