-
Notifications
You must be signed in to change notification settings - Fork 505
Vocabulary preloadlevel fix #3819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…-preloadlevel-fix-main # Conflicts: # src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.spec.ts # src/app/shared/form/vocabulary-treeview/vocabulary-treeview.component.ts
|
Hi @tdonohue , |
tdonohue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AAwouters ! I tested this via #3820 , which has identical code, and it works well.
I also found that this "preloadLevel" configuration is undocumented (along with a few other configs in "authority.cfg"), so I've added docs to 7.x/8.x/9.x. For example: https://wiki.lyrasis.org/display/DSDOC9x/Authority+Control+of+Metadata+Values#AuthorityControlofMetadataValues-AdditionalconfigurationsforHierarchicalControlledVocabularies
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-9_x
git worktree add -d .worktree/backport-3819-to-dspace-9_x origin/dspace-9_x
cd .worktree/backport-3819-to-dspace-9_x
git switch --create backport-3819-to-dspace-9_x
git cherry-pick -x cee9d0422b5901f3f0265fd19349923baa07df92 9406f7b0850f34a3138efa6f98b6785a05eda64b 4ffde928d46cdfaa0489aeb5760c3cfcff21a76b |
|
@AAwouters : Could you please backport this to |

References
Backports
#3820
#3821
Description
Two changes are made:
Before initializing a treeview, an attempt is made to retrieve the
preloadLevelvalue for the opened vocabulary.If a value is found the preloadLevel is set to that value, otherwise 1 is used.
Whenever a node is initialized and that node is on a level lower than the preloadLevel, that node is immediately expanded.
Instructions for Reviewers
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.