Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently all the themed components in
src/themeshave been migrated to standalone declaration, but they don't work unlesss they are referenced inside either theLazyThemeModuleorEagerThemeModule. I updated the config in order to remove this constraint, this way we won't have to fix merge conflicts in those files anymore.The reason why those modules were still necesarry is because the
tconfig.*.jsonfiles only compile the*.module.tsfiles inside thesrc/themesfolder. Since those modules contained imports to all the components inside the theme, they were automatically comiled as well. I updated the config to compile all the typescript files inside thesrc/themesfolder, this way we can drop the modules.Instructions for Reviewers
List of changes in this PR:
tsconfig.*.jsonfiles to compile all the typescript files inside thesrc/themesfolder instead & removed the unusedangularCompilerOptions.entryModuleproperty that isn't being used anymore since the switch to standalone componentsLazyThemeModulesEagerThemeModules and replaced them with 2 arrays:lazy-listable-components.ts#LISTABLE_COMPONENTS: This is similar to the oldENTRY_COMPONENTSarray, but it only contains imports for components that use@listableObjectComponentdecorators. Other dynamically loaded components that don't use custom decorators likeStartsWithDateComponentshould be declared in the decorator files instead (e.g.starts-with-decorator.ts).eager-theme-components.ts#COMPONENTS: This is similar to theDECLARATIONSarray from the oldEagerThemeModule, except that it doesn't contain theENTRY_COMPONENTSentriesGuidance for how to test or review this PR:
build:statsfor this)Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.