Skip to content

Conversation

@alexandrevryghem
Copy link
Member

Description

Currently all the themed components in src/themes have been migrated to standalone declaration, but they don't work unlesss they are referenced inside either the LazyThemeModule or EagerThemeModule. I updated the config in order to remove this constraint, this way we won't have to fix merge conflicts in those files anymore.

The reason why those modules were still necesarry is because the tconfig.*.json files only compile the *.module.ts files inside the src/themes folder. Since those modules contained imports to all the components inside the theme, they were automatically comiled as well. I updated the config to compile all the typescript files inside the src/themes folder, this way we can drop the modules.

Instructions for Reviewers

List of changes in this PR:

  • Updated the tsconfig.*.json files to compile all the typescript files inside the src/themes folder instead & removed the unused angularCompilerOptions.entryModule property that isn't being used anymore since the switch to standalone components
  • Removed all the LazyThemeModules
  • Removed all the EagerThemeModules and replaced them with 2 arrays:
    • lazy-listable-components.ts#LISTABLE_COMPONENTS: This is similar to the old ENTRY_COMPONENTS array, but it only contains imports for components that use @listableObjectComponent decorators. Other dynamically loaded components that don't use custom decorators like StartsWithDateComponent should be declared in the decorator files instead (e.g. starts-with-decorator.ts).
    • eager-theme-components.ts#COMPONENTS: This is similar to the DECLARATIONS array from the old EagerThemeModule, except that it doesn't contain the ENTRY_COMPONENTS entries

Guidance for how to test or review this PR:

  • Verify that everything still works as expected (you can test it with the custom & eager theme)
  • Verify the bundle size didn't increase (you can use build:stats for this)

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@alexandrevryghem alexandrevryghem self-assigned this Jun 11, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jun 11, 2025
@alexandrevryghem alexandrevryghem force-pushed the w2p-132007_remove-theme-modules_contribute-main branch from a0ebe23 to d7c6b36 Compare July 3, 2025 23:33
@alexandrevryghem alexandrevryghem added this to the 10.0 milestone Aug 22, 2025
@github-actions
Copy link

Hi @alexandrevryghem,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

# Conflicts:
#	src/app/core/shared/listable.module.ts
@alexandrevryghem alexandrevryghem force-pushed the w2p-132007_remove-theme-modules_contribute-main branch from d7c6b36 to 1b2541f Compare November 30, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

2 participants