Skip to content

Conversation

@tamu-sad-iii
Copy link
Contributor

@tamu-sad-iii tamu-sad-iii commented Jul 17, 2025

References

Add references/links to any related issues or PRs. These may include:

Description

In #3506 we ported the frontend to Bootstrap v5 but missed some spacing classes that were renamed.

See: https://getbootstrap.com/docs/5.3/migration/#utilities-3

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • Rename ml-4 margin left to ms-4 (margin start)

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Jul 17, 2025
@tdonohue
Copy link
Member

@wwtamu : Could you please add a small description to this PR? We really shouldn't be merging anything that just has "template text" (as it's not useful to others who stumble on this PR later). :)

@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Jul 17, 2025
@alanorth
Copy link
Contributor

Hi @tdonohue, I've updated the issue text since @wwtamu and I were discussing this on Slack today and I suggested he file the issue. Thanks @wwtamu!

@alanorth alanorth changed the title Update object-list.component.html refactoring bootstrap spacing class Update legacy Bootstrap spacing class in object-list.component.html Jul 18, 2025
@tdonohue tdonohue added this to the 10.0 milestone Jul 18, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @wwtamu for catching this! (And thanks @alanorth for the help on the description / explanation)

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Jul 18, 2025
@tdonohue tdonohue merged commit 9c37858 into DSpace:main Jul 18, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Jul 18, 2025
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-9_x:

@tdonohue tdonohue removed the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants