Add Network Error Dialog layout #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a Network Error Dialog by reusing the existing ConfirmDialog layout, adding a new string resource and a new composable function to trigger a network error UI.
- Adds a new string resource for the network error default message in strings.xml
- Introduces NetworkErrorDialog.kt that wraps ConfirmDialog to handle network error scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| presentation/src/main/res/values/strings.xml | Added network error default message string for dialog display |
| presentation/src/main/java/daily/dayo/presentation/view/dialog/NetworkErrorDialog.kt | Added a new composable wrapper function to display the network error dialog |
yuni-ju
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 사항
ConfirmDialog를 이용해 Network Error Dialog 구현참고