Fix layout of comment section #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DongJun-H
approved these changes
Jun 27, 2025
Member
Author
|
@DongJun-H 추가된 기능 한번 더 확인 부탁드립니다 ^-^
|
DongJun-H
reviewed
Jun 30, 2025
Comment on lines
485
to
504
| text = stringResource(R.string.comment_button_text), | ||
| textAlign = TextAlign.Center, | ||
| style = DayoTheme.typography.b5.copy(color = White_FFFFFF, fontWeight = FontWeight.SemiBold), | ||
| Box( | ||
| modifier = Modifier | ||
| .defaultMinSize(minWidth = 64.dp, minHeight = 36.dp) | ||
| .background(Primary_23C882, shape = RoundedCornerShape(12.dp)) | ||
| .clickableSingle { onClickPostComment() } | ||
| .padding(vertical = 8.dp, horizontal = 12.dp) | ||
| ) | ||
| .clip(RoundedCornerShape(12.dp)) | ||
| .background(color = if (enabled) Primary_23C882 else PrimaryL1_8FD9B9) | ||
| .clickableSingle(enabled = enabled) { onClickPostComment() } | ||
| .padding(vertical = 8.dp, horizontal = 12.dp), | ||
| contentAlignment = Alignment.Center | ||
| ) { | ||
| Text( | ||
| text = stringResource(R.string.comment_button_text), | ||
| color = if (enabled) White_FFFFFF else PrimaryL3_F2FBF7, | ||
| fontWeight = FontWeight.SemiBold, | ||
| textAlign = TextAlign.Center, | ||
| style = DayoTheme.typography.b5 | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
FilledRoundedCornerButton 공통 컴포넌트로 대체할수 있을까요??
Member
Author
There was a problem hiding this comment.
해당 버튼만 공통 컴포넌트랑 조금 다르게 생겨서 파라미터를 추가해야할 것 같아 새로 만들었습니다! 🥲
DongJun-H
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
참고