DanMesh · gonzodepedro · Oct 4, 2023 · Oct 4, 2023 · Oct 11, 2023 · Nov 6, 2023
diff --git a/.github/workflows/check-copied-type-description-sources.yaml b/.github/workflows/check-copied-type-description-sources.yaml
@@ -11,12 +11,12 @@ jobs:
     steps:
     - uses: actions/checkout@v3
     - name: Check fingerprint changed
-      uses: tj-actions/changed-files@v35
+      uses: tj-actions/changed-files@v41
       id: changed-fingerprint
       with:
         files: scripts/type_description.fingerprint
     - name: Check type description sources changed
-      uses: tj-actions/changed-files@v35
+      uses: tj-actions/changed-files@v41
       id: changed-copied-sources
       with:
         files: |

diff --git a/rosidl_adapter/CHANGELOG.rst b/rosidl_adapter/CHANGELOG.rst
@@ -2,6 +2,18 @@
 Changelog for package rosidl_adapter
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+4.5.1 (2024-02-07)
+------------------
+
+4.5.0 (2023-12-26)
+------------------
+
+4.4.2 (2023-11-06)
+------------------
+
+4.4.1 (2023-10-04)
+------------------
+
 4.4.0 (2023-09-07)
 ------------------
 

diff --git a/rosidl_adapter/package.xml b/rosidl_adapter/package.xml
@@ -2,7 +2,7 @@
 <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="2">
   <name>rosidl_adapter</name>
-  <version>4.4.0</version>
+  <version>4.5.1</version>
   <description>
     API and scripts to parse .msg/.srv/.action files and convert them to .idl.
   </description>

diff --git a/rosidl_cli/CHANGELOG.rst b/rosidl_cli/CHANGELOG.rst
@@ -2,6 +2,18 @@
 Changelog for package rosidl_cli
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+4.5.1 (2024-02-07)
+------------------
+
+4.5.0 (2023-12-26)
+------------------
+
+4.4.2 (2023-11-06)
+------------------
+
+4.4.1 (2023-10-04)
+------------------
+
 4.4.0 (2023-09-07)
 ------------------
 

diff --git a/rosidl_cli/package.xml b/rosidl_cli/package.xml
@@ -2,7 +2,7 @@
 <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="2">
   <name>rosidl_cli</name>
-  <version>4.4.0</version>
+  <version>4.5.1</version>
   <description>
     Command line tools for ROS interface generation.
   </description>

diff --git a/rosidl_cli/setup.py b/rosidl_cli/setup.py
@@ -3,7 +3,7 @@
 
 setup(
     name='rosidl_cli',
-    version='4.4.0',
+    version='4.5.1',
     packages=find_packages(exclude=['test']),
     extras_require={
         'completion': ['argcomplete'],

diff --git a/rosidl_cmake/CHANGELOG.rst b/rosidl_cmake/CHANGELOG.rst
@@ -2,6 +2,18 @@
 Changelog for package rosidl_cmake
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+4.5.1 (2024-02-07)
+------------------
+
+4.5.0 (2023-12-26)
+------------------
+
+4.4.2 (2023-11-06)
+------------------
+
+4.4.1 (2023-10-04)
+------------------
+
 4.4.0 (2023-09-07)
 ------------------
 * Add rosidl_find_package_idl helper function (`#754 <https://github.com/ros2/rosidl/issues/754>`_)

diff --git a/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake b/rosidl_cmake/cmake/rosidl_generate_interfaces.cmake
@@ -284,6 +284,23 @@ macro(rosidl_generate_interfaces target)
   set(rosidl_generator_arguments_files)
   ament_execute_extensions("rosidl_write_generator_arguments_extensions")
 
+
+  # By default, without the settings below, find_package(Python3) will attempt
+  # to find the newest python version it can, and additionally will find the
+  # most specific version.  For instance, on a system that has
+  # /usr/bin/python3.10, /usr/bin/python3.11, and /usr/bin/python3, it will find
+  # /usr/bin/python3.11, even if /usr/bin/python3 points to /usr/bin/python3.10.
+  # The behavior we want is to prefer the "system" installed version unless the
+  # user specifically tells us othewise through the Python3_EXECUTABLE hint.
+  # Setting CMP0094 to NEW means that the search will stop after the first
+  # python version is found.  Setting Python3_FIND_UNVERSIONED_NAMES means that
+  # the search will prefer /usr/bin/python3 over /usr/bin/python3.11.  And that
+  # latter functionality is only available in CMake 3.20 or later, so we need
+  # at least that version.
+  cmake_minimum_required(VERSION 3.20)
+  cmake_policy(SET CMP0094 NEW)
+  set(Python3_FIND_UNVERSIONED_NAMES FIRST)
+
   find_package(Python3 REQUIRED COMPONENTS Interpreter)
 
   # Generate the interface source files for all registered languages and type supports

diff --git a/rosidl_cmake/cmake/rosidl_target_interfaces.cmake b/rosidl_cmake/cmake/rosidl_target_interfaces.cmake
@@ -29,7 +29,10 @@
 # @public
 #
 function(rosidl_target_interfaces target interface_target typesupport_name)
-  message(DEPRECATION "Use rosidl_get_typesupport_target() and target_link_libraries() instead of rosidl_target_interfaces()")
+  message(DEPRECATION "Use rosidl_get_typesupport_target() and target_link_libraries() instead of rosidl_target_interfaces(). i.e:
+  rosidl_get_typesupport_target(cpp_typesupport_target \"\${PROJECT_NAME}\" \"rosidl_typesupport_cpp\")
+  target_link_libraries(\${PROJECT_NAME}_node \"\${cpp_typesupport_target}\")
+")
   if(ARGN)
     message(FATAL_ERROR
       "rosidl_target_interfaces() called with unused arguments: ${ARGN}")

diff --git a/rosidl_cmake/package.xml b/rosidl_cmake/package.xml
@@ -2,7 +2,7 @@
 <?xml-model href="http://download.ros.org/schema/package_format2.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="2">
   <name>rosidl_cmake</name>
-  <version>4.4.0</version>
+  <version>4.5.1</version>
   <description>The CMake functionality to invoke code generation for ROS interface files.</description>
 
   <maintainer email="aditya.pande@openrobotics.org">Aditya Pande</maintainer>

diff --git a/rosidl_generator_c/CHANGELOG.rst b/rosidl_generator_c/CHANGELOG.rst
@@ -2,6 +2,18 @@
 Changelog for package rosidl_generator_c
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+4.5.1 (2024-02-07)
+------------------
+
+4.5.0 (2023-12-26)
+------------------
+
+4.4.2 (2023-11-06)
+------------------
+
+4.4.1 (2023-10-04)
+------------------
+
 4.4.0 (2023-09-07)
 ------------------
 * Add rosidl_find_package_idl helper function (`#754 <https://github.com/ros2/rosidl/issues/754>`_)

diff --git a/rosidl_generator_c/package.xml b/rosidl_generator_c/package.xml
@@ -2,7 +2,7 @@
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
   <name>rosidl_generator_c</name>
-  <version>4.4.0</version>
+  <version>4.5.1</version>
   <description>Generate the ROS interfaces in C.</description>
 
   <maintainer email="aditya.pande@openrobotics.org">Aditya Pande</maintainer>

diff --git a/rosidl_generator_cpp/CHANGELOG.rst b/rosidl_generator_cpp/CHANGELOG.rst
@@ -2,6 +2,20 @@
 Changelog for package rosidl_generator_cpp
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+4.5.1 (2024-02-07)
+------------------
+
+4.5.0 (2023-12-26)
+------------------
+
+4.4.2 (2023-11-06)
+------------------
+* Fix constant generation for C++ floats (`#772 <https://github.com/ros2/rosidl/issues/772>`_)
+* Contributors: Chris Lalancette
+
+4.4.1 (2023-10-04)
+------------------
+
 4.4.0 (2023-09-07)
 ------------------
 * Add rosidl_find_package_idl helper function (`#754 <https://github.com/ros2/rosidl/issues/754>`_)

diff --git a/rosidl_generator_cpp/package.xml b/rosidl_generator_cpp/package.xml
@@ -2,7 +2,7 @@
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
   <name>rosidl_generator_cpp</name>
-  <version>4.4.0</version>
+  <version>4.5.1</version>
   <description>Generate the ROS interfaces in C++.</description>
 
   <maintainer email="aditya.pande@openrobotics.org">Aditya Pande</maintainer>

diff --git a/rosidl_generator_cpp/resource/msg__struct.hpp.em b/rosidl_generator_cpp/resource/msg__struct.hpp.em
@@ -280,10 +280,16 @@ non_defaulted_zero_initialized_members = [
   static const @(MSG_TYPE_TO_CPP['wstring']) @(constant.name);
 @[ else]@
   static constexpr @(MSG_TYPE_TO_CPP[constant.type.typename]) @(constant.name) =
-@[  if isinstance(constant.type, BasicType) and constant.type.typename in (*INTEGER_TYPES, *CHARACTER_TYPES, BOOLEAN_TYPE, OCTET_TYPE)]@
+@[  if isinstance(constant.type, BasicType)]@
+@[   if constant.type.typename in (*INTEGER_TYPES, *CHARACTER_TYPES, BOOLEAN_TYPE, OCTET_TYPE)]@
     @(int(constant.value))@
-@[   if constant.type.typename in UNSIGNED_INTEGER_TYPES]@
+@[    if constant.type.typename in UNSIGNED_INTEGER_TYPES]@
 u@
+@[    end if]@
+@[   elif constant.type.typename == 'float']@
+    @(constant.value)f@
+@[   else]@
+    @(constant.value)@
 @[   end if];
 @[  else]@
     @(constant.value);

diff --git a/rosidl_generator_tests/CHANGELOG.rst b/rosidl_generator_tests/CHANGELOG.rst
@@ -2,6 +2,20 @@
 Changelog for package rosidl_generator_tests
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+4.5.1 (2024-02-07)
+------------------
+
+4.5.0 (2023-12-26)
+------------------
+
+4.4.2 (2023-11-06)
+------------------
+* Fix constant generation for C++ floats (`#772 <https://github.com/ros2/rosidl/issues/772>`_)
+* Contributors: Chris Lalancette
+
+4.4.1 (2023-10-04)
+------------------
+
 4.4.0 (2023-09-07)
 ------------------
 

diff --git a/rosidl_generator_tests/CMakeLists.txt b/rosidl_generator_tests/CMakeLists.txt
@@ -35,6 +35,7 @@ if(BUILD_TESTING)
     ${test_interface_files_MSG_FILES}
     ${test_interface_files_SRV_FILES}
     msg/BasicIdl.idl
+    msg/SmallConstant.msg
     ADD_LINTER_TESTS
     SKIP_INSTALL
   )

diff --git a/rosidl_generator_tests/msg/SmallConstant.msg b/rosidl_generator_tests/msg/SmallConstant.msg
@@ -0,0 +1 @@
+float32 FLOAT32_CONST=0.05
diff --git a/rosidl_generator_tests/package.xml b/rosidl_generator_tests/package.xml
@@ -2,7 +2,7 @@
 <?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
 <package format="3">
   <name>rosidl_generator_tests</name>
-  <version>4.4.0</version>
+  <version>4.5.1</version>
   <description>Integration tests for rosidl_generator_c and rosidl_generator_cpp packages.</description>
 
   <maintainer email="aditya.pande@openrobotics.org">Aditya Pande</maintainer>