Conversation
Darkhax
left a comment
Darkhax
left a comment
There was a problem hiding this comment.
Thanks for the PR. I've gone through and left a few notes on things that aren't quite right.
| { | ||
| "tipsmod.title.default": "Tip", | ||
|
|
||
| "tipsmod.tip.no_tips": "No tips have been loaded. Please review the configuration.", |
There was a problem hiding this comment.
This entry fixes an issue in the base en_us. Instead of including it with localization it should be fixed in the en_us.json file instead.
| @@ -0,0 +1,102 @@ | |||
| { | |||
| "tipsmod.title.default": "Tip", | |||
There was a problem hiding this comment.
Lines that do not change from en_us to en_gb should not be included. They're unnecessary, make the file size bigger, and make things harder to maintain as they prevent changes and corrections in the en_us file from propagating.
| "tipsmod.tip.smoke_bees": "Placing a Campfire beneath a Bee Nest will make those Bees passive.", | ||
| "tipsmod.tip.lava_fuel": "Lava Buckets can be used as fuel in the Furnace.", | ||
| "tipsmod.tip.wooden_tool_fuel": "Old Wooden tools can be used as fuel in the Furnace.", | ||
| "tipsmod.tip.scrap_nuggets": "Gold and Iron tools/armour can be smelted into nuggets.", |
| "tipsmod.tip.boat_passenger": "Boats can carry two passengers.", | ||
| "tipsmod.tip.shulker_golem": "Shulkers are considered a type of Golem.", | ||
| "tipsmod.tip.note_block_instrument": "The instrument of a Note Block is determined by the block underneath it.", | ||
| "tipsmod.tip.zombie_armor": "Zombies have two base points of armour, even when they are not wearing any.", |
| "tipsmod.tip.wax_copper": "Honeycombs can be used to wax copper blocks. This prevents them from oxidizing.", | ||
| "tipsmod.tip.freezing_leather": "Leather armor can protect against freezing damage.", | ||
| "tipsmod.tip.azalea_caves": "Azalea trees grow above the lush cave biomes.", | ||
| "tipsmod.tip.end_dimension": "You cannot leave the end dimension without defeating the ender dragon... or dying.", |
There was a problem hiding this comment.
This entry fixes an issue in the base en_us. Instead of including it with localization it should be fixed in the en_us.json file instead.
2 participants
A few localisation spelling adjustments.