Skip to content

Conversation

@JulianVennen
Copy link
Contributor

@JulianVennen JulianVennen commented Feb 18, 2025

Implements #24

"net.neoforged.gradle", "NeoForge",
"net.neoforged.gradle.userdev", "NeoForge"
"net.neoforged.gradle.userdev", "NeoForge",
"net.neoforged.moddev", "NeoForge"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the net.neoforged.moddev plugin is also used in loaderless (common) environments so this would create a false positive. This would not be an issue in the majority of use cases but could still create confusion. This is why #24 was rejected as well. I think the correct approach would be to check if it has the plugin and does not have the neoFormVersion property, but there may also be a more reliable way to detect it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add moddevgradle as a dependency to check if that property is set. Unfortunately, the "getNeoFormVersion" throws a slightly weird exception if it isn't set, and the underlying workflow dependency stuff is marked as internal, so the result is a little hacky.

@JulianVennen JulianVennen requested a review from Darkhax December 1, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants