-
Notifications
You must be signed in to change notification settings - Fork 21
[CTM-142] New terra base image #4888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
LizBaldo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your testing plan, could you make sure to:
- Test the new base image with GPUs?
- Test that the existing images (COS and dataproc) still work with these new startup scripts?
| errorDetails: RuntimeErrorDetails, | ||
| mainInstance: Option[DataprocInstance], | ||
| deleteRuntime: Boolean = true | ||
| deleteRuntime: Boolean = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know this already, but just a ping to remove before merging :)
| JUPYTER_HOME=/etc/jupyter | ||
| JUPYTER_SCRIPTS=$JUPYTER_HOME/scripts | ||
| JUPYTER_USER_HOME=$(jupyterHomeDirectory) | ||
| JUPYTER_EXTENSIONS=$JUPYTER_HOME/extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you leave a comment around what is in scripts vs. extensions?
Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-142
Summary of changes
What
Why
Testing these changes
What to test
Who tested and where
jenkins retestorjenkins multi-test.