BagIt modules and initial support classes #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emetsger
force-pushed
the
bagit-module
branch
from
122307d to
ba3dba1
Compare
…l meaning used to make up expressions.
…a value. BoundToken doesn't quite pass the smell test because it really only serves a purpose for LITERAL tokens. The other tokens already have a value in their 'tokenString' field.
1. Added a parseString(...) method to Token, which will return a List<BoundToken> containing all the Tokens in the supplied String.
2. Changed the behavior of parse(...) to return BoundToken instead of Token.
3. Changed behavior of parse(...) to return a BoundToken for every literal character encountered. Before it would return a single LITERAL token even if multiple literal characters were encountered. The behavior of parseString(...) also returns a LITERAL BoundToken for each literal character.
The behaviors of parse(...) and parseString(...) differ, however, and this may be fixed in the future:
- parse("**") returns a single BoundToken(DIR, "**")
- parseString("**") returns a List<BoundToken> containing two BoundToken(ZERO_OR_MORE_CHARACTERS, "*")
…nd Javadoc. Expression represents a path, or a pattern to match a path. The ExpressionMatcher is responsible for matching a path Expression against a pattern Expression. There is still some work to do here with regard to path separators, and tokenizing Expression strings that end with "/". There is one unit test to resolve, and some more Javadoc to do, class/method level as well as package level.
emetsger
force-pushed
the
bagit-module
branch
from
d6f32da to
1b0a6db
Compare
…n: mistakenly used BoundToken.toString() instead of intentionally composing a string representation of the the BoundToken.
…match(CharSequence, CharSequence, int, int, int, int) from having to handle '**' tokens. Includes test and Javadoc updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for the initial BagIt modules, a base module and one module for support classes. Initially the support module has a BagUri class and another class for representing the roles played by various files in the BagIt specification.