Skip to content

[OTAGENT-988] Add otelstandalone E2E framework component for standalone DaemonSet provisioning#49410

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomainfrom
yang.song/OTAGENT-988
Apr 16, 2026
Merged

[OTAGENT-988] Add otelstandalone E2E framework component for standalone DaemonSet provisioning#49410
gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits intomainfrom
yang.song/OTAGENT-988

Conversation

@songy23
Copy link
Copy Markdown
Member

@songy23 songy23 commented Apr 15, 2026

What does this PR do?

Add otelstandalone.K8sAppDefinition() — a Pulumi component that deploys the
otel-agent as a raw Kubernetes DaemonSet (no Helm chart) suitable for
DD_OTEL_STANDALONE=true E2E tests.

The Helm chart always includes a core-agent container and does not expose a
values path to set env vars on the otel-agent sidecar, making true standalone
testing (no core agent, full control of DD_HOSTNAME / DD_SECRET_BACKEND_COMMAND)
impossible via the existing framework paths.

New component (test/e2e-framework/components/datadog/otel-standalone/k8s.go):

  • Deploys Namespace, ConfigMap, ServiceAccount, ClusterRole/Binding, Service,
    DaemonSet with the correct RBAC for workloadmeta (pods, nodes, namespaces,
    deployments, etc.)
  • Merges the fakeintake URL into OTel exporter config at Pulumi apply time
  • AppOption functional API: WithExtraEnvVars, WithExtraVolumes,
    WithExtraVolumeMounts, WithK8sSecret, WithoutDefaultHostname
  • Routes DD_DD_URL to fakeintake so serializer-pipeline metrics are captured

Extended KindVM scenario (test/e2e-framework/scenarios/aws/kindvm/):

  • StandaloneAgentDeployFunc type + WithStandaloneOTelAgent(fn) RunOption
  • RunWithEnv invokes the callback and skips DisableAgent() guard when set

Extended local KinD provisioner (test/e2e-framework/testing/provisioners/local/kubernetes/):

  • Same StandaloneAgentDeployFunc / WithStandaloneOTelAgent pattern
  • Fixed fakeIntake variable scoping (was inaccessible to standalone path)

Motivation

Add support to test standalone DDOT without core Agent in E2E tests

Describe how you validated your changes

N/A this is on E2E tests

Additional Notes

songy23 and others added 2 commits April 15, 2026 15:10
…ne DaemonSet provisioning

Add otelstandalone.K8sAppDefinition() — a Pulumi component that deploys the
otel-agent as a raw Kubernetes DaemonSet (no Helm chart) suitable for
DD_OTEL_STANDALONE=true E2E tests.

The Helm chart always includes a core-agent container and does not expose a
values path to set env vars on the otel-agent sidecar, making true standalone
testing (no core agent, full control of DD_HOSTNAME / DD_SECRET_BACKEND_COMMAND)
impossible via the existing framework paths.

New component (test/e2e-framework/components/datadog/otel-standalone/k8s.go):
- Deploys Namespace, ConfigMap, ServiceAccount, ClusterRole/Binding, Service,
  DaemonSet with the correct RBAC for workloadmeta (pods, nodes, namespaces,
  deployments, etc.)
- Merges the fakeintake URL into OTel exporter config at Pulumi apply time
- AppOption functional API: WithExtraEnvVars, WithExtraVolumes,
  WithExtraVolumeMounts, WithK8sSecret, WithoutDefaultHostname
- Routes DD_DD_URL to fakeintake so serializer-pipeline metrics are captured

Extended KindVM scenario (test/e2e-framework/scenarios/aws/kindvm/):
- StandaloneAgentDeployFunc type + WithStandaloneOTelAgent(fn) RunOption
- RunWithEnv invokes the callback and skips DisableAgent() guard when set

Extended local KinD provisioner (test/e2e-framework/testing/provisioners/local/kubernetes/):
- Same StandaloneAgentDeployFunc / WithStandaloneOTelAgent pattern
- Fixed fakeIntake variable scoping (was inaccessible to standalone path)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… component

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@songy23 songy23 added this to the 7.79.0 milestone Apr 15, 2026
@songy23 songy23 added qa/done QA done before merge and regressions are covered by tests qa/no-code-change No code change in Agent code requiring validation team/opentelemetry-agent labels Apr 15, 2026
Comment thread .github/CODEOWNERS Outdated
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Apr 15, 2026
@github-actions github-actions bot added the medium review PR review might take time label Apr 15, 2026
@songy23 songy23 added changelog/no-changelog No changelog entry needed and removed qa/no-code-change No code change in Agent code requiring validation labels Apr 15, 2026
@songy23
Copy link
Copy Markdown
Member Author

songy23 commented Apr 15, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cc090e4819

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread test/e2e-framework/scenarios/aws/kindvm/run.go
Comment thread test/e2e-framework/testing/provisioners/local/kubernetes/kind.go
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 15, 2026

Files inventory check summary

File checks results against ancestor 9f43aa45:

Results for datadog-agent_7.79.0~devel.git.818.86c0085.pipeline.108065085-1_amd64.deb:

No change detected

@songy23 songy23 force-pushed the yang.song/OTAGENT-988 branch from 403c9b4 to cc090e4 Compare April 15, 2026 20:20
@songy23 songy23 marked this pull request as ready for review April 15, 2026 20:34
@songy23 songy23 requested a review from a team as a code owner April 15, 2026 20:34
@songy23
Copy link
Copy Markdown
Member Author

songy23 commented Apr 16, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 16, 2026

View all feedbacks in Devflow UI.

2026-04-16 14:54:24 UTC ℹ️ Start processing command /merge


2026-04-16 14:54:32 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-04-16 18:25:06 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 5h (p90).


2026-04-16 21:12:49 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 610df60 into main Apr 16, 2026
309 of 311 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the yang.song/OTAGENT-988 branch April 16, 2026 21:12
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 70e47cc3-4a49-4896-a6c6-b73853509c3e

Baseline: 295787c
Comparison: 610df60
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.20 [-0.82, +5.21] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +2.20 [-0.82, +5.21] 1 Logs
ddot_metrics_sum_delta memory utilization +0.43 [+0.26, +0.60] 1 Logs
quality_gate_metrics_logs memory utilization +0.41 [+0.16, +0.65] 1 Logs bounds checks dashboard
file_tree memory utilization +0.36 [+0.30, +0.42] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.33 [+0.27, +0.40] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.26 [+0.09, +0.42] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.25 [+0.10, +0.40] 1 Logs
ddot_metrics memory utilization +0.23 [+0.04, +0.41] 1 Logs
ddot_logs memory utilization +0.16 [+0.10, +0.21] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.11 [-0.32, +0.54] 1 Logs
quality_gate_idle_all_features memory utilization +0.09 [+0.06, +0.13] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.50, +0.57] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.11, +0.12] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.21, +0.20] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.22, +0.20] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.42, +0.39] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.13, +0.09] 1 Logs
docker_containers_memory memory utilization -0.23 [-0.31, -0.14] 1 Logs
quality_gate_idle memory utilization -0.31 [-0.35, -0.26] 1 Logs bounds checks dashboard
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.37 [-0.60, -0.15] 1 Logs
otlp_ingest_logs memory utilization -0.50 [-0.60, -0.41] 1 Logs
otlp_ingest_metrics memory utilization -0.53 [-0.68, -0.37] 1 Logs
quality_gate_logs % cpu utilization -0.94 [-2.56, +0.67] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 538 ≥ 26
docker_containers_memory memory_usage 10/10 275.05MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 694 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 0/10 4 > 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.74MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 1/10 4 > 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 500.76MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 210.60MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 342.95 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 413.81MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 1/10 replicas passed. Failed 9 which is > 0. Gate FAILED.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-devx team/opentelemetry-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants