Skip to content

[OTELS-985] omit hostname field from JSON payload when empty#49413

Open
songy23 wants to merge 1 commit intomainfrom
yang.song/OTELS-985
Open

[OTELS-985] omit hostname field from JSON payload when empty#49413
songy23 wants to merge 1 commit intomainfrom
yang.song/OTELS-985

Conversation

@songy23
Copy link
Copy Markdown
Member

@songy23 songy23 commented Apr 15, 2026

What does this PR do?

When the OTel collector runs in ECS Fargate, the hostname service returns "" (intentionally — Fargate tasks have no host). Previously the jsonPayload and jsonServerlessInitPayload structs had no omitempty on the Hostname field, so an empty hostname was serialized as "hostname":"" and sent to the Datadog intake, causing the host reserved attribute to appear as an empty string instead of being absent.

Adding omitempty ensures the hostname key is omitted from the JSON payload when empty, which is the correct behavior for serverless environments.

Motivation

https://datadoghq.atlassian.net/browse/OTELS-985

Describe how you validated your changes

new unit tests

Additional Notes

@songy23 songy23 added this to the 7.79.0 milestone Apr 15, 2026
@songy23 songy23 added qa/done QA done before merge and regressions are covered by tests team/opentelemetry-agent labels Apr 15, 2026
@songy23
Copy link
Copy Markdown
Member Author

songy23 commented Apr 15, 2026

@codex review

@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-log-pipelines labels Apr 15, 2026
@github-actions github-actions bot added the medium review PR review might take time label Apr 15, 2026
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

When the OTel collector runs in ECS Fargate, the hostname service
returns "" (intentionally — Fargate tasks have no host). Previously
the jsonPayload and jsonServerlessInitPayload structs had no omitempty
on the Hostname field, so an empty hostname was serialized as
"hostname":"" and sent to the Datadog intake, causing the host
reserved attribute to appear as an empty string instead of being
absent.

Adding omitempty ensures the hostname key is omitted from the JSON
payload when empty, which is the correct behavior for serverless
environments.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@songy23 songy23 force-pushed the yang.song/OTELS-985 branch from b914404 to daab2d9 Compare April 15, 2026 20:26
@songy23 songy23 marked this pull request as ready for review April 15, 2026 20:31
@songy23 songy23 requested a review from a team as a code owner April 15, 2026 20:31
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 15, 2026

Files inventory check summary

File checks results against ancestor baa53991:

Results for datadog-agent_7.79.0~devel.git.771.daab2d9.pipeline.107898302-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 5fa26d58-65a0-444a-b7d5-a318b1939c3d

Baseline: baa5399
Comparison: daab2d9
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.26 [-1.74, +4.26] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.26 [-1.74, +4.26] 1 Logs
quality_gate_metrics_logs memory utilization +0.67 [+0.43, +0.90] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.36 [+0.18, +0.53] 1 Logs
quality_gate_idle memory utilization +0.35 [+0.30, +0.41] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization +0.33 [+0.25, +0.41] 1 Logs
quality_gate_idle_all_features memory utilization +0.32 [+0.29, +0.36] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.18 [-0.01, +0.37] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.13 [-0.03, +0.28] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.04 [-0.36, +0.44] 1 Logs
otlp_ingest_logs memory utilization +0.02 [-0.07, +0.12] 1 Logs
otlp_ingest_metrics memory utilization +0.01 [-0.14, +0.17] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.12, +0.11] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.01 [-0.44, +0.42] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.01 [-0.28, +0.25] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.53, +0.49] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.04 [-0.16, +0.09] 1 Logs
ddot_logs memory utilization -0.08 [-0.15, -0.01] 1 Logs
file_tree memory utilization -0.11 [-0.17, -0.06] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.13 [-0.35, +0.10] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.18 [-0.23, -0.12] 1 Logs
quality_gate_logs % cpu utilization -0.35 [-1.97, +1.27] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.17 [-1.35, -0.99] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 692 ≥ 26
docker_containers_memory memory_usage 10/10 277.44MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 550 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 0/10 4 > 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 175.00MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 4/10 4 > 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 497.44MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 212.44MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 379.41 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 420.07MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 4/10 replicas passed. Failed 6 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-log-pipelines team/opentelemetry-agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant