Skip to content

Enable dynamic netpath for EUDM mode#49442

Open
jack0x2 wants to merge 1 commit intomainfrom
jack.phillips/eudm-enable-netpath-connections-monitoring
Open

Enable dynamic netpath for EUDM mode#49442
jack0x2 wants to merge 1 commit intomainfrom
jack.phillips/eudm-enable-netpath-connections-monitoring

Conversation

@jack0x2
Copy link
Copy Markdown
Contributor

@jack0x2 jack0x2 commented Apr 16, 2026

What does this PR do?

Enables dynamic network path monitoring when infrastructure_mode: end_user_device is set. Two changes:

  1. Agent config (pkg/config/setup/config.go): Sets network_path.connections_monitoring.enabled = true in the EUDM override so the network path collector actually starts and uses the domain filters that were already being configured.
  2. System-probe config (pkg/system-probe/config/config.go): Enables TracerouteModule when EUDM is active so the agent can run traceroutes via system-probe RPC. Follows the same pattern as NetworkTracerModule enablement.

Motivation

WINA-2590

Describe how you validated your changes

  • Added assertion in TestNetworkPathFiltersEndUserDeviceMode that connections_monitoring.enabled is true
  • Added TestTracerouteModuleEnabledForEUDM table-driven test covering all four combinations (neither, traceroute-only, eudm-only, both)

Additional Notes

This does not change how CNM / the network tracer module is enabled for EUDM — that existing logic at config.go:132 is untouched.

EUDM mode was configuring network path domain filters but never
enabling the collector or traceroute module, so the filters were
effectively dead config. Enable both network_path.connections_monitoring
in the agent and the TracerouteModule in system-probe when
infrastructure_mode is end_user_device.
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Apr 16, 2026
@github-actions github-actions bot added the medium review PR review might take time label Apr 16, 2026
@jack0x2 jack0x2 added qa/done QA done before merge and regressions are covered by tests ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed labels Apr 16, 2026
@jack0x2 jack0x2 marked this pull request as ready for review April 16, 2026 12:36
@jack0x2 jack0x2 requested review from a team as code owners April 16, 2026 12:36
@jack0x2 jack0x2 requested a review from rahulkaukuntla April 16, 2026 12:36
@dd-octo-sts
Copy link
Copy Markdown
Contributor

dd-octo-sts bot commented Apr 16, 2026

Files inventory check summary

File checks results against ancestor a6bdb5d6:

Results for datadog-agent_7.79.0~devel.git.802.5390504.pipeline.107990305-1_amd64.deb:

No change detected

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 7ca37566-e3dd-440c-8119-d50c87c642bd

Baseline: a6bdb5d
Comparison: 5390504
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.78 [-1.25, +4.81] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.78 [-1.25, +4.81] 1 Logs
ddot_metrics memory utilization +0.51 [+0.32, +0.70] 1 Logs
quality_gate_logs % cpu utilization +0.47 [-1.15, +2.09] 1 Logs bounds checks dashboard
file_tree memory utilization +0.40 [+0.35, +0.46] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.39 [+0.24, +0.55] 1 Logs
otlp_ingest_logs memory utilization +0.30 [+0.19, +0.41] 1 Logs
otlp_ingest_metrics memory utilization +0.28 [+0.13, +0.43] 1 Logs
ddot_metrics_sum_delta memory utilization +0.19 [+0.00, +0.37] 1 Logs
quality_gate_idle memory utilization +0.12 [+0.07, +0.17] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput +0.04 [-0.40, +0.48] 1 Logs
ddot_logs memory utilization +0.02 [-0.03, +0.07] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.19, +0.22] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.11, +0.13] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.01 [-0.06, +0.07] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.00 [-0.21, +0.22] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.10, +0.11] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.01 [-0.41, +0.38] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.08 [-0.60, +0.44] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.08 [-0.30, +0.14] 1 Logs
docker_containers_memory memory utilization -0.17 [-0.26, -0.08] 1 Logs
quality_gate_idle_all_features memory utilization -0.36 [-0.40, -0.33] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.46 [-0.63, -0.29] 1 Logs
quality_gate_metrics_logs memory utilization -0.73 [-0.96, -0.50] 1 Logs bounds checks dashboard

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 634 ≥ 26
docker_containers_memory memory_usage 10/10 275.01MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 683 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.22GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 0/10 4 > 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 175.87MiB ≤ 181MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 2/10 4 > 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 494.10MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 207.41MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 348.67 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 414.17MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 2/10 replicas passed. Failed 8 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 0/10 replicas passed. Failed 10 which is > 0. Gate FAILED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-configuration team/ebpf-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants