Open
Conversation
- async-stream: 0.3.5 → 0.3.6 - chrono: 0.4.31 → 0.4.44 - flate2: 1.0.28 → 1.1.9 - futures-core: 0.3.30 → 0.3.32 - lazy_static: 1.4.0 → 1.5.0 - log: 0.4.20 → 0.4.29 - serde: 1.0.197 → 1.0.228 - serde_json: 1.0.114 → 1.0.149 - serde_with: 3.6.1 → 3.17.0 - url: 2.5.0 → 2.5.8 - uuid: 1.8.0 → 1.21.0 - zstd: 0.13.0 → 0.13.3 - rustc_version: 0.4.0 → 0.4.1 (build) - futures: 0.3.28 → 0.3.32 (dev) - futures-util: 0.3.30 → 0.3.32 (dev) - regex: 1.9.5 → 1.12.3 (dev) - sha256: 1.4.0 → 1.6.0 (dev) - tokio: 1.10 → 1.49.0 (dev) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- reqwest: 0.11.24 → 0.13.2 (hyper 1.0, rustls default, query/multipart now opt-in features) - reqwest-middleware: 0.2.5 → 0.5.1 (enable query + multipart features) - reqwest-retry: 0.3.0 → 0.9.1 - rvcr (dead nkzou git pin) → reqwest-vcr 0.4.0 (actively maintained fork, supports reqwest 0.13) - reqwest rustls-tls feature: rustls-tls-webpki-roots → rustls (renamed in 0.13) - urlencoding dev-dep removed (was only used by the now-removed custom VCR matcher) reqwest-vcr uses PartialEq for cassette matching instead of a pluggable matcher. To maintain test stability: - with_modify_request now clears all request headers (was: only auth headers) so that live requests match cassettes under header-inclusive PartialEq - Removed with_request_matcher + req_eq (custom URL/body comparison no longer needed since query ordering and JSON body serialization are deterministic) - Stripped request headers from all 1562 existing cassette files to match the new header-free recording format going forward Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
No code changes needed — env_logger::init() API is unchanged. Removed styling API (fmt::Style/Color) and env_logger::filter module are not used by this project. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
No code changes needed — only Case::Snake and the Casing trait are used; neither was affected by the 0.6→0.11 changes (ScreamingSnake rename, removed Toggle/Alternating/Random variants do not apply here). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
No code changes needed. World derive, given/when/then step macros, event::ScenarioFinished, gherkin types, and step::Context are all unchanged. No async_trait usage to remove. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
No code changes needed. Environment::new(), add_function(), render_str(), State::lookup(), and the fn(&State, String)->String helper pattern all work unchanged in minijinja 2.x. Removed APIs (StructObject, SeqObject, Value::from_iterator) are not used by this project. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The migration from rvcr to reqwest-vcr removed the custom req_eq matcher that compared query params as an unordered set. reqwest-vcr uses strict PartialEq on url::Url, which is sensitive to query param ordering. Feature scenarios add params in a different order than they were recorded in cassettes (e.g. start_month/fields/end_month vs start_month/end_month/fields). Fix: sort query params alphabetically by key on both sides: - with_modify_request now calls sort_query_params() to sort the live request's query params (via query_pairs round-trip which also normalizes percent-encoding, so %3A and : both become %3A) - 108 cassette files updated to have sorted query params Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
fixes #1069 |
|
This PR has been automatically marked as stale because it has not had activity in the last 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.