Skip to content

[SymDB] Do not send telemetry on transient http error #7832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+9 −1
Open

[SymDB] Do not send telemetry on transient http error #7832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion tracer/src/Datadog.Trace/Debugger/Symbols/SymbolsUploader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,15 @@ private async Task<bool> SendSymbol(string symbol)
}

Encoding.UTF8.GetBytes(symbol, 0, symbol.Length, _payload, 0);
return await _api.SendBatchAsync(new ArraySegment<byte>(_payload)).ConfigureAwait(false);
try
{
return await _api.SendBatchAsync(new ArraySegment<byte>(_payload)).ConfigureAwait(false);
}
catch (Exception e)
{
Log.ErrorSkipTelemetry(e, "Error uploading symbol database");
return false;
}
}

private bool TrySerializeClass(Model.Scope classScope, StringBuilder sb, int currentBytes, out int newTotalBytes)
Expand Down
Loading