Skip to content

Set benchmarking jobs as interruptible when outside master #7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Set benchmarking jobs as interruptible when outside master #7841

wants to merge 11 commits into from
+40 −11

Conversation

@igoragoli
Copy link
Contributor

@igoragoli igoragoli commented Nov 19, 2025 •
edited
Loading

Summary of changes

  • Set benchmarking jobs as interruptible when outside master.

Also:

Reason for change

APMSP-2369 and #incident-45572

Why set jobs to interruptible? Because by doing so, we prevent redundant runs from overloading our APM runner capacity.

Why only outside of master? Because benchmarks on master are never redundant: we need every run on master to collect results and maintain a continuous performance history.

Implementation details

Test coverage

A dummy commit, a95a4f9, cancelling previous microbenchmarks from 1cd3cd2:

image

For macrobenchmarks:

image

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Nov 19, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (7841) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration75.38 ± (75.49 - 76.20) ms75.06 ± (75.04 - 75.63) ms-0.4%✅
.NET Framework 4.8 - Bailout
duration79.76 ± (79.52 - 80.18) ms80.46 ± (80.49 - 81.07) ms+0.9%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1109.88 ± (1111.58 - 1122.37) ms1115.11 ± (1120.48 - 1130.73) ms+0.5%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms23.00 ± (22.93 - 23.07) ms22.99 ± (22.92 - 23.06) ms-0.0%✅
process.time_to_main_ms87.18 ± (86.84 - 87.52) ms87.83 ± (87.45 - 88.20) ms+0.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.91 ± (10.91 - 10.91) MB10.93 ± (10.92 - 10.93) MB+0.2%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%✅
.NET Core 3.1 - Bailout
process.internal_duration_ms22.75 ± (22.69 - 22.81) ms22.56 ± (22.51 - 22.62) ms-0.8%✅
process.time_to_main_ms87.56 ± (87.19 - 87.93) ms87.84 ± (87.52 - 88.17) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.95 ± (10.94 - 10.95) MB10.97 ± (10.97 - 10.97) MB+0.2%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms218.72 ± (217.39 - 220.04) ms219.73 ± (218.40 - 221.05) ms+0.5%✅⬆️
process.time_to_main_ms548.05 ± (546.77 - 549.33) ms545.40 ± (544.30 - 546.50) ms-0.5%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed52.62 ± (52.60 - 52.64) MB52.56 ± (52.54 - 52.58) MB-0.1%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.1%✅
.NET 6 - Baseline
process.internal_duration_ms21.67 ± (21.60 - 21.74) ms21.72 ± (21.66 - 21.78) ms+0.2%✅⬆️
process.time_to_main_ms75.78 ± (75.42 - 76.13) ms76.00 ± (75.72 - 76.29) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.61 ± (10.61 - 10.62) MB10.63 ± (10.63 - 10.63) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 6 - Bailout
process.internal_duration_ms21.86 ± (21.79 - 21.94) ms21.80 ± (21.74 - 21.86) ms-0.3%✅
process.time_to_main_ms78.17 ± (77.79 - 78.54) ms77.62 ± (77.30 - 77.95) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed10.67 ± (10.67 - 10.67) MB10.67 ± (10.66 - 10.67) MB-0.0%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms206.31 ± (204.95 - 207.67) ms205.42 ± (204.21 - 206.63) ms-0.4%✅
process.time_to_main_ms513.43 ± (512.06 - 514.80) ms508.65 ± (507.53 - 509.78) ms-0.9%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed51.86 ± (51.83 - 51.89) MB51.57 ± (51.54 - 51.61) MB-0.6%✅
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.0%✅
.NET 8 - Baseline
process.internal_duration_ms19.88 ± (19.81 - 19.95) ms19.84 ± (19.78 - 19.90) ms-0.2%✅
process.time_to_main_ms75.61 ± (75.27 - 75.94) ms75.11 ± (74.77 - 75.45) ms-0.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.66 ± (7.66 - 7.67) MB7.66 ± (7.65 - 7.67) MB-0.1%✅
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%✅
.NET 8 - Bailout
process.internal_duration_ms19.64 ± (19.58 - 19.70) ms19.93 ± (19.87 - 19.98) ms+1.5%✅⬆️
process.time_to_main_ms75.86 ± (75.57 - 76.14) ms77.14 ± (76.83 - 77.44) ms+1.7%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed7.71 ± (7.70 - 7.72) MB7.71 ± (7.70 - 7.71) MB-0.1%✅
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms191.79 ± (190.93 - 192.66) ms189.75 ± (188.91 - 190.59) ms-1.1%✅
process.time_to_main_ms492.11 ± (491.10 - 493.13) ms483.63 ± (482.73 - 484.53) ms-1.7%✅
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%✅
runtime.dotnet.mem.committed38.97 ± (38.93 - 39.01) MB38.93 ± (38.89 - 38.97) MB-0.1%✅
runtime.dotnet.threads.count27 ± (27 - 27)27 ± (27 - 27)+0.0%✅⬆️

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration192.05 ± (191.97 - 192.89) ms193.15 ± (193.30 - 194.39) ms+0.6%✅⬆️
.NET Framework 4.8 - Bailout
duration195.26 ± (195.04 - 195.57) ms197.69 ± (197.50 - 198.24) ms+1.2%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1163.36 ± (1164.37 - 1172.84) ms1163.31 ± (1164.39 - 1171.88) ms-0.0%✅
.NET Core 3.1 - Baseline
process.internal_duration_ms189.26 ± (188.81 - 189.70) ms188.77 ± (188.41 - 189.14) ms-0.3%✅
process.time_to_main_ms81.34 ± (81.06 - 81.62) ms80.86 ± (80.63 - 81.08) ms-0.6%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.05 ± (16.02 - 16.08) MB16.05 ± (16.02 - 16.07) MB-0.0%✅
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)+0.1%✅⬆️
.NET Core 3.1 - Bailout
process.internal_duration_ms187.33 ± (187.01 - 187.65) ms187.95 ± (187.58 - 188.31) ms+0.3%✅⬆️
process.time_to_main_ms81.96 ± (81.84 - 82.07) ms81.92 ± (81.77 - 82.08) ms-0.0%✅
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed16.12 ± (16.09 - 16.15) MB16.16 ± (16.13 - 16.19) MB+0.3%✅⬆️
runtime.dotnet.threads.count21 ± (20 - 21)21 ± (21 - 21)+0.3%✅⬆️
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms394.95 ± (392.64 - 397.26) ms395.11 ± (392.50 - 397.73) ms+0.0%✅⬆️
process.time_to_main_ms518.95 ± (518.27 - 519.62) ms519.88 ± (519.14 - 520.62) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%✅
runtime.dotnet.mem.committed63.05 ± (62.89 - 63.21) MB62.84 ± (62.69 - 63.00) MB-0.3%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
.NET 6 - Baseline
process.internal_duration_ms192.46 ± (192.07 - 192.84) ms192.45 ± (192.12 - 192.78) ms-0.0%✅
process.time_to_main_ms70.02 ± (69.83 - 70.22) ms69.95 ± (69.80 - 70.11) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.34 ± (16.31 - 16.37) MB16.27 ± (16.16 - 16.37) MB-0.4%✅
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-1.8%✅
.NET 6 - Bailout
process.internal_duration_ms191.03 ± (190.75 - 191.31) ms191.64 ± (191.43 - 191.86) ms+0.3%✅⬆️
process.time_to_main_ms70.89 ± (70.77 - 71.00) ms70.82 ± (70.73 - 70.90) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed16.14 ± (16.00 - 16.29) MB16.18 ± (16.05 - 16.32) MB+0.2%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 20)+1.5%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms411.77 ± (408.71 - 414.83) ms417.84 ± (415.09 - 420.60) ms+1.5%✅⬆️
process.time_to_main_ms487.60 ± (487.05 - 488.14) ms488.33 ± (487.27 - 489.38) ms+0.1%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed62.16 ± (62.02 - 62.30) MB62.56 ± (62.47 - 62.66) MB+0.7%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 30)+0.1%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms190.46 ± (190.15 - 190.76) ms193.94 ± (193.45 - 194.44) ms+1.8%✅⬆️
process.time_to_main_ms69.42 ± (69.28 - 69.56) ms70.64 ± (70.44 - 70.83) ms+1.8%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.72 ± (11.69 - 11.75) MB11.71 ± (11.69 - 11.73) MB-0.1%✅
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)+0.9%✅⬆️
.NET 8 - Bailout
process.internal_duration_ms189.46 ± (189.21 - 189.70) ms190.33 ± (190.07 - 190.59) ms+0.5%✅⬆️
process.time_to_main_ms70.39 ± (70.29 - 70.49) ms70.50 ± (70.40 - 70.61) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed11.79 ± (11.76 - 11.83) MB11.80 ± (11.77 - 11.83) MB+0.0%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.3%✅⬆️
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms361.79 ± (360.17 - 363.40) ms366.44 ± (364.96 - 367.92) ms+1.3%✅⬆️
process.time_to_main_ms463.84 ± (463.38 - 464.29) ms463.35 ± (462.48 - 464.22) ms-0.1%✅
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%✅
runtime.dotnet.mem.committed50.44 ± (50.40 - 50.49) MB50.38 ± (50.34 - 50.41) MB-0.1%✅
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.0%✅
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (75ms)  : 71, 80
    master - mean (76ms)  : 71, 81

    section Bailout
    This PR (7841) - mean (81ms)  : 77, 85
    master - mean (80ms)  : 75, 85

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (1,126ms)  : 1051, 1200
    master - mean (1,117ms)  : 1038, 1196
Loading
FakeDbCommand (.NET Core 3.1) 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (118ms)  : 112, 125
    master - mean (118ms)  : 110, 125

    section Bailout
    This PR (7841) - mean (118ms)  : 110, 125
    master - mean (118ms)  : 111, 125

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (798ms)  : 753, 843
    master - mean (800ms)  : 758, 841
Loading
FakeDbCommand (.NET 6) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (105ms)  : 98, 111
    master - mean (104ms)  : 97, 111

    section Bailout
    This PR (7841) - mean (106ms)  : 100, 113
    master - mean (107ms)  : 100, 114

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (746ms)  : 710, 781
    master - mean (754ms)  : 711, 797
Loading
FakeDbCommand (.NET 8) 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (103ms)  : 98, 109
    master - mean (104ms)  : 98, 110

    section Bailout
    This PR (7841) - mean (106ms)  : 100, 111
    master - mean (104ms)  : 99, 109

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (705ms)  : 679, 731
    master - mean (715ms)  : 689, 740
Loading
HttpMessageHandler (.NET Framework 4.8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (194ms)  : 188, 200
    master - mean (192ms)  : 188, 197

    section Bailout
    This PR (7841) - mean (198ms)  : 194, 201
    master - mean (195ms)  : 193, 198

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (1,168ms)  : 1115, 1222
    master - mean (1,169ms)  : 1105, 1232
Loading
HttpMessageHandler (.NET Core 3.1) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (279ms)  : 273, 284
    master - mean (279ms)  : 274, 284

    section Bailout
    This PR (7841) - mean (278ms)  : 274, 282
    master - mean (277ms)  : 273, 281

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (945ms)  : 897, 994
    master - mean (947ms)  : 911, 984
Loading
HttpMessageHandler (.NET 6) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (271ms)  : 265, 276
    master - mean (271ms)  : 266, 275

    section Bailout
    This PR (7841) - mean (270ms)  : 267, 273
    master - mean (270ms)  : 265, 274

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (939ms)  : 890, 988
    master - mean (931ms)  : 882, 979
Loading
HttpMessageHandler (.NET 8) 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (7841) - mean (275ms)  : 265, 284
    master - mean (270ms)  : 265, 274

    section Bailout
    This PR (7841) - mean (270ms)  : 266, 274
    master - mean (269ms)  : 265, 274

    section CallTarget+Inlining+NGEN
    This PR (7841) - mean (862ms)  : 828, 895
    master - mean (857ms)  : 836, 879
Loading

@pr-commenter
Copy link

pr-commenter bot commented Nov 19, 2025

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7841 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.442
  • 3 benchmarks have fewer allocations
  • 9 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 11.1μs 58.6ns 293ns 0 0 0 5.53 KB
master StartStopWithChild netcoreapp3.1 14.1μs 72.7ns 341ns 0 0 0 5.7 KB
master StartStopWithChild net472 22.8μs 123ns 717ns 1 0.335 0.112 6.03 KB
#7841 StartStopWithChild net6.0 10.3μs 57.6ns 355ns 0 0 0 5.51 KB
#7841 StartStopWithChild netcoreapp3.1 13.3μs 68.4ns 342ns 0 0 0 5.71 KB
#7841 StartStopWithChild net472 22.3μs 124ns 814ns 1.03 0.342 0.114 6.03 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 943μs 143ns 553ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.02ms 263ns 1.02μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.23ms 752ns 2.91μs 0 0 0 3.31 KB
#7841 WriteAndFlushEnrichedTraces net6.0 951μs 341ns 1.23μs 0 0 0 2.71 KB
#7841 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 292ns 1.13μs 0 0 0 2.7 KB
#7841 WriteAndFlushEnrichedTraces net472 1.23ms 1.49μs 5.57μs 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 1.06μs 5.91ns 36.9ns 0 0 0 1.22 KB
master AllCycleSimpleBody netcoreapp3.1 1.4μs 7.34ns 35.2ns 0 0 0 1.2 KB
master AllCycleSimpleBody net472 1.04μs 0.214ns 0.773ns 0.193 0 0 1.23 KB
master AllCycleMoreComplexBody net6.0 7μs 32.1ns 129ns 0 0 0 4.72 KB
master AllCycleMoreComplexBody netcoreapp3.1 9μs 33.8ns 126ns 0 0 0 4.62 KB
master AllCycleMoreComplexBody net472 7.65μs 2.35ns 8.8ns 0.727 0 0 4.74 KB
master ObjectExtractorSimpleBody net6.0 319ns 1.59ns 6.57ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 394ns 1.95ns 8.06ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 294ns 0.0443ns 0.172ns 0.0444 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.24μs 33.3ns 173ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.79μs 36.9ns 157ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.74μs 7.45ns 28.9ns 0.572 0 0 3.8 KB
#7841 AllCycleSimpleBody net6.0 1.05μs 6.04ns 49.4ns 0 0 0 1.22 KB
#7841 AllCycleSimpleBody netcoreapp3.1 1.39μs 0.292ns 1.09ns 0 0 0 1.2 KB
#7841 AllCycleSimpleBody net472 1.02μs 0.485ns 1.88ns 0.195 0 0 1.23 KB
#7841 AllCycleMoreComplexBody net6.0 7.31μs 5.54ns 21.5ns 0 0 0 4.72 KB
#7841 AllCycleMoreComplexBody netcoreapp3.1 9.08μs 8.78ns 32.9ns 0 0 0 4.62 KB
#7841 AllCycleMoreComplexBody net472 7.61μs 1.92ns 7.19ns 0.721 0 0 4.74 KB
#7841 ObjectExtractorSimpleBody net6.0 320ns 0.385ns 1.49ns 0 0 0 280 B
#7841 ObjectExtractorSimpleBody netcoreapp3.1 391ns 2.18ns 13.8ns 0 0 0 272 B
#7841 ObjectExtractorSimpleBody net472 295ns 0.0371ns 0.139ns 0.0446 0 0 281 B
#7841 ObjectExtractorMoreComplexBody net6.0 6.19μs 32.7ns 160ns 0 0 0 3.78 KB
#7841 ObjectExtractorMoreComplexBody netcoreapp3.1 7.84μs 30.4ns 114ns 0 0 0 3.69 KB
#7841 ObjectExtractorMoreComplexBody net472 6.74μs 1.35ns 5.04ns 0.572 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.4μs 78.4ns 303ns 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 96.8μs 297ns 1.15μs 0 0 0 32.4 KB
master EncodeArgs net472 111μs 14.2ns 53.3ns 5.01 0 0 32.5 KB
master EncodeLegacyArgs net6.0 145μs 151ns 587ns 0 0 0 2.15 KB
master EncodeLegacyArgs netcoreapp3.1 195μs 197ns 763ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 265μs 20ns 77.5ns 0 0 0 2.16 KB
#7841 EncodeArgs net6.0 76μs 256ns 888ns 0 0 0 32.4 KB
#7841 EncodeArgs netcoreapp3.1 97.2μs 256ns 992ns 0 0 0 32.4 KB
#7841 EncodeArgs net472 110μs 18.3ns 70.7ns 4.96 0 0 32.51 KB
#7841 EncodeLegacyArgs net6.0 147μs 23.4ns 90.7ns 0 0 0 2.14 KB
#7841 EncodeLegacyArgs netcoreapp3.1 199μs 123ns 477ns 0 0 0 2.14 KB
#7841 EncodeLegacyArgs net472 264μs 367ns 1.42μs 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7841

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 1.690 301,427.21 509,384.76
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark‑netcoreapp3.1 1.513 411,384.58 622,602.02

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 390μs 67.1ns 242ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 413μs 661ns 2.56μs 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 428μs 51.2ns 198ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 285μs 77.7ns 301ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 302μs 168ns 581ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 311μs 24.6ns 95.2ns 0 0 0 2.29 KB
#7841 RunWafRealisticBenchmark net6.0 391μs 64.7ns 242ns 0 0 0 4.55 KB
#7841 RunWafRealisticBenchmark netcoreapp3.1 618μs 3.42μs 28.8μs 0 0 0 4.48 KB
#7841 RunWafRealisticBenchmark net472 426μs 59.6ns 231ns 0 0 0 4.66 KB
#7841 RunWafRealisticBenchmarkWithAttack net6.0 283μs 130ns 469ns 0 0 0 2.24 KB
#7841 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 509μs 95.5ns 357ns 0 0 0 2.22 KB
#7841 RunWafRealisticBenchmarkWithAttack net472 311μs 24.8ns 92.7ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 60.8μs 81.4ns 315ns 0 0 0 14.58 KB
master SendRequest netcoreapp3.1 71.5μs 102ns 395ns 0 0 0 17.42 KB
master SendRequest net472 0.00854ns 0.00243ns 0.00943ns 0 0 0 0 b
#7841 SendRequest net6.0 61.3μs 62.8ns 235ns 0 0 0 14.52 KB
#7841 SendRequest netcoreapp3.1 71.5μs 121ns 452ns 0 0 0 17.42 KB
#7841 SendRequest net472 0.00176ns 0.000787ns 0.00305ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7841

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 0 b 73 B 73 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 0 b 47 B 47 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 2 B 5 B 3 B 150.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 4 B 7 B 3 B 75.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.9ms 4.85μs 18.1μs 0 0 0 640 KB
master OriginalCharSlice netcoreapp3.1 2.11ms 7.29μs 27.3μs 0 0 0 640 KB
master OriginalCharSlice net472 2.66ms 146ns 526ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.34ms 240ns 898ns 0 0 0 4 B
master OptimizedCharSlice netcoreapp3.1 1.73ms 2.16μs 8.38μs 0 0 0 1 B
master OptimizedCharSlice net472 1.93ms 1.78μs 6.91μs 0 0 0 0 b
master OptimizedCharSliceWithPool net6.0 801μs 77.9ns 302ns 0 0 0 2 B
master OptimizedCharSliceWithPool netcoreapp3.1 852μs 232ns 900ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.14ms 87.8ns 329ns 0 0 0 0 b
#7841 OriginalCharSlice net6.0 1.89ms 3.49μs 13.5μs 0 0 0 640.01 KB
#7841 OriginalCharSlice netcoreapp3.1 2.07ms 4.81μs 16.7μs 0 0 0 640 KB
#7841 OriginalCharSlice net472 2.59ms 150ns 541ns 100 0 0 641.95 KB
#7841 OptimizedCharSlice net6.0 1.46ms 224ns 867ns 0 0 0 7 B
#7841 OptimizedCharSlice netcoreapp3.1 1.72ms 655ns 2.54μs 0 0 0 1 B
#7841 OptimizedCharSlice net472 1.92ms 241ns 933ns 0 0 0 73 B
#7841 OptimizedCharSliceWithPool net6.0 799μs 103ns 397ns 0 0 0 5 B
#7841 OptimizedCharSliceWithPool netcoreapp3.1 835μs 193ns 748ns 0 0 0 0 b
#7841 OptimizedCharSliceWithPool net472 1.15ms 64.8ns 242ns 0 0 0 47 B
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7841

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 1.171 964,420.98 1,129,801.04

More allocations ⚠️ in #7841

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.78 KB 42.95 KB 1.18 KB 2.82%

Fewer allocations 🎉 in #7841

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net472 56.47 KB 55.81 KB -659 B -1.17%
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0 42.2 KB 41.61 KB -599 B -1.42%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 629μs 1.76μs 6.33μs 0 0 0 42.2 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 719μs 4.14μs 31.5μs 0 0 0 41.78 KB
master WriteAndFlushEnrichedTraces net472 964μs 3.39μs 13.1μs 8.93 0 0 56.47 KB
#7841 WriteAndFlushEnrichedTraces net6.0 671μs 1.73μs 6.47μs 0 0 0 41.61 KB
#7841 WriteAndFlushEnrichedTraces netcoreapp3.1 731μs 780ns 2.92μs 0 0 0 42.95 KB
#7841 WriteAndFlushEnrichedTraces net472 1.12ms 5.37μs 23.4μs 5.21 0 0 55.81 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.91μs 7.99ns 30.9ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.7μs 7.56ns 27.3ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.83μs 1.7ns 6.38ns 0.156 0.0142 0 987 B
#7841 ExecuteNonQuery net6.0 1.94μs 8.68ns 33.6ns 0 0 0 1.02 KB
#7841 ExecuteNonQuery netcoreapp3.1 2.79μs 12.7ns 49.1ns 0 0 0 1.02 KB
#7841 ExecuteNonQuery net472 2.91μs 4.61ns 17.9ns 0.143 0.0143 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.72μs 0.689ns 2.58ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.31μs 10.6ns 41.1ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.59μs 2.37ns 9.17ns 0.16 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.81μs 7ns 27.1ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.41μs 8.22ns 30.7ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.72μs 5.41ns 21ns 0.167 0 0 1.1 KB
#7841 CallElasticsearch net6.0 1.75μs 8.42ns 33.7ns 0 0 0 1.03 KB
#7841 CallElasticsearch netcoreapp3.1 2.27μs 6.88ns 25.8ns 0 0 0 1.03 KB
#7841 CallElasticsearch net472 3.45μs 2.2ns 8.51ns 0.156 0 0 1.04 KB
#7841 CallElasticsearchAsync net6.0 1.88μs 8.96ns 35.9ns 0 0 0 1.01 KB
#7841 CallElasticsearchAsync netcoreapp3.1 2.36μs 11.3ns 43.7ns 0 0 0 1.08 KB
#7841 CallElasticsearchAsync net472 3.78μs 7.22ns 28ns 0.17 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.91μs 6.61ns 25.6ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.44μs 8.59ns 33.3ns 0 0 0 952 B
master ExecuteAsync net472 2.61μs 1.24ns 4.3ns 0.144 0 0 915 B
#7841 ExecuteAsync net6.0 1.87μs 7.43ns 28.8ns 0 0 0 952 B
#7841 ExecuteAsync netcoreapp3.1 2.43μs 6.23ns 24.1ns 0 0 0 952 B
#7841 ExecuteAsync net472 2.7μs 3.78ns 14.6ns 0.135 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 7.01μs 24.1ns 93.3ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.55μs 12.7ns 47.6ns 0 0 0 2.9 KB
master SendAsync net472 12.3μs 8.09ns 30.3ns 0.492 0 0 3.18 KB
#7841 SendAsync net6.0 7.12μs 12.5ns 45.1ns 0 0 0 2.36 KB
#7841 SendAsync netcoreapp3.1 8.54μs 5.21ns 20.2ns 0 0 0 2.9 KB
#7841 SendAsync net472 12.2μs 7.61ns 29.5ns 0.486 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #7841

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 44.1 KB 52.43 KB 8.33 KB 18.88%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472 57.34 KB 65.54 KB 8.19 KB 14.29%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 257.14 KB 277.86 KB 20.72 KB 8.06%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.73 KB 44.04 KB 1.31 KB 3.07%

Fewer allocations 🎉 in #7841

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 276.95 KB 257.59 KB -19.36 KB -6.99%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44μs 237ns 1.28μs 0 0 0 44.1 KB
master StringConcatBenchmark netcoreapp3.1 49.6μs 289ns 2.33μs 0 0 0 42.73 KB
master StringConcatBenchmark net472 57.1μs 251ns 973ns 0 0 0 57.34 KB
master StringConcatAspectBenchmark net6.0 481μs 1.93μs 8.84μs 0 0 0 257.14 KB
master StringConcatAspectBenchmark netcoreapp3.1 553μs 2.35μs 9.1μs 0 0 0 276.95 KB
master StringConcatAspectBenchmark net472 409μs 2.19μs 11.2μs 0 0 0 278.53 KB
#7841 StringConcatBenchmark net6.0 45μs 260ns 1.96μs 0 0 0 52.43 KB
#7841 StringConcatBenchmark netcoreapp3.1 45.6μs 214ns 830ns 0 0 0 44.04 KB
#7841 StringConcatBenchmark net472 55.6μs 261ns 1.01μs 0 0 0 65.54 KB
#7841 StringConcatAspectBenchmark net6.0 506μs 1.91μs 7.63μs 0 0 0 277.86 KB
#7841 StringConcatAspectBenchmark netcoreapp3.1 529μs 2.34μs 9.05μs 0 0 0 257.59 KB
#7841 StringConcatAspectBenchmark net472 410μs 1.82μs 6.81μs 0 0 0 278.53 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.6μs 12.7ns 53.7ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.56μs 16.7ns 64.9ns 0 0 0 1.7 KB
master EnrichedLog net472 3.91μs 4.49ns 17.4ns 0.253 0 0 1.64 KB
#7841 EnrichedLog net6.0 2.63μs 1.03ns 3.99ns 0 0 0 1.7 KB
#7841 EnrichedLog netcoreapp3.1 3.66μs 11.9ns 46.1ns 0 0 0 1.7 KB
#7841 EnrichedLog net472 3.91μs 2.48ns 9.28ns 0.254 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 121μs 55ns 198ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 126μs 38.9ns 135ns 0 0 0 4.31 KB
master EnrichedLog net472 166μs 31.1ns 112ns 0 0 0 4.52 KB
#7841 EnrichedLog net6.0 124μs 35.6ns 133ns 0 0 0 4.31 KB
#7841 EnrichedLog netcoreapp3.1 128μs 47.9ns 179ns 0 0 0 4.31 KB
#7841 EnrichedLog net472 168μs 44.1ns 171ns 0 0 0 4.52 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 5.01μs 2.82ns 10.9ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.75μs 14.7ns 55.2ns 0 0 0 2.26 KB
master EnrichedLog net472 7.56μs 5.86ns 22.7ns 0.302 0 0 2.08 KB
#7841 EnrichedLog net6.0 4.93μs 19.5ns 75.7ns 0 0 0 2.26 KB
#7841 EnrichedLog netcoreapp3.1 6.62μs 23.2ns 89.7ns 0 0 0 2.26 KB
#7841 EnrichedLog net472 7.54μs 10.7ns 41.4ns 0.3 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.98μs 10.2ns 50.8ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.65μs 11.1ns 42.9ns 0 0 0 1.2 KB
master SendReceive net472 3.21μs 5.15ns 19.9ns 0.176 0 0 1.2 KB
#7841 SendReceive net6.0 1.96μs 10.6ns 49.8ns 0 0 0 1.2 KB
#7841 SendReceive netcoreapp3.1 2.58μs 10.2ns 36.8ns 0 0 0 1.2 KB
#7841 SendReceive net472 3.19μs 3.44ns 13.3ns 0.191 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.21μs 2.82ns 10.5ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.65μs 14.4ns 55.9ns 0 0 0 1.63 KB
master EnrichedLog net472 6.44μs 4.44ns 16ns 0.32 0 0 2.03 KB
#7841 EnrichedLog net6.0 4.28μs 5.36ns 20ns 0 0 0 1.58 KB
#7841 EnrichedLog netcoreapp3.1 5.5μs 15.3ns 59.1ns 0 0 0 1.63 KB
#7841 EnrichedLog net472 6.46μs 5.95ns 22.3ns 0.321 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 761ns 3.94ns 19.7ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 978ns 0.909ns 3.52ns 0 0 0 576 B
master StartFinishSpan net472 978ns 0.335ns 1.21ns 0.0882 0 0 578 B
master StartFinishScope net6.0 908ns 4.68ns 22.4ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.18μs 5.86ns 25.6ns 0 0 0 696 B
master StartFinishScope net472 1.19μs 0.243ns 0.875ns 0.0995 0 0 658 B
#7841 StartFinishSpan net6.0 771ns 4.26ns 24.8ns 0 0 0 576 B
#7841 StartFinishSpan netcoreapp3.1 945ns 5.1ns 27.5ns 0 0 0 576 B
#7841 StartFinishSpan net472 951ns 0.371ns 1.44ns 0.0908 0 0 578 B
#7841 StartFinishScope net6.0 912ns 3.16ns 12.3ns 0 0 0 696 B
#7841 StartFinishScope netcoreapp3.1 1.2μs 5.64ns 21.8ns 0 0 0 696 B
#7841 StartFinishScope net472 1.14μs 0.319ns 1.24ns 0.103 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.02μs 5.68ns 33.6ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.44μs 5.48ns 21.2ns 0 0 0 696 B
master RunOnMethodBegin net472 1.56μs 0.988ns 3.83ns 0.101 0 0 658 B
#7841 RunOnMethodBegin net6.0 1.05μs 5.22ns 21.5ns 0 0 0 696 B
#7841 RunOnMethodBegin netcoreapp3.1 1.42μs 7.17ns 31.3ns 0 0 0 696 B
#7841 RunOnMethodBegin net472 1.44μs 0.425ns 1.53ns 0.101 0 0 658 B

@igoragoli igoragoli marked this pull request as ready for review November 19, 2025 09:31
@igoragoli igoragoli requested a review from a team as a code owner November 19, 2025 09:32
chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Nov 19, 2025
View reviewed changes
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

NachoEchevarria
NachoEchevarria approved these changes Nov 19, 2025
View reviewed changes
Copy link
Collaborator

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

andrewlock
andrewlock reviewed Nov 19, 2025
View reviewed changes
.gitlab/benchmarks/macrobenchmarks.yml
Comment on lines +15 to +17
workflow:
auto_cancel:
on_new_commit: interruptible
Copy link
Member

@andrewlock andrewlock Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have DSM throughput tests too - maybe we should update those similarly @robcarlan-datadog?

Copy link
Contributor Author

@igoragoli igoragoli Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I wasn't aware those jobs also used APM runners. Added the same interrupt policy to them 👍

@igoragoli igoragoli requested a review from andrewlock November 20, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@NachoEchevarria NachoEchevarria NachoEchevarria approved these changes

@andrewlock andrewlock Awaiting requested review from andrewlock

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@igoragoli @andrewlock @NachoEchevarria