Add standard output and error when a test fails and does not display it #7847
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
approved these changes
Nov 20, 2025
|
|
||
| if (Process.ExitCode != 0) | ||
| { | ||
| _output.WriteLine($"[DebuggerSampleProcessHelper] Process exited with code {Process.ExitCode} (0x{Process.ExitCode:X})"); |
Member
There was a problem hiding this comment.
I'm not sure if _output is always non null? 🤔 If it is this is all good, otherwise we should maybe add a null check in the if block 🙂
Collaborator
Author
There was a problem hiding this comment.
It should never be null. If it is, something pretty weird is going on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
We get some CI errors in tests caused by a non 0 exit code from a sample but we get no output from the sample itself.
This PR improves error reporting when tests fail due to non-zero exit codes by ensuring that process stdout and stderr are logged to the test output before assertions fail. This makes debugging CI failures significantly easier, especially for signal-related crashes (SIGABRT, SIGSEGV, etc.).
Reason for change
Implementation details
Test coverage
Other details