Skip to content

Migrate JsonMapperTest to Java#10716

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomasterfrom
sarahchen6/g2j-components
Mar 4, 2026
Merged

Migrate JsonMapperTest to Java#10716
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits intomasterfrom
sarahchen6/g2j-components

Conversation

@sarahchen6
Copy link
Contributor

@sarahchen6 sarahchen6 commented Mar 2, 2026 •
edited
Loading

What Does This Do

Migrate JsonMapperTest from Groovy to Java, using the /migrate-groovy-to-java Claude skill. Add a recommendation to the Claude skill for the AI to check that the test count remained the same after migration.

Motivation

This is part of a broader initiative to migrate all testing in this repo to JUnit

Additional Notes

We can see in the logs and artifacts of this job that the JsonMapperTest was run and all tests are still present.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@sarahchen6 sarahchen6 added comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Mar 2, 2026
@pr-commenter
Copy link

pr-commenter bot commented Mar 2, 2026 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/g2j-components
git_commit_date 1772641975 1772645797
git_commit_sha 77900be 5661257
release_version 1.61.0-SNAPSHOT~77900be502 1.60.0-SNAPSHOT~5661257a75
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1772647500 1772647500
ci_job_id 1476036427 1476036427
ci_pipeline_id 100384283 100384283
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-lg51mnc3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-lg51mnc3 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1062561
Total [baseline] (11.014 s) : 0, 11013906
Agent [candidate] (1.057 s) : 0, 1056966
Total [candidate] (11.009 s) : 0, 11009058
section appsec
Agent [baseline] (1.249 s) : 0, 1248947
Total [baseline] (11.158 s) : 0, 11158450
Agent [candidate] (1.25 s) : 0, 1249736
Total [candidate] (11.081 s) : 0, 11081196
section iast
Agent [baseline] (1.225 s) : 0, 1224824
Total [baseline] (11.341 s) : 0, 11341037
Agent [candidate] (1.229 s) : 0, 1229193
Total [candidate] (11.287 s) : 0, 11286744
section profiling
Agent [baseline] (1.189 s) : 0, 1188656
Total [baseline] (11.043 s) : 0, 11043004
Agent [candidate] (1.189 s) : 0, 1189062
Total [candidate] (11.051 s) : 0, 11050904
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent appsec 1.249 s 186.387 ms (17.5%)
Agent iast 1.225 s 162.264 ms (15.3%)
Agent profiling 1.189 s 126.095 ms (11.9%)
Total tracing 11.014 s -
Total appsec 11.158 s 144.543 ms (1.3%)
Total iast 11.341 s 327.131 ms (3.0%)
Total profiling 11.043 s 29.097 ms (0.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.25 s 192.77 ms (18.2%)
Agent iast 1.229 s 172.226 ms (16.3%)
Agent profiling 1.189 s 132.096 ms (12.5%)
Total tracing 11.009 s -
Total appsec 11.081 s 72.138 ms (0.7%)
Total iast 11.287 s 277.686 ms (2.5%)
Total profiling 11.051 s 41.846 ms (0.4%) 
gantt
    title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (629.669 ms) : 0, 629669
BytebuddyAgent [candidate] (628.555 ms) : 0, 628555
AgentMeter [baseline] (29.199 ms) : 0, 29199
AgentMeter [candidate] (29.014 ms) : 0, 29014
GlobalTracer [baseline] (258.038 ms) : 0, 258038
GlobalTracer [candidate] (257.22 ms) : 0, 257220
AppSec [baseline] (31.562 ms) : 0, 31562
AppSec [candidate] (31.407 ms) : 0, 31407
Debugger [baseline] (59.6 ms) : 0, 59600
Debugger [candidate] (59.221 ms) : 0, 59221
Remote Config [baseline] (587.585 µs) : 0, 588
Remote Config [candidate] (593.779 µs) : 0, 594
Telemetry [baseline] (8.651 ms) : 0, 8651
Telemetry [candidate] (8.638 ms) : 0, 8638
Flare Poller [baseline] (8.01 ms) : 0, 8010
Flare Poller [candidate] (5.052 ms) : 0, 5052
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (657.88 ms) : 0, 657880
BytebuddyAgent [candidate] (659.634 ms) : 0, 659634
AgentMeter [baseline] (12.1 ms) : 0, 12100
AgentMeter [candidate] (12.123 ms) : 0, 12123
GlobalTracer [baseline] (259.873 ms) : 0, 259873
GlobalTracer [candidate] (259.251 ms) : 0, 259251
AppSec [baseline] (178.498 ms) : 0, 178498
AppSec [candidate] (178.319 ms) : 0, 178319
Debugger [baseline] (65.884 ms) : 0, 65884
Debugger [candidate] (64.819 ms) : 0, 64819
Remote Config [baseline] (573.704 µs) : 0, 574
Remote Config [candidate] (584.391 µs) : 0, 584
Telemetry [baseline] (8.921 ms) : 0, 8921
Telemetry [candidate] (9.852 ms) : 0, 9852
Flare Poller [baseline] (3.618 ms) : 0, 3618
Flare Poller [candidate] (3.557 ms) : 0, 3557
IAST [baseline] (24.129 ms) : 0, 24129
IAST [candidate] (24.027 ms) : 0, 24027
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (794.603 ms) : 0, 794603
BytebuddyAgent [candidate] (797.571 ms) : 0, 797571
AgentMeter [baseline] (11.297 ms) : 0, 11297
AgentMeter [candidate] (11.353 ms) : 0, 11353
GlobalTracer [baseline] (246.639 ms) : 0, 246639
GlobalTracer [candidate] (247.794 ms) : 0, 247794
AppSec [baseline] (26.256 ms) : 0, 26256
AppSec [candidate] (26.384 ms) : 0, 26384
Debugger [baseline] (63.407 ms) : 0, 63407
Debugger [candidate] (63.461 ms) : 0, 63461
Remote Config [baseline] (531.918 µs) : 0, 532
Remote Config [candidate] (524.768 µs) : 0, 525
Telemetry [baseline] (14.919 ms) : 0, 14919
Telemetry [candidate] (14.841 ms) : 0, 14841
Flare Poller [baseline] (4.928 ms) : 0, 4928
Flare Poller [candidate] (4.894 ms) : 0, 4894
IAST [baseline] (25.05 ms) : 0, 25050
IAST [candidate] (25.096 ms) : 0, 25096
section profiling
ProfilingAgent [baseline] (94.708 ms) : 0, 94708
ProfilingAgent [candidate] (94.564 ms) : 0, 94564
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (686.254 ms) : 0, 686254
BytebuddyAgent [candidate] (686.979 ms) : 0, 686979
AgentMeter [baseline] (8.62 ms) : 0, 8620
AgentMeter [candidate] (8.69 ms) : 0, 8690
GlobalTracer [baseline] (216.641 ms) : 0, 216641
GlobalTracer [candidate] (216.602 ms) : 0, 216602
AppSec [baseline] (32.006 ms) : 0, 32006
AppSec [candidate] (31.956 ms) : 0, 31956
Debugger [baseline] (62.539 ms) : 0, 62539
Debugger [candidate] (62.314 ms) : 0, 62314
Remote Config [baseline] (587.177 µs) : 0, 587
Remote Config [candidate] (582.612 µs) : 0, 583
Telemetry [baseline] (11.3 ms) : 0, 11300
Telemetry [candidate] (10.597 ms) : 0, 10597
Flare Poller [baseline] (3.519 ms) : 0, 3519
Flare Poller [candidate] (4.29 ms) : 0, 4290
Profiling [baseline] (95.279 ms) : 0, 95279
Profiling [candidate] (95.126 ms) : 0, 95126
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060071
Total [baseline] (8.842 s) : 0, 8841860
Agent [candidate] (1.058 s) : 0, 1058055
Total [candidate] (8.812 s) : 0, 8812046
section iast
Agent [baseline] (1.226 s) : 0, 1225805
Total [baseline] (9.575 s) : 0, 9574552
Agent [candidate] (1.237 s) : 0, 1237490
Total [candidate] (9.537 s) : 0, 9537384
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.226 s 165.734 ms (15.6%)
Total tracing 8.842 s -
Total iast 9.575 s 732.692 ms (8.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.058 s -
Agent iast 1.237 s 179.435 ms (17.0%)
Total tracing 8.812 s -
Total iast 9.537 s 725.338 ms (8.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (628.585 ms) : 0, 628585
BytebuddyAgent [candidate] (628.158 ms) : 0, 628158
AgentMeter [baseline] (29.249 ms) : 0, 29249
AgentMeter [candidate] (29.117 ms) : 0, 29117
GlobalTracer [baseline] (257.347 ms) : 0, 257347
GlobalTracer [candidate] (257.039 ms) : 0, 257039
AppSec [baseline] (31.594 ms) : 0, 31594
AppSec [candidate] (31.421 ms) : 0, 31421
Debugger [baseline] (58.653 ms) : 0, 58653
Debugger [candidate] (58.495 ms) : 0, 58495
Remote Config [baseline] (616.316 µs) : 0, 616
Remote Config [candidate] (585.01 µs) : 0, 585
Telemetry [baseline] (8.656 ms) : 0, 8656
Telemetry [candidate] (8.662 ms) : 0, 8662
Flare Poller [baseline] (8.031 ms) : 0, 8031
Flare Poller [candidate] (7.353 ms) : 0, 7353
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (794.776 ms) : 0, 794776
BytebuddyAgent [candidate] (804.286 ms) : 0, 804286
AgentMeter [baseline] (11.28 ms) : 0, 11280
AgentMeter [candidate] (11.618 ms) : 0, 11618
GlobalTracer [baseline] (248.357 ms) : 0, 248357
GlobalTracer [candidate] (248.867 ms) : 0, 248867
IAST [baseline] (25.32 ms) : 0, 25320
IAST [candidate] (25.462 ms) : 0, 25462
AppSec [baseline] (26.451 ms) : 0, 26451
AppSec [candidate] (26.653 ms) : 0, 26653
Debugger [baseline] (62.282 ms) : 0, 62282
Debugger [candidate] (62.922 ms) : 0, 62922
Remote Config [baseline] (521.899 µs) : 0, 522
Remote Config [candidate] (548.316 µs) : 0, 548
Telemetry [baseline] (14.798 ms) : 0, 14798
Telemetry [candidate] (14.799 ms) : 0, 14799
Flare Poller [baseline] (4.853 ms) : 0, 4853
Flare Poller [candidate] (4.88 ms) : 0, 4880
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/g2j-components
git_commit_date 1772641975 1772645797
git_commit_sha 77900be 5661257
release_version 1.61.0-SNAPSHOT~77900be502 1.60.0-SNAPSHOT~5661257a75
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1772647981 1772647981
ci_job_id 1476036428 1476036428
ci_pipeline_id 100384283 100384283
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-l671xnrq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-l671xnrq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:petclinic:profiling:high_load better
[-1.551ms; -0.504ms] or [-7.972%; -2.593%]		 unsure
[-1646.828µs; -105.518µs] or [-5.351%; -0.343%]		 unstable
[-13.703op/s; +37.765op/s] or [-5.769%; +15.899%]		 18.431ms 29.903ms 249.562op/s 19.459ms 30.779ms 237.531op/s
scenario:load:petclinic:no_agent:high_load better
[-1562.916µs; -428.559µs] or [-8.497%; -2.330%]		 unsure
[-2.577ms; -0.324ms] or [-8.383%; -1.056%]		 unstable
[-14.676op/s; +39.926op/s] or [-5.951%; +16.191%]		 17.397ms 29.289ms 259.219op/s 18.393ms 30.740ms 246.594op/s
scenario:load:petclinic:appsec:high_load worse
[+399.729µs; +1235.702µs] or [+2.195%; +6.786%]		 unsure
[+256.228µs; +1589.670µs] or [+0.868%; +5.386%]		 unstable
[-36.126op/s; +15.626op/s] or [-14.320%; +6.194%]		 19.027ms 30.438ms 242.031op/s 18.209ms 29.515ms 252.281op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502
    dateFormat X
    axisFormat %s
section baseline
no_agent (18.926 ms) : 18732, 19120
.   : milestone, 18926,
appsec (18.496 ms) : 18311, 18681
.   : milestone, 18496,
code_origins (17.661 ms) : 17483, 17839
.   : milestone, 17661,
iast (17.926 ms) : 17747, 18105
.   : milestone, 17926,
profiling (19.651 ms) : 19456, 19846
.   : milestone, 19651,
tracing (17.814 ms) : 17639, 17989
.   : milestone, 17814,
section candidate
no_agent (18.003 ms) : 17823, 18184
.   : milestone, 18003,
appsec (19.288 ms) : 19092, 19483
.   : milestone, 19288,
code_origins (17.641 ms) : 17466, 17816
.   : milestone, 17641,
iast (17.83 ms) : 17653, 18007
.   : milestone, 17830,
profiling (18.711 ms) : 18523, 18899
.   : milestone, 18711,
tracing (17.779 ms) : 17605, 17953
.   : milestone, 17779,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.926 ms [18.732 ms, 19.12 ms] -
appsec 18.496 ms [18.311 ms, 18.681 ms] -430.272 µs (-2.3%)
code_origins 17.661 ms [17.483 ms, 17.839 ms] -1.265 ms (-6.7%)
iast 17.926 ms [17.747 ms, 18.105 ms] -1.0 ms (-5.3%)
profiling 19.651 ms [19.456 ms, 19.846 ms] 724.526 µs (3.8%)
tracing 17.814 ms [17.639 ms, 17.989 ms] -1.112 ms (-5.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.003 ms [17.823 ms, 18.184 ms] -
appsec 19.288 ms [19.092 ms, 19.483 ms] 1.284 ms (7.1%)
code_origins 17.641 ms [17.466 ms, 17.816 ms] -362.148 µs (-2.0%)
iast 17.83 ms [17.653 ms, 18.007 ms] -173.416 µs (-1.0%)
profiling 18.711 ms [18.523 ms, 18.899 ms] 707.448 µs (3.9%)
tracing 17.779 ms [17.605 ms, 17.953 ms] -224.191 µs (-1.2%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.179 ms) : 1167, 1190
.   : milestone, 1179,
iast (3.195 ms) : 3149, 3240
.   : milestone, 3195,
iast_FULL (5.822 ms) : 5763, 5882
.   : milestone, 5822,
iast_GLOBAL (3.444 ms) : 3389, 3499
.   : milestone, 3444,
profiling (2.136 ms) : 2117, 2156
.   : milestone, 2136,
tracing (1.828 ms) : 1812, 1844
.   : milestone, 1828,
section candidate
no_agent (1.183 ms) : 1172, 1195
.   : milestone, 1183,
iast (3.272 ms) : 3226, 3318
.   : milestone, 3272,
iast_FULL (5.954 ms) : 5894, 6014
.   : milestone, 5954,
iast_GLOBAL (3.496 ms) : 3443, 3549
.   : milestone, 3496,
profiling (2.128 ms) : 2108, 2148
.   : milestone, 2128,
tracing (1.751 ms) : 1737, 1765
.   : milestone, 1751,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.179 ms [1.167 ms, 1.19 ms] -
iast 3.195 ms [3.149 ms, 3.24 ms] 2.016 ms (171.0%)
iast_FULL 5.822 ms [5.763 ms, 5.882 ms] 4.644 ms (394.0%)
iast_GLOBAL 3.444 ms [3.389 ms, 3.499 ms] 2.265 ms (192.2%)
profiling 2.136 ms [2.117 ms, 2.156 ms] 957.831 µs (81.3%)
tracing 1.828 ms [1.812 ms, 1.844 ms] 649.426 µs (55.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.183 ms [1.172 ms, 1.195 ms] -
iast 3.272 ms [3.226 ms, 3.318 ms] 2.089 ms (176.5%)
iast_FULL 5.954 ms [5.894 ms, 6.014 ms] 4.77 ms (403.1%)
iast_GLOBAL 3.496 ms [3.443 ms, 3.549 ms] 2.313 ms (195.4%)
profiling 2.128 ms [2.108 ms, 2.148 ms] 944.72 µs (79.8%)
tracing 1.751 ms [1.737 ms, 1.765 ms] 567.64 µs (48.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master sarahchen6/g2j-components
git_commit_date 1772641975 1772645797
git_commit_sha 77900be 5661257
release_version 1.61.0-SNAPSHOT~77900be502 1.60.0-SNAPSHOT~5661257a75
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1772647797 1772647797
ci_job_id 1476036429 1476036429
ci_pipeline_id 100384283 100384283
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-oqrvubln 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-oqrvubln 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.014 s) : 15014000, 15014000
.   : milestone, 15014000,
appsec (15.07 s) : 15070000, 15070000
.   : milestone, 15070000,
iast (17.953 s) : 17953000, 17953000
.   : milestone, 17953000,
iast_GLOBAL (17.738 s) : 17738000, 17738000
.   : milestone, 17738000,
profiling (14.825 s) : 14825000, 14825000
.   : milestone, 14825000,
tracing (15.082 s) : 15082000, 15082000
.   : milestone, 15082000,
section candidate
no_agent (14.78 s) : 14780000, 14780000
.   : milestone, 14780000,
appsec (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
iast (18.136 s) : 18136000, 18136000
.   : milestone, 18136000,
iast_GLOBAL (17.709 s) : 17709000, 17709000
.   : milestone, 17709000,
profiling (14.733 s) : 14733000, 14733000
.   : milestone, 14733000,
tracing (15.375 s) : 15375000, 15375000
.   : milestone, 15375000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.014 s [15.014 s, 15.014 s] -
appsec 15.07 s [15.07 s, 15.07 s] 56.0 ms (0.4%)
iast 17.953 s [17.953 s, 17.953 s] 2.939 s (19.6%)
iast_GLOBAL 17.738 s [17.738 s, 17.738 s] 2.724 s (18.1%)
profiling 14.825 s [14.825 s, 14.825 s] -189.0 ms (-1.3%)
tracing 15.082 s [15.082 s, 15.082 s] 68.0 ms (0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.78 s [14.78 s, 14.78 s] -
appsec 15.019 s [15.019 s, 15.019 s] 239.0 ms (1.6%)
iast 18.136 s [18.136 s, 18.136 s] 3.356 s (22.7%)
iast_GLOBAL 17.709 s [17.709 s, 17.709 s] 2.929 s (19.8%)
profiling 14.733 s [14.733 s, 14.733 s] -47.0 ms (-0.3%)
tracing 15.375 s [15.375 s, 15.375 s] 595.0 ms (4.0%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~5661257a75, baseline=1.61.0-SNAPSHOT~77900be502
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.524 ms) : 2468, 2580
.   : milestone, 2524,
iast (2.262 ms) : 2192, 2332
.   : milestone, 2262,
iast_GLOBAL (2.316 ms) : 2246, 2387
.   : milestone, 2316,
profiling (2.094 ms) : 2038, 2149
.   : milestone, 2094,
tracing (2.08 ms) : 2026, 2134
.   : milestone, 2080,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.535 ms) : 2479, 2590
.   : milestone, 2535,
iast (2.275 ms) : 2205, 2345
.   : milestone, 2275,
iast_GLOBAL (2.299 ms) : 2229, 2369
.   : milestone, 2299,
profiling (2.102 ms) : 2045, 2159
.   : milestone, 2102,
tracing (2.066 ms) : 2012, 2119
.   : milestone, 2066,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.524 ms [2.468 ms, 2.58 ms] 1.051 ms (71.3%)
iast 2.262 ms [2.192 ms, 2.332 ms] 788.788 µs (53.5%)
iast_GLOBAL 2.316 ms [2.246 ms, 2.387 ms] 842.977 µs (57.2%)
profiling 2.094 ms [2.038 ms, 2.149 ms] 620.529 µs (42.1%)
tracing 2.08 ms [2.026 ms, 2.134 ms] 606.963 µs (41.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.535 ms [2.479 ms, 2.59 ms] 1.061 ms (72.0%)
iast 2.275 ms [2.205 ms, 2.345 ms] 801.011 µs (54.4%)
iast_GLOBAL 2.299 ms [2.229 ms, 2.369 ms] 825.132 µs (56.0%)
profiling 2.102 ms [2.045 ms, 2.159 ms] 628.268 µs (42.6%)
tracing 2.066 ms [2.012 ms, 2.119 ms] 591.858 µs (40.2%)

@sarahchen6 sarahchen6 marked this pull request as ready for review March 3, 2026 20:20
@sarahchen6 sarahchen6 requested review from a team as code owners March 3, 2026 20:20
@sarahchen6 sarahchen6 requested review from dougqh and removed request for a team March 3, 2026 20:20
AlexeyKuznetsov-DD
AlexeyKuznetsov-DD approved these changes Mar 3, 2026
View reviewed changes
PerfectSlayer
PerfectSlayer reviewed Mar 4, 2026
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Thanks for update the JSON component and running the skill on a small example easy to review! 👍

❔ question: ‏Did you check there was no hascode() in parametrized test names? If there are, better use:

  1. test case description as first value of the arguments,
  2. test case index otherwise

🎯 suggestion: ‏About the various comments, feel free to add them to the skills too so it will get better with time 🙏

@sarahchen6
Copy link
Contributor Author

sarahchen6 commented Mar 4, 2026 •
edited
Loading

❔ question: ‏Did you check there was no hascode() in parametrized test names?

Ah good point. Addressed in ecf9f02 (and added to Claude skill :))

@sarahchen6
Copy link
Contributor Author

sarahchen6 commented Mar 4, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link

gh-worker-devflow-routing-ef8351 bot commented Mar 4, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-04 18:51:27 UTC ℹ️ Start processing command /merge

2026-03-04 18:51:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).

2026-03-04 19:54:11 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 2f04ccb into master Mar 4, 2026
739 of 742 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the sarahchen6/g2j-components branch March 4, 2026 19:54
@github-actions github-actions bot added this to the 1.61.0 milestone Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@jpbempel jpbempel jpbempel left review comments

@dougqh dougqh dougqh approved these changes

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD AlexeyKuznetsov-DD approved these changes

Assignees

No one assigned

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.61.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sarahchen6 @dougqh @PerfectSlayer @jpbempel @AlexeyKuznetsov-DD