Conversation
address comments from #10462
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 68 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059029
Total [baseline] (8.843 s) : 0, 8842859
Agent [candidate] (1.058 s) : 0, 1058153
Total [candidate] (8.872 s) : 0, 8872382
section iast
Agent [baseline] (1.223 s) : 0, 1223235
Total [baseline] (9.564 s) : 0, 9564024
Agent [candidate] (1.232 s) : 0, 1231685
Total [candidate] (9.568 s) : 0, 9567976
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (629.178 ms) : 0, 629178
BytebuddyAgent [candidate] (628.419 ms) : 0, 628419
AgentMeter [baseline] (29.269 ms) : 0, 29269
AgentMeter [candidate] (29.031 ms) : 0, 29031
GlobalTracer [baseline] (257.266 ms) : 0, 257266
GlobalTracer [candidate] (256.952 ms) : 0, 256952
AppSec [baseline] (31.5 ms) : 0, 31500
AppSec [candidate] (31.44 ms) : 0, 31440
Debugger [baseline] (58.776 ms) : 0, 58776
Debugger [candidate] (58.57 ms) : 0, 58570
Remote Config [baseline] (594.378 µs) : 0, 594
Remote Config [candidate] (591.304 µs) : 0, 591
Telemetry [baseline] (8.726 ms) : 0, 8726
Telemetry [candidate] (8.665 ms) : 0, 8665
Flare Poller [baseline] (6.375 ms) : 0, 6375
Flare Poller [candidate] (7.167 ms) : 0, 7167
section iast
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (794.029 ms) : 0, 794029
BytebuddyAgent [candidate] (799.098 ms) : 0, 799098
AgentMeter [baseline] (11.25 ms) : 0, 11250
AgentMeter [candidate] (11.386 ms) : 0, 11386
GlobalTracer [baseline] (246.928 ms) : 0, 246928
GlobalTracer [candidate] (248.71 ms) : 0, 248710
IAST [baseline] (25.078 ms) : 0, 25078
IAST [candidate] (25.299 ms) : 0, 25299
AppSec [baseline] (26.263 ms) : 0, 26263
AppSec [candidate] (26.511 ms) : 0, 26511
Debugger [baseline] (62.235 ms) : 0, 62235
Debugger [candidate] (62.978 ms) : 0, 62978
Remote Config [baseline] (529.869 µs) : 0, 530
Remote Config [candidate] (536.224 µs) : 0, 536
Telemetry [baseline] (14.85 ms) : 0, 14850
Telemetry [candidate] (14.948 ms) : 0, 14948
Flare Poller [baseline] (4.856 ms) : 0, 4856
Flare Poller [candidate] (4.889 ms) : 0, 4889
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1059509
Total [baseline] (11.095 s) : 0, 11094815
Agent [candidate] (1.064 s) : 0, 1064272
Total [candidate] (11.03 s) : 0, 11029838
section appsec
Agent [baseline] (1.242 s) : 0, 1241956
Total [baseline] (11.177 s) : 0, 11176865
Agent [candidate] (1.25 s) : 0, 1249897
Total [candidate] (11.28 s) : 0, 11279507
section iast
Agent [baseline] (1.228 s) : 0, 1227830
Total [baseline] (11.307 s) : 0, 11306642
Agent [candidate] (1.227 s) : 0, 1227129
Total [candidate] (11.36 s) : 0, 11360008
section profiling
Agent [baseline] (1.182 s) : 0, 1181601
Total [baseline] (11.057 s) : 0, 11057432
Agent [candidate] (1.182 s) : 0, 1181782
Total [candidate] (11.005 s) : 0, 11005346
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (628.373 ms) : 0, 628373
BytebuddyAgent [candidate] (631.769 ms) : 0, 631769
AgentMeter [baseline] (29.128 ms) : 0, 29128
AgentMeter [candidate] (29.427 ms) : 0, 29427
GlobalTracer [baseline] (256.782 ms) : 0, 256782
GlobalTracer [candidate] (258.077 ms) : 0, 258077
AppSec [baseline] (31.367 ms) : 0, 31367
AppSec [candidate] (31.6 ms) : 0, 31600
Debugger [baseline] (59.459 ms) : 0, 59459
Debugger [candidate] (59.616 ms) : 0, 59616
Remote Config [baseline] (588.139 µs) : 0, 588
Remote Config [candidate] (590.471 µs) : 0, 590
Telemetry [baseline] (8.62 ms) : 0, 8620
Telemetry [candidate] (8.646 ms) : 0, 8646
Flare Poller [baseline] (7.925 ms) : 0, 7925
Flare Poller [candidate] (7.131 ms) : 0, 7131
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (656.075 ms) : 0, 656075
BytebuddyAgent [candidate] (659.341 ms) : 0, 659341
AgentMeter [baseline] (11.953 ms) : 0, 11953
AgentMeter [candidate] (12.133 ms) : 0, 12133
GlobalTracer [baseline] (257.379 ms) : 0, 257379
GlobalTracer [candidate] (259.696 ms) : 0, 259696
IAST [baseline] (23.872 ms) : 0, 23872
IAST [candidate] (24.17 ms) : 0, 24170
AppSec [baseline] (177.077 ms) : 0, 177077
AppSec [candidate] (177.932 ms) : 0, 177932
Debugger [baseline] (65.142 ms) : 0, 65142
Debugger [candidate] (65.804 ms) : 0, 65804
Remote Config [baseline] (565.735 µs) : 0, 566
Remote Config [candidate] (578.885 µs) : 0, 579
Telemetry [baseline] (8.948 ms) : 0, 8948
Telemetry [candidate] (9.053 ms) : 0, 9053
Flare Poller [baseline] (3.53 ms) : 0, 3530
Flare Poller [candidate] (3.638 ms) : 0, 3638
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (796.602 ms) : 0, 796602
BytebuddyAgent [candidate] (795.771 ms) : 0, 795771
AgentMeter [baseline] (11.333 ms) : 0, 11333
AgentMeter [candidate] (11.343 ms) : 0, 11343
GlobalTracer [baseline] (247.388 ms) : 0, 247388
GlobalTracer [candidate] (247.497 ms) : 0, 247497
IAST [baseline] (25.195 ms) : 0, 25195
IAST [candidate] (25.088 ms) : 0, 25088
AppSec [baseline] (26.34 ms) : 0, 26340
AppSec [candidate] (26.282 ms) : 0, 26282
Debugger [baseline] (63.351 ms) : 0, 63351
Debugger [candidate] (63.536 ms) : 0, 63536
Remote Config [baseline] (531.32 µs) : 0, 531
Remote Config [candidate] (529.096 µs) : 0, 529
Telemetry [baseline] (14.952 ms) : 0, 14952
Telemetry [candidate] (14.973 ms) : 0, 14973
Flare Poller [baseline] (4.933 ms) : 0, 4933
Flare Poller [candidate] (4.865 ms) : 0, 4865
section profiling
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.174 ms) : 0, 1174
BytebuddyAgent [baseline] (682.574 ms) : 0, 682574
BytebuddyAgent [candidate] (683.637 ms) : 0, 683637
AgentMeter [baseline] (8.611 ms) : 0, 8611
AgentMeter [candidate] (8.546 ms) : 0, 8546
GlobalTracer [baseline] (215.702 ms) : 0, 215702
GlobalTracer [candidate] (215.035 ms) : 0, 215035
AppSec [baseline] (31.815 ms) : 0, 31815
AppSec [candidate] (31.834 ms) : 0, 31834
Debugger [baseline] (64.122 ms) : 0, 64122
Debugger [candidate] (64.17 ms) : 0, 64170
Remote Config [baseline] (587.676 µs) : 0, 588
Remote Config [candidate] (576.288 µs) : 0, 576
Telemetry [baseline] (8.889 ms) : 0, 8889
Telemetry [candidate] (9.01 ms) : 0, 9010
Flare Poller [baseline] (3.477 ms) : 0, 3477
Flare Poller [candidate] (3.484 ms) : 0, 3484
ProfilingAgent [baseline] (93.814 ms) : 0, 93814
ProfilingAgent [candidate] (93.489 ms) : 0, 93489
Profiling [baseline] (94.376 ms) : 0, 94376
Profiling [candidate] (94.056 ms) : 0, 94056
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (1.2 ms) : 1188, 1212
. : milestone, 1200,
iast (3.246 ms) : 3202, 3290
. : milestone, 3246,
iast_FULL (5.754 ms) : 5696, 5813
. : milestone, 5754,
iast_GLOBAL (3.67 ms) : 3610, 3729
. : milestone, 3670,
profiling (2.155 ms) : 2136, 2175
. : milestone, 2155,
tracing (1.779 ms) : 1765, 1794
. : milestone, 1779,
section candidate
no_agent (1.156 ms) : 1145, 1167
. : milestone, 1156,
iast (3.069 ms) : 3026, 3111
. : milestone, 3069,
iast_FULL (5.627 ms) : 5572, 5682
. : milestone, 5627,
iast_GLOBAL (3.558 ms) : 3501, 3616
. : milestone, 3558,
profiling (2.21 ms) : 2187, 2233
. : milestone, 2210,
tracing (1.821 ms) : 1805, 1836
. : milestone, 1821,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (17.295 ms) : 17119, 17470
. : milestone, 17295,
appsec (19.785 ms) : 19579, 19992
. : milestone, 19785,
code_origins (18.536 ms) : 18354, 18718
. : milestone, 18536,
iast (17.894 ms) : 17716, 18072
. : milestone, 17894,
profiling (18.748 ms) : 18560, 18936
. : milestone, 18748,
tracing (17.614 ms) : 17440, 17788
. : milestone, 17614,
section candidate
no_agent (19.252 ms) : 19051, 19454
. : milestone, 19252,
appsec (19.378 ms) : 19178, 19577
. : milestone, 19378,
code_origins (18.121 ms) : 17942, 18301
. : milestone, 18121,
iast (17.639 ms) : 17464, 17813
. : milestone, 17639,
profiling (18.547 ms) : 18360, 18734
. : milestone, 18547,
tracing (17.975 ms) : 17796, 18154
. : milestone, 17975,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 1 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.78 ms) : 3561, 4000
. : milestone, 3780,
iast (2.243 ms) : 2174, 2312
. : milestone, 2243,
iast_GLOBAL (2.284 ms) : 2215, 2353
. : milestone, 2284,
profiling (2.497 ms) : 2331, 2664
. : milestone, 2497,
tracing (2.057 ms) : 2003, 2110
. : milestone, 2057,
section candidate
no_agent (1.47 ms) : 1458, 1481
. : milestone, 1470,
appsec (2.556 ms) : 2498, 2614
. : milestone, 2556,
iast (2.241 ms) : 2172, 2310
. : milestone, 2241,
iast_GLOBAL (2.284 ms) : 2215, 2353
. : milestone, 2284,
profiling (2.073 ms) : 2019, 2128
. : milestone, 2073,
tracing (2.042 ms) : 1989, 2095
. : milestone, 2042,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~091b9b83a5, baseline=1.61.0-SNAPSHOT~cf6146b8f2
dateFormat X
axisFormat %s
section baseline
no_agent (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
appsec (14.928 s) : 14928000, 14928000
. : milestone, 14928000,
iast (18.201 s) : 18201000, 18201000
. : milestone, 18201000,
iast_GLOBAL (17.803 s) : 17803000, 17803000
. : milestone, 17803000,
profiling (15.437 s) : 15437000, 15437000
. : milestone, 15437000,
tracing (15.277 s) : 15277000, 15277000
. : milestone, 15277000,
section candidate
no_agent (15.591 s) : 15591000, 15591000
. : milestone, 15591000,
appsec (14.935 s) : 14935000, 14935000
. : milestone, 14935000,
iast (18.36 s) : 18360000, 18360000
. : milestone, 18360000,
iast_GLOBAL (17.566 s) : 17566000, 17566000
. : milestone, 17566000,
profiling (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
tracing (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 100301153 took longer than expected. The current limit for the base branch 'master' is 120 minutes. Possible reasons:
|
What Does This Do
address comments from #10462
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.