-
Notifications
You must be signed in to change notification settings - Fork 467
perf(profiling): use echion with memcpy #15030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
7fab4f9 to
d7a59f4
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 241 ± 3 ms. The average import time from base is: 244 ± 4 ms. The import time difference between this PR and base is: -3.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate kowalski/profiling-use-echion-with-memcpy (93f6aa2) with baseline main (13e4d43) 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.431ms (SLO: <22.300ms -8.4%) vs baseline: ~same Memory: ✅ 66.041MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.341ms (SLO: <1.450ms -7.5%) vs baseline: ~same Memory: ✅ 64.134MB (SLO: <67.000MB -4.3%) vs baseline: +4.7% ✅ iastTime: ✅ 20.439ms (SLO: <22.250ms -8.1%) vs baseline: -0.7% Memory: ✅ 65.982MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.484ms (SLO: <16.550ms -6.4%) vs baseline: +0.5% Memory: ✅ 53.768MB (SLO: <54.500MB 🟡 -1.3%) vs baseline: +4.5% ✅ resource-renamingTime: ✅ 20.515ms (SLO: <21.750ms -5.7%) vs baseline: -0.2% Memory: ✅ 66.060MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.375ms (SLO: <28.200ms 📉 -10.0%) vs baseline: -0.4% Memory: ✅ 67.063MB (SLO: <69.500MB -3.5%) vs baseline: +4.9% ✅ tracerTime: ✅ 20.441ms (SLO: <21.750ms -6.0%) vs baseline: ~same Memory: ✅ 66.040MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.720ms (SLO: <23.500ms -3.3%) vs baseline: +0.3% Memory: ✅ 67.305MB (SLO: <68.000MB 🟡 -1.0%) vs baseline: +4.6% ✅ tracer-dont-create-db-spansTime: ✅ 19.320ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 66.041MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-minimalTime: ✅ 16.553ms (SLO: <17.500ms -5.4%) vs baseline: -0.4% Memory: ✅ 65.687MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.3% ✅ tracer-nativeTime: ✅ 20.401ms (SLO: <21.750ms -6.2%) vs baseline: ~same Memory: ✅ 71.471MB (SLO: <72.500MB 🟡 -1.4%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.486ms (SLO: <19.650ms -5.9%) vs baseline: +0.2% Memory: ✅ 65.972MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.849ms (SLO: <20.100ms -6.2%) vs baseline: +0.5% Memory: ✅ 65.677MB (SLO: <67.000MB 🟡 -2.0%) vs baseline: +4.5% ✅ tracer-no-middlewareTime: ✅ 20.148ms (SLO: <21.500ms -6.3%) vs baseline: +0.1% Memory: ✅ 66.024MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.254ms (SLO: <22.000ms -7.9%) vs baseline: -0.5% Memory: ✅ 65.992MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.046ms (SLO: <19.850ms -9.1%) vs baseline: -0.2% Memory: ✅ 65.726MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.6% ✅ errortracking-enabled-userTime: ✅ 18.081ms (SLO: <19.400ms -6.8%) vs baseline: ~same Memory: ✅ 65.667MB (SLO: <66.500MB 🟡 -1.3%) vs baseline: +4.3% ✅ tracer-enabledTime: ✅ 17.974ms (SLO: <19.450ms -7.6%) vs baseline: -0.2% Memory: ✅ 65.677MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.4% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.601ms (SLO: <4.750ms -3.1%) vs baseline: +0.4% Memory: ✅ 62.312MB (SLO: <65.000MB -4.1%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.630ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: -0.3% Memory: ✅ 62.271MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.583ms (SLO: <4.750ms -3.5%) vs baseline: +0.1% Memory: ✅ 62.224MB (SLO: <65.000MB -4.3%) vs baseline: +4.6% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.3%) vs baseline: -0.4% Memory: ✅ 45.140MB (SLO: <47.000MB -4.0%) vs baseline: +4.5% ✅ iast-getTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 42.067MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.5% ✅ profilerTime: ✅ 1.910ms (SLO: <2.100ms -9.1%) vs baseline: -0.2% Memory: ✅ 46.205MB (SLO: <47.000MB 🟡 -1.7%) vs baseline: +4.5% ✅ resource-renamingTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: +0.2% Memory: ✅ 52.614MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracerTime: ✅ 3.345ms (SLO: <3.650ms -8.3%) vs baseline: -0.4% Memory: ✅ 52.538MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.5% ✅ tracer-nativeTime: ✅ 3.349ms (SLO: <3.650ms -8.2%) vs baseline: -0.2% Memory: ✅ 58.039MB (SLO: <60.000MB -3.3%) vs baseline: +4.6% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.966ms (SLO: <4.200ms -5.6%) vs baseline: -0.4% Memory: ✅ 62.207MB (SLO: <66.000MB -5.7%) vs baseline: +4.6% ✅ iast-enabledTime: ✅ 2.439ms (SLO: <2.800ms 📉 -12.9%) vs baseline: -0.3% Memory: ✅ 59.022MB (SLO: <60.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-enabledTime: ✅ 2.059ms (SLO: <2.250ms -8.5%) vs baseline: -0.1% Memory: ✅ 52.475MB (SLO: <54.500MB -3.7%) vs baseline: +4.5%
|
d7a59f4 to
d1af0c8
Compare
d1af0c8 to
c1433c1
Compare
c1433c1 to
93f6aa2
Compare
Description
This PR updates
dd-trace-pyto use the latest version of Echion.The main change is the new "fast memory copy" feature that significantly reduces the time it takes to copy memory from the Python process by using a SEGV-guarded
memcpy(no system call involved) instead ofprocess_vm_readv.echion/perf: use memcpy instead of process_vm_readv
This feature is experimental and we intend to test it within Datadog before making it widely available (and eventually, hopefully making it the default/only available option).
Currently,
ddtracecannot enable/disable the feature itself; the Echion library relies on theECHION_USE_FAST_COPY_MEMORYenvironment variable on startup to enable/disable it.Testing
The change has been tested on benchmarks, in the CI and inside the reliability environment. No crashes are happening.