-
Notifications
You must be signed in to change notification settings - Fork 469
chore(llmobs): remove submit_evaluation_for method #15045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llmobs): remove submit_evaluation_for method #15045
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 243 ± 4 ms. The average import time from base is: 246 ± 5 ms. The import time difference between this PR and base is: -3.2 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate nicole-cybul/remove-submit-evaluation-for (833e25c) with baseline 4.0-breaking-changes (9fe33ac) 📈 Performance Regressions (1 suite)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.241µs (SLO: <10.000µs 📉 -57.6%) vs baseline: -0.4% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.096µs (SLO: <10.000µs 📉 -89.0%) vs baseline: +0.6% Memory: ✅ 37.532MB (SLO: <39.000MB -3.8%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.140µs (SLO: <10.000µs 📉 -38.6%) vs baseline: -0.5% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.1% ✅ ospathjoin_noaspectTime: ✅ 2.314µs (SLO: <10.000µs 📉 -76.9%) vs baseline: +1.2% Memory: ✅ 37.591MB (SLO: <39.000MB -3.6%) vs baseline: +5.2% ✅ ospathnormcase_aspectTime: ✅ 3.502µs (SLO: <10.000µs 📉 -65.0%) vs baseline: -0.5% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.0% ✅ ospathnormcase_noaspectTime: ✅ 0.570µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -0.4% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 5.957µs (SLO: <10.000µs 📉 -40.4%) vs baseline: 📈 +23.1% Memory: ✅ 37.493MB (SLO: <39.000MB -3.9%) vs baseline: +4.7% ✅ ospathsplit_noaspectTime: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.5% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.702µs (SLO: <10.000µs 📉 -63.0%) vs baseline: ~same Memory: ✅ 37.454MB (SLO: <39.000MB -4.0%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.703µs (SLO: <10.000µs 📉 -93.0%) vs baseline: -0.5% Memory: ✅ 37.572MB (SLO: <39.000MB -3.7%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.561µs (SLO: <10.000µs 📉 -54.4%) vs baseline: -0.3% Memory: ✅ 37.473MB (SLO: <39.000MB -3.9%) vs baseline: +4.6% ✅ ospathsplitext_noaspectTime: ✅ 1.390µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.7% Memory: ✅ 37.552MB (SLO: <39.000MB -3.7%) vs baseline: +5.0% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.406ms (SLO: <22.300ms -8.5%) vs baseline: -0.4% Memory: ✅ 66.023MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.334ms (SLO: <1.450ms -8.0%) vs baseline: -0.6% Memory: ✅ 64.114MB (SLO: <67.000MB -4.3%) vs baseline: +4.7% ✅ iastTime: ✅ 20.398ms (SLO: <22.250ms -8.3%) vs baseline: -0.3% Memory: ✅ 65.970MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.665ms (SLO: <16.550ms -5.3%) vs baseline: +0.5% Memory: ✅ 53.878MB (SLO: <54.500MB 🟡 -1.1%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 20.460ms (SLO: <21.750ms -5.9%) vs baseline: -0.1% Memory: ✅ 65.972MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.555ms (SLO: <28.200ms -9.4%) vs baseline: +0.6% Memory: ✅ 67.027MB (SLO: <69.500MB -3.6%) vs baseline: +5.0% ✅ tracerTime: ✅ 20.402ms (SLO: <21.750ms -6.2%) vs baseline: -0.3% Memory: ✅ 66.014MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 22.622ms (SLO: <23.500ms -3.7%) vs baseline: -0.4% Memory: ✅ 67.539MB (SLO: <68.000MB 🟡 -0.7%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.222ms (SLO: <21.500ms 📉 -10.6%) vs baseline: -0.4% Memory: ✅ 65.974MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.627ms (SLO: <17.500ms -5.0%) vs baseline: ~same Memory: ✅ 65.998MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.436ms (SLO: <21.750ms -6.0%) vs baseline: +0.2% Memory: ✅ 71.526MB (SLO: <72.500MB 🟡 -1.3%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.448ms (SLO: <19.650ms -6.1%) vs baseline: +0.3% Memory: ✅ 65.975MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.696ms (SLO: <20.100ms -7.0%) vs baseline: -0.2% Memory: ✅ 65.944MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.111ms (SLO: <21.500ms -6.5%) vs baseline: +0.1% Memory: ✅ 65.869MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-no-templatesTime: ✅ 20.254ms (SLO: <22.000ms -7.9%) vs baseline: ~same Memory: ✅ 65.973MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.026ms (SLO: <19.850ms -9.2%) vs baseline: ~same Memory: ✅ 65.980MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.052ms (SLO: <19.400ms -6.9%) vs baseline: ~same Memory: ✅ 65.911MB (SLO: <66.500MB 🟡 -0.9%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.064ms (SLO: <19.450ms -7.1%) vs baseline: +0.2% Memory: ✅ 65.713MB (SLO: <66.500MB 🟡 -1.2%) vs baseline: +4.9% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.076ms (SLO: <2.300ms -9.7%) vs baseline: +1.1% Memory: ✅ 52.514MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.8% ✅ errortracking-enabled-userTime: ✅ 2.079ms (SLO: <2.250ms -7.6%) vs baseline: +0.7% Memory: ✅ 52.396MB (SLO: <53.500MB -2.1%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.081ms (SLO: <2.300ms -9.5%) vs baseline: +1.1% Memory: ✅ 52.534MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +5.1% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.592ms (SLO: <4.750ms -3.3%) vs baseline: -0.4% Memory: ✅ 62.359MB (SLO: <65.000MB -4.1%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.619ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: -0.2% Memory: ✅ 61.967MB (SLO: <65.000MB -4.7%) vs baseline: +4.5% ✅ appsec-telemetryTime: ✅ 4.581ms (SLO: <4.750ms -3.6%) vs baseline: +0.1% Memory: ✅ 62.390MB (SLO: <65.000MB -4.0%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.132MB (SLO: <47.000MB -4.0%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.4% Memory: ✅ 42.141MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.908ms (SLO: <2.100ms -9.2%) vs baseline: -0.2% Memory: ✅ 46.368MB (SLO: <47.000MB 🟡 -1.3%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: -0.1% Memory: ✅ 52.628MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.0% ✅ tracerTime: ✅ 3.345ms (SLO: <3.650ms -8.4%) vs baseline: -0.2% Memory: ✅ 52.623MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.346ms (SLO: <3.650ms -8.3%) vs baseline: +0.1% Memory: ✅ 58.098MB (SLO: <60.000MB -3.2%) vs baseline: +4.7% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.951ms (SLO: <4.200ms -5.9%) vs baseline: -0.1% Memory: ✅ 62.207MB (SLO: <66.000MB -5.7%) vs baseline: +4.7% ✅ iast-enabledTime: ✅ 2.430ms (SLO: <2.800ms 📉 -13.2%) vs baseline: -0.4% Memory: ✅ 59.120MB (SLO: <60.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 2.057ms (SLO: <2.250ms -8.6%) vs baseline: +0.4% Memory: ✅ 52.593MB (SLO: <54.500MB -3.5%) vs baseline: +5.3%
|
Yun-Kim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small release note suggestion but otherwise LGTM once that's addressed 😎
Description
MLOB-4217
Removes
submit_evaluation_formethod in favor ofsubmit_evaluationwhich should be released in ddtrace 4.0.Testing
Risks
Additional Notes