fix(llmobs): change default model_provider and model_name to unknown for google integrations#17546
Open
fix(llmobs): change default model_provider and model_name to unknown for google integrations#17546
Conversation
… doesn't match any known provider prefix
This comment has been minimized.
This comment has been minimized.
Codeowners resolved as |
emmettbutler
approved these changes
Apr 15, 2026
Collaborator
emmettbutler
left a comment
emmettbutler
left a comment
There was a problem hiding this comment.
release note seems fine
Yun-Kim
reviewed
Apr 15, 2026
Co-authored-by: Yun Kim <35776586+Yun-Kim@users.noreply.github.com>
Yun-Kim
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the provider and model names are empty or cannot be extracted, change the default "model_provider" and "model_name" from "custom" to "unknown" for Google integrations (GenAI, vertexai, google adk)
This is to ensure the behavior is consistent amount other interrogations (previous change to openai/anthropic/litellm).
MLOB-6716
Testing
Manually testing locally with these case:
Risks
Additional Notes