Conversation
Performance SLOsComparing candidate gnufede/test-visibility-dogfooding (13c0f8d) with baseline main (a9cc850) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.739µs (SLO: <130.000µs 📉 -20.2%) vs baseline: +1.8% Memory: ✅ 43.898MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ add_inplace_aspectTime: ✅ 100.278µs (SLO: <130.000µs 📉 -22.9%) vs baseline: -2.2% Memory: ✅ 44.007MB (SLO: <46.000MB -4.3%) vs baseline: +5.4% ✅ add_inplace_noaspectTime: ✅ 28.197µs (SLO: <40.000µs 📉 -29.5%) vs baseline: -0.1% Memory: ✅ 43.914MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 49.834µs (SLO: <70.000µs 📉 -28.8%) vs baseline: +1.3% Memory: ✅ 43.862MB (SLO: <46.000MB -4.6%) vs baseline: +5.1% ✅ bytearray_aspectTime: ✅ 250.666µs (SLO: <400.000µs 📉 -37.3%) vs baseline: -2.3% Memory: ✅ 43.776MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ bytearray_extend_aspectTime: ✅ 646.094µs (SLO: <800.000µs 📉 -19.2%) vs baseline: +1.5% Memory: ✅ 43.843MB (SLO: <46.000MB -4.7%) vs baseline: +4.3% ✅ bytearray_extend_noaspectTime: ✅ 267.146µs (SLO: <400.000µs 📉 -33.2%) vs baseline: +1.5% Memory: ✅ 43.838MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ bytearray_noaspectTime: ✅ 141.606µs (SLO: <300.000µs 📉 -52.8%) vs baseline: ~same Memory: ✅ 43.862MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ bytes_aspectTime: ✅ 219.780µs (SLO: <300.000µs 📉 -26.7%) vs baseline: -1.1% Memory: ✅ 43.789MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 133.498µs (SLO: <200.000µs 📉 -33.3%) vs baseline: -1.0% Memory: ✅ 43.872MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ bytesio_aspectTime: ✅ 3.782ms (SLO: <5.000ms 📉 -24.4%) vs baseline: -0.4% Memory: ✅ 43.947MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ bytesio_noaspectTime: ✅ 315.415µs (SLO: <420.000µs 📉 -24.9%) vs baseline: -0.5% Memory: ✅ 43.953MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ capitalize_aspectTime: ✅ 87.944µs (SLO: <300.000µs 📉 -70.7%) vs baseline: -1.1% Memory: ✅ 43.917MB (SLO: <46.000MB -4.5%) vs baseline: +5.4% ✅ capitalize_noaspectTime: ✅ 246.167µs (SLO: <300.000µs 📉 -17.9%) vs baseline: -3.0% Memory: ✅ 43.801MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ casefold_aspectTime: ✅ 92.076µs (SLO: <500.000µs 📉 -81.6%) vs baseline: +3.8% Memory: ✅ 43.880MB (SLO: <46.000MB -4.6%) vs baseline: +5.2% ✅ casefold_noaspectTime: ✅ 306.004µs (SLO: <500.000µs 📉 -38.8%) vs baseline: -2.4% Memory: ✅ 43.910MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 86.642µs (SLO: <100.000µs 📉 -13.4%) vs baseline: +0.2% Memory: ✅ 43.813MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 154.811µs (SLO: <210.000µs 📉 -26.3%) vs baseline: -1.5% Memory: ✅ 43.829MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ encode_aspectTime: ✅ 84.757µs (SLO: <200.000µs 📉 -57.6%) vs baseline: +0.3% Memory: ✅ 43.932MB (SLO: <46.000MB -4.5%) vs baseline: +5.2% ✅ encode_noaspectTime: ✅ 143.587µs (SLO: <200.000µs 📉 -28.2%) vs baseline: +0.5% Memory: ✅ 43.900MB (SLO: <46.000MB -4.6%) vs baseline: +5.2% ✅ format_aspectTime: ✅ 14.556ms (SLO: <19.200ms 📉 -24.2%) vs baseline: -0.1% Memory: ✅ 43.922MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 16.351ms (SLO: <21.500ms 📉 -24.0%) vs baseline: +0.2% Memory: ✅ 43.968MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ format_map_noaspectTime: ✅ 368.853µs (SLO: <500.000µs 📉 -26.2%) vs baseline: -2.3% Memory: ✅ 43.901MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 310.155µs (SLO: <500.000µs 📉 -38.0%) vs baseline: +0.2% Memory: ✅ 43.954MB (SLO: <46.000MB -4.4%) vs baseline: +5.2% ✅ index_aspectTime: ✅ 123.125µs (SLO: <300.000µs 📉 -59.0%) vs baseline: +1.4% Memory: ✅ 43.870MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ index_noaspectTime: ✅ 41.182µs (SLO: <300.000µs 📉 -86.3%) vs baseline: +0.8% Memory: ✅ 43.918MB (SLO: <46.000MB -4.5%) vs baseline: +5.3% ✅ join_aspectTime: ✅ 209.040µs (SLO: <300.000µs 📉 -30.3%) vs baseline: -1.2% Memory: ✅ 43.802MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 141.344µs (SLO: <300.000µs 📉 -52.9%) vs baseline: -1.7% Memory: ✅ 43.890MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ ljust_aspectTime: ✅ 495.978µs (SLO: <700.000µs 📉 -29.1%) vs baseline: -2.1% Memory: ✅ 43.872MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ ljust_noaspectTime: ✅ 256.005µs (SLO: <300.000µs 📉 -14.7%) vs baseline: -4.6% Memory: ✅ 43.878MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 297.468µs (SLO: <500.000µs 📉 -40.5%) vs baseline: +0.4% Memory: ✅ 43.769MB (SLO: <46.000MB -4.9%) vs baseline: +4.5% ✅ lower_noaspectTime: ✅ 233.827µs (SLO: <300.000µs 📉 -22.1%) vs baseline: -1.3% Memory: ✅ 43.824MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ lstrip_aspectTime: ✅ 0.339ms (SLO: <3.000ms 📉 -88.7%) vs baseline: 📈 +25.4% Memory: ✅ 43.683MB (SLO: <46.000MB -5.0%) vs baseline: +4.4% ✅ lstrip_noaspectTime: ✅ 0.178ms (SLO: <3.000ms 📉 -94.1%) vs baseline: -0.8% Memory: ✅ 43.856MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 14.190ms (SLO: <18.750ms 📉 -24.3%) vs baseline: -0.2% Memory: ✅ 44.084MB (SLO: <46.000MB -4.2%) vs baseline: +5.1% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.691ms (SLO: <19.350ms 📉 -24.1%) vs baseline: -0.4% Memory: ✅ 43.938MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 14.310ms (SLO: <18.900ms 📉 -24.3%) vs baseline: -0.1% Memory: ✅ 43.937MB (SLO: <46.000MB -4.5%) vs baseline: +4.6% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.526ms (SLO: <19.150ms 📉 -24.1%) vs baseline: -0.4% Memory: ✅ 43.944MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ modulo_noaspectTime: ✅ 0.363ms (SLO: <3.000ms 📉 -87.9%) vs baseline: -1.7% Memory: ✅ 43.979MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ replace_aspectTime: ✅ 18.919ms (SLO: <24.000ms 📉 -21.2%) vs baseline: +3.3% Memory: ✅ 43.952MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ replace_noaspectTime: ✅ 289.370µs (SLO: <400.000µs 📉 -27.7%) vs baseline: +2.0% Memory: ✅ 43.786MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 324.136µs (SLO: <420.000µs 📉 -22.8%) vs baseline: +1.1% Memory: ✅ 43.974MB (SLO: <46.000MB -4.4%) vs baseline: +5.3% ✅ repr_noaspectTime: ✅ 46.540µs (SLO: <90.000µs 📉 -48.3%) vs baseline: -1.4% Memory: ✅ 43.838MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ rstrip_aspectTime: ✅ 378.902µs (SLO: <500.000µs 📉 -24.2%) vs baseline: -1.6% Memory: ✅ 43.881MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ rstrip_noaspectTime: ✅ 181.255µs (SLO: <300.000µs 📉 -39.6%) vs baseline: -1.6% Memory: ✅ 43.848MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 184.144µs (SLO: <300.000µs 📉 -38.6%) vs baseline: +1.1% Memory: ✅ 43.799MB (SLO: <46.000MB -4.8%) vs baseline: +4.7% ✅ slice_noaspectTime: ✅ 54.519µs (SLO: <90.000µs 📉 -39.4%) vs baseline: +1.2% Memory: ✅ 43.928MB (SLO: <46.000MB -4.5%) vs baseline: +5.1% ✅ stringio_aspectTime: ✅ 3.870ms (SLO: <5.000ms 📉 -22.6%) vs baseline: ~same Memory: ✅ 43.787MB (SLO: <46.000MB -4.8%) vs baseline: +4.6% ✅ stringio_noaspectTime: ✅ 346.233µs (SLO: <500.000µs 📉 -30.8%) vs baseline: +0.2% Memory: ✅ 43.825MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ strip_aspectTime: ✅ 269.132µs (SLO: <350.000µs 📉 -23.1%) vs baseline: -2.9% Memory: ✅ 43.950MB (SLO: <46.000MB -4.5%) vs baseline: +5.0% ✅ strip_noaspectTime: ✅ 178.160µs (SLO: <240.000µs 📉 -25.8%) vs baseline: +1.5% Memory: ✅ 43.873MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ swapcase_aspectTime: ✅ 330.133µs (SLO: <500.000µs 📉 -34.0%) vs baseline: -0.4% Memory: ✅ 43.839MB (SLO: <46.000MB -4.7%) vs baseline: +4.9% ✅ swapcase_noaspectTime: ✅ 268.736µs (SLO: <400.000µs 📉 -32.8%) vs baseline: -1.0% Memory: ✅ 43.921MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 319.214µs (SLO: <500.000µs 📉 -36.2%) vs baseline: -2.3% Memory: ✅ 43.787MB (SLO: <46.000MB -4.8%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 255.170µs (SLO: <400.000µs 📉 -36.2%) vs baseline: -3.0% Memory: ✅ 43.817MB (SLO: <46.000MB -4.7%) vs baseline: +4.7% ✅ translate_aspectTime: ✅ 560.298µs (SLO: <700.000µs 📉 -20.0%) vs baseline: 📈 +11.7% Memory: ✅ 43.884MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ translate_noaspectTime: ✅ 422.027µs (SLO: <500.000µs 📉 -15.6%) vs baseline: -3.2% Memory: ✅ 43.916MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 294.452µs (SLO: <500.000µs 📉 -41.1%) vs baseline: -3.5% Memory: ✅ 43.734MB (SLO: <46.000MB -4.9%) vs baseline: +4.8% ✅ upper_noaspectTime: ✅ 235.135µs (SLO: <400.000µs 📉 -41.2%) vs baseline: +1.1% Memory: ✅ 43.792MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 528.817µs (SLO: <700.000µs 📉 -24.5%) vs baseline: 📈 +25.5% Memory: ✅ 43.866MB (SLO: <46.000MB -4.6%) vs baseline: +5.6% ✅ ospathbasename_noaspectTime: ✅ 435.451µs (SLO: <700.000µs 📉 -37.8%) vs baseline: +1.2% Memory: ✅ 43.865MB (SLO: <46.000MB -4.6%) vs baseline: +5.5% ✅ ospathjoin_aspectTime: ✅ 637.117µs (SLO: <700.000µs -9.0%) vs baseline: +1.3% Memory: ✅ 43.862MB (SLO: <46.000MB -4.6%) vs baseline: +5.2% ✅ ospathjoin_noaspectTime: ✅ 643.857µs (SLO: <700.000µs -8.0%) vs baseline: +1.5% Memory: ✅ 43.866MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ ospathnormcase_aspectTime: ✅ 352.614µs (SLO: <700.000µs 📉 -49.6%) vs baseline: +1.7% Memory: ✅ 43.888MB (SLO: <46.000MB -4.6%) vs baseline: +5.8% ✅ ospathnormcase_noaspectTime: ✅ 359.060µs (SLO: <700.000µs 📉 -48.7%) vs baseline: -0.5% Memory: ✅ 43.901MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ ospathsplit_aspectTime: ✅ 492.580µs (SLO: <700.000µs 📉 -29.6%) vs baseline: -0.2% Memory: ✅ 43.850MB (SLO: <46.000MB -4.7%) vs baseline: +5.3% ✅ ospathsplit_noaspectTime: ✅ 504.261µs (SLO: <700.000µs 📉 -28.0%) vs baseline: -0.1% Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +5.6% ✅ ospathsplitdrive_aspectTime: ✅ 373.155µs (SLO: <700.000µs 📉 -46.7%) vs baseline: +0.4% Memory: ✅ 43.818MB (SLO: <46.000MB -4.7%) vs baseline: +5.2% ✅ ospathsplitdrive_noaspectTime: ✅ 73.892µs (SLO: <700.000µs 📉 -89.4%) vs baseline: +1.2% Memory: ✅ 43.875MB (SLO: <46.000MB -4.6%) vs baseline: +5.2% ✅ ospathsplitext_aspectTime: ✅ 467.010µs (SLO: <700.000µs 📉 -33.3%) vs baseline: +1.0% Memory: ✅ 43.879MB (SLO: <46.000MB -4.6%) vs baseline: +5.3% ✅ ospathsplitext_noaspectTime: ✅ 475.813µs (SLO: <700.000µs 📉 -32.0%) vs baseline: +0.1% Memory: ✅ 43.911MB (SLO: <46.000MB -4.5%) vs baseline: +5.5% 🟡 Near SLO Breach (6 suites)🟡 djangosimple - 28/28✅ appsecTime: ✅ 19.683ms (SLO: <22.300ms 📉 -11.7%) vs baseline: -0.3% Memory: ✅ 71.349MB (SLO: <73.500MB -2.9%) vs baseline: +4.7% ✅ exception-replay-enabledTime: ✅ 1.373ms (SLO: <1.450ms -5.3%) vs baseline: +0.4% Memory: ✅ 69.599MB (SLO: <71.500MB -2.7%) vs baseline: +4.9% ✅ iastTime: ✅ 19.712ms (SLO: <22.250ms 📉 -11.4%) vs baseline: ~same Memory: ✅ 71.310MB (SLO: <75.000MB -4.9%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.285ms (SLO: <16.550ms -7.6%) vs baseline: +0.4% Memory: ✅ 60.476MB (SLO: <61.000MB 🟡 -0.9%) vs baseline: +5.1% ✅ resource-renamingTime: ✅ 19.525ms (SLO: <21.750ms 📉 -10.2%) vs baseline: -0.3% Memory: ✅ 71.378MB (SLO: <73.500MB -2.9%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 20.169ms (SLO: <28.200ms 📉 -28.5%) vs baseline: +1.7% Memory: ✅ 71.423MB (SLO: <75.000MB -4.8%) vs baseline: +5.1% ✅ tracerTime: ✅ 19.736ms (SLO: <21.750ms -9.3%) vs baseline: ~same Memory: ✅ 71.329MB (SLO: <75.000MB -4.9%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 21.128ms (SLO: <23.500ms 📉 -10.1%) vs baseline: +0.1% Memory: ✅ 73.276MB (SLO: <75.000MB -2.3%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.687ms (SLO: <21.500ms -8.4%) vs baseline: -0.4% Memory: ✅ 71.310MB (SLO: <75.000MB -4.9%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 17.844ms (SLO: <18.500ms -3.5%) vs baseline: -0.2% Memory: ✅ 71.251MB (SLO: <75.000MB -5.0%) vs baseline: +4.7% ✅ tracer-no-cachesTime: ✅ 18.909ms (SLO: <19.650ms -3.8%) vs baseline: +0.3% Memory: ✅ 71.349MB (SLO: <75.000MB -4.9%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 20.657ms (SLO: <21.100ms -2.1%) vs baseline: -0.5% Memory: ✅ 71.310MB (SLO: <75.000MB -4.9%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 19.431ms (SLO: <21.500ms -9.6%) vs baseline: +0.2% Memory: ✅ 71.310MB (SLO: <75.000MB -4.9%) vs baseline: +4.8% ✅ tracer-no-templatesTime: ✅ 19.645ms (SLO: <22.000ms 📉 -10.7%) vs baseline: +1.4% Memory: ✅ 71.408MB (SLO: <73.500MB -2.8%) vs baseline: +4.9% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 40.701ms (SLO: <47.150ms 📉 -13.7%) vs baseline: -0.2% Memory: ✅ 41.185MB (SLO: <47.000MB 📉 -12.4%) vs baseline: +5.2% ✅ add-metricsTime: ✅ 233.870ms (SLO: <344.800ms 📉 -32.2%) vs baseline: -0.5% Memory: ✅ 45.754MB (SLO: <47.500MB -3.7%) vs baseline: +5.3% ✅ add-tagsTime: ✅ 263.828ms (SLO: <330.000ms 📉 -20.1%) vs baseline: -0.6% Memory: ✅ 45.885MB (SLO: <47.500MB -3.4%) vs baseline: +5.4% ✅ get-contextTime: ✅ 83.839ms (SLO: <92.350ms -9.2%) vs baseline: ~same Memory: ✅ 41.622MB (SLO: <46.500MB 📉 -10.5%) vs baseline: +5.3% ✅ is-recordingTime: ✅ 39.019ms (SLO: <44.500ms 📉 -12.3%) vs baseline: +0.3% Memory: ✅ 41.250MB (SLO: <47.500MB 📉 -13.2%) vs baseline: +5.4% ✅ record-exceptionTime: ✅ 61.086ms (SLO: <67.650ms -9.7%) vs baseline: +0.2% Memory: ✅ 41.764MB (SLO: <47.000MB 📉 -11.1%) vs baseline: +5.0% ✅ set-statusTime: ✅ 44.828ms (SLO: <50.400ms 📉 -11.1%) vs baseline: +0.4% Memory: ✅ 41.244MB (SLO: <47.000MB 📉 -12.2%) vs baseline: +5.6% ✅ startTime: ✅ 39.981ms (SLO: <44.500ms 📉 -10.2%) vs baseline: +4.0% Memory: ✅ 41.128MB (SLO: <47.000MB 📉 -12.5%) vs baseline: +5.3% ✅ start-finishTime: ✅ 90.200ms (SLO: <92.000ms 🟡 -2.0%) vs baseline: +0.1% Memory: ✅ 38.830MB (SLO: <46.500MB 📉 -16.5%) vs baseline: +5.4% ✅ start-finish-telemetryTime: ✅ 91.838ms (SLO: <93.000ms 🟡 -1.2%) vs baseline: +0.3% Memory: ✅ 38.810MB (SLO: <46.500MB 📉 -16.5%) vs baseline: +5.2% ✅ update-nameTime: ✅ 40.312ms (SLO: <45.150ms 📉 -10.7%) vs baseline: +0.3% Memory: ✅ 41.275MB (SLO: <47.000MB 📉 -12.2%) vs baseline: +5.3% 🟡 packagesupdateimporteddependencies - 24/24 (1 unstable)✅ import_manyTime: ✅ 156.970µs (SLO: <170.000µs -7.7%) vs baseline: +0.6% Memory: ✅ 41.007MB (SLO: <46.000MB 📉 -10.9%) vs baseline: +4.5% ✅ import_many_cachedTime: ✅ 122.443µs (SLO: <130.000µs -5.8%) vs baseline: -0.1% Memory: ✅ 41.215MB (SLO: <46.000MB 📉 -10.4%) vs baseline: +5.5% ✅ import_many_stdlibTime: ✅ 1.249ms (SLO: <1.750ms 📉 -28.6%) vs baseline: -0.3% Memory: ✅ 41.112MB (SLO: <46.000MB 📉 -10.6%) vs baseline: +4.8%
|
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 13c0f8d | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codeowners resolved as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0a4bb84a3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Description
Removes all remaining
--no-ddtraceflags from riotfile.py, expanding dogfooding of the new Test Optimization plugin (ddtrace/testing) to more test suites.Most of these
--no-ddtraceflags were originally added when the old_plugin_v2.py-backed plugin was in use for outer sessions. Now that the new plugin (ddtrace/testing) is the default and is used for outer sessions, they are no longer needed.Inner sessions (spawned by tests such as pytest-bdd, pytest-benchmark, pytest-flaky, and selenium) are not affected:
inline_run-based inner sessions (pytest-bdd, pytest-benchmark, pytest-flaky) usePytestTestCaseBase.inline_run(), which suspends/resumes the outer CIVisibility instance and explicitly controls the--ddtraceflag per inner session.For now, all inner sessions use the new plugin (since
DD_PYTEST_USE_NEW_PLUGIN=falsein_ci_override_envhas no effect on already-imported modules in in-process sessions). This is intentional — the new plugin is the focus of current efforts.Also addresses comment by codex:
By removing those env vars in conftest.py with a fixture, and also pause/resume any CIVisibility instance (not needed for ddtrace/testing plugin really, but it is needed if we switched to v2).
Testing
Covered by the dogfooded test suites themselves running under the new plugin.
Risks
Low. The new plugin is already the default. Removing
--no-ddtraceonly affects the outer pytest session instrumentation; inner sessions already control their own plugin activation.Additional Notes
Suites like
pytest_bddandpytest_benchmarkhave separate bdd/benchmark implementations in both plugins. Future work could add explicit coverage for the new plugin's code paths for those integrations.