Skip to content

Conversation

@vpellan
Copy link
Contributor

@vpellan vpellan commented Dec 9, 2025

What does this PR do?

RemoveFallbackAny exclusion from the Steepfile and fixes related issues.

Motivation:

Improve typing on dd-trace-rb.

Change log entry

None.

Additional Notes:

How to test the change?

bundle exec rake steep:check

@github-actions github-actions bot added core Involves Datadog core libraries appsec Application Security monitoring product tracing labels Dec 9, 2025
@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2025

Benchmarks

Benchmark execution time: 2026-01-09 14:00:31

Comparing candidate commit 8a2cb5d in PR branch vpellan/steep-fix-fallback-any with baseline commit 5ec9115 in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+10723.525op/s; +11314.036op/s] or [+7.491%; +7.904%]

scenario:line instrumentation - untargeted

  • 🟩 throughput [+5477.250op/s; +5579.892op/s] or [+10.152%; +10.342%]

scenario:method instrumentation

  • 🟩 throughput [+12599.350op/s; +13185.736op/s] or [+7.714%; +8.073%]

scenario:tracing - Propagation - Trace Context

  • 🟥 throughput [-4100.162op/s; -4001.702op/s] or [-10.970%; -10.706%]

@vpellan vpellan force-pushed the vpellan/steep-fix-incompatible-assignment branch 2 times, most recently from 1e330b6 to 6805e86 Compare December 11, 2025 09:22
@vpellan vpellan force-pushed the vpellan/steep-fix-fallback-any branch from bca5a5f to 6c77f82 Compare December 11, 2025 09:23
@github-actions github-actions bot added integrations Involves tracing integrations profiling Involves Datadog profiling otel OpenTelemetry-related changes labels Dec 12, 2025
@vpellan vpellan force-pushed the vpellan/steep-fix-fallback-any branch from c99e3fa to 5e060b7 Compare December 15, 2025 14:35
@vpellan vpellan force-pushed the vpellan/steep-fix-incompatible-assignment branch from 6805e86 to f575b3a Compare December 15, 2025 14:40
@vpellan vpellan force-pushed the vpellan/steep-fix-fallback-any branch from 5e060b7 to cf6491e Compare December 15, 2025 14:42
@vpellan vpellan marked this pull request as ready for review December 15, 2025 17:36
@vpellan vpellan requested review from a team as code owners December 15, 2025 17:36
@vpellan vpellan requested review from mabdinur and removed request for a team December 15, 2025 17:36
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass on the profiling bits and looks reasonable!

@vpellan vpellan force-pushed the vpellan/steep-fix-incompatible-assignment branch from f575b3a to b56de93 Compare December 16, 2025 13:12
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass over AppSec and can 👍🏼

BUT I do think that it makes sense to use AI to give a pass over some standards like top-level class instead of potential redefined class (::String instead of String)

Base automatically changed from vpellan/steep-fix-incompatible-assignment to master December 16, 2025 16:30
@vpellan vpellan force-pushed the vpellan/steep-fix-fallback-any branch from cf6491e to 265d1f8 Compare December 18, 2025 14:56
@vpellan vpellan force-pushed the vpellan/steep-fix-fallback-any branch from 3c1c2b7 to 1e1e3c7 Compare January 8, 2026 11:59
@vpellan vpellan merged commit 60ab25c into master Jan 9, 2026
637 checks passed
@vpellan vpellan deleted the vpellan/steep-fix-fallback-any branch January 9, 2026 14:24
@github-actions github-actions bot added this to the 2.25.0 milestone Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appsec Application Security monitoring product core Involves Datadog core libraries integrations Involves tracing integrations otel OpenTelemetry-related changes profiling Involves Datadog profiling tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants