-
Notifications
You must be signed in to change notification settings - Fork 397
[NO-TICKET] Fix FallbackAny steep check
#5124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2026-01-09 14:00:31 Comparing candidate commit 8a2cb5d in PR branch Found 3 performance improvements and 1 performance regressions! Performance is the same for 40 metrics, 2 unstable metrics. scenario:line instrumentation - targeted
scenario:line instrumentation - untargeted
scenario:method instrumentation
scenario:tracing - Propagation - Trace Context
|
sig/datadog/core/vendor/multipart-post/multipart/post/composite_read_io.rbs
Outdated
Show resolved
Hide resolved
1e330b6 to
6805e86
Compare
bca5a5f to
6c77f82
Compare
c99e3fa to
5e060b7
Compare
6805e86 to
f575b3a
Compare
5e060b7 to
cf6491e
Compare
ivoanjo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a pass on the profiling bits and looks reasonable!
f575b3a to
b56de93
Compare
Strech
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a pass over AppSec and can 👍🏼
BUT I do think that it makes sense to use AI to give a pass over some standards like top-level class instead of potential redefined class (::String instead of String)
cf6491e to
265d1f8
Compare
It is not needed, and Steep cannot find `e` in the ensure block while it can outside.
Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
Co-authored-by: Strech <sergey.fedorov@datadoghq.com>
3c1c2b7 to
1e1e3c7
Compare
What does this PR do?
RemoveFallbackAny exclusion from the Steepfile and fixes related issues.
Motivation:
Improve typing on dd-trace-rb.
Change log entry
None.
Additional Notes:
How to test the change?
bundle exec rake steep:check