DEBUG-4548 Increase number of iterations for flakiness #5184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: bfc4f90 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
ivoanjo
approved these changes
Jan 5, 2026
Member
ivoanjo
left a comment
ivoanjo
left a comment
There was a problem hiding this comment.
👍 Looking at this test it looks quite brittle so in some future we should probably review it, but for now agree with holding our noses and try to get rid of the flakiness.
p-datadog
pushed a commit
that referenced
this pull request
Jan 5, 2026
* master: Ignore "leaked" pipe file descriptors in JRuby, improve diagnostics (#5188) debug-4548 Increase number of iterations for flakiness (#5184) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20684824141 [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20616292456 (#5190)
p-datadog
pushed a commit
that referenced
this pull request
Jan 5, 2026
* master: Ignore "leaked" pipe file descriptors in JRuby, improve diagnostics (#5188) debug-4548 Increase number of iterations for flakiness (#5184) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20684824141
p-datadog
pushed a commit
that referenced
this pull request
Jan 5, 2026
* master: (129 commits) Transports: remove api_version (#5164) DEBUG-4548 Telemetry: send events in forked children + telemetry metrics reset after fork (#5159) Ignore "leaked" pipe file descriptors in JRuby, improve diagnostics (#5188) debug-4548 Increase number of iterations for flakiness (#5184) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20684824141 [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20616292456 (#5190) downgrade ffi for ruby 4.0 & 2.5 (#5189) Fix ruby warnings when accessing undefined instance variables (#5178) DEBUG-3499 DI: fix accounting when intrumenting upon class definition, add instr… (#5168) DEBUG-3499 RC: add diagnostics for invalid values (#5167) DEBUG-4548 Core: fix worker shutdown race (#5176) Retry system-test build (#5181) Fix Baggage type check (#5182) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20487829791 (#5183) [🤖] Update Latest Dependency: https://github.com/DataDog/dd-trace-rb/actions/runs/20401889084 (#5180) DEBUG-3499 DI: do not instrument when there is already an installed probe with the same id (#5169) DEBUG-3499 DI: rework RC interface (#5165) set DI test duration upper bound to 1000 seconds (#5161) add missing supported config default value [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20401907816 (#5179) ...
p-datadog
pushed a commit
that referenced
this pull request
Jan 5, 2026
* master: Transports: remove api_version (#5164) DEBUG-4548 Telemetry: send events in forked children + telemetry metrics reset after fork (#5159) Ignore "leaked" pipe file descriptors in JRuby, improve diagnostics (#5188) debug-4548 Increase number of iterations for flakiness (#5184) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/20684824141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Increases number of iterations in CI for the worker race test added in #5176
Motivation:
CI is flaking: https://github.com/DataDog/dd-trace-rb/actions/runs/20491855096/job/58885380113?pr=5159
Change log entry
None
Additional Notes:
There is no guarantee that any reasonable bound will suffice...
I would like to retain the test.
How to test the change?
Existing CI not failing