-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix a bunch of lettered lists and alignment #33709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! I also spot checked some of the previews and they looked good.
fuzzybinary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor nit about the indentation within code blocks. It's possible it doesn't affect rendering though and if that's the case it can be ignored.
| {{% /tab %}} | ||
| {{% tab "Java" %}} | ||
| ```java | ||
| public class SampleApplication extends Application { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think sometimes these code blocks are getting extra indentation, and sometimes they're not. I'm not sure if it affects rendering but I thought I would point it out.
For example, this java block is indented one level above the "```java" whereas the one below with kotlin isn't.
It looks like prior all code is indented to the same level as the opening block.
What does this PR do? What is the motivation?
This PR looks large, but it should be easy to review! I did it because I noticed that there were instances of nested lists that were formatted like
Most commonly, using these lettered lists caused issues like the list items all appearing on a single line, or writers having to put in rogue
<br /tags to make them appear as expected.The formatting we need for lists to be rendered correctly looks like
So I went through and updated them. While I was at it, I also made a handful of minor typo/punctuation edits and whitespace edits to make code blocks align with those list items, which now had their own proper alignments! I know you're as thrilled as I am about this!
As always, I checked the changes I made in my local build while I did them. Your mission, should you choose to accept it, is to check to ensure I didn't delete something dumb or change what I shouldn't have, but overall it should be fairly easy to spot check. Let me know if you have any questions!
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes