Skip to content

Conversation

@janine-c
Copy link
Contributor

@janine-c janine-c commented Jan 7, 2026

What does this PR do? What is the motivation?

This PR looks large, but it should be easy to review! I did it because I noticed that there were instances of nested lists that were formatted like

1. Top-level list item
   a. Nested list item

Most commonly, using these lettered lists caused issues like the list items all appearing on a single line, or writers having to put in rogue <br / tags to make them appear as expected.

The formatting we need for lists to be rendered correctly looks like

1. Top-level list item
   1. Nested list item

So I went through and updated them. While I was at it, I also made a handful of minor typo/punctuation edits and whitespace edits to make code blocks align with those list items, which now had their own proper alignments! I know you're as thrilled as I am about this!

As always, I checked the changes I made in my local build while I did them. Your mission, should you choose to accept it, is to check to ensure I didn't delete something dumb or change what I shouldn't have, but overall it should be fairly easy to spot check. Let me know if you have any questions!

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:

Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.

Additional notes

@janine-c janine-c requested review from a team as code owners January 7, 2026 18:18
@github-actions github-actions bot added Architecture Everything related to the Doc backend Guide Content impacting a guide FAQ Content impacting a FAQ labels Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@maycmlee maycmlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I also spot checked some of the previews and they looked good.

@maycmlee maycmlee merged commit 7e21a87 into master Jan 7, 2026
22 of 24 checks passed
@maycmlee maycmlee deleted the janine.chan/fix-nested-numbered-lists branch January 7, 2026 20:40
Copy link
Member

@fuzzybinary fuzzybinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor nit about the indentation within code blocks. It's possible it doesn't affect rendering though and if that's the case it can be ignored.

{{% /tab %}}
{{% tab "Java" %}}
```java
public class SampleApplication extends Application {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sometimes these code blocks are getting extra indentation, and sometimes they're not. I'm not sure if it affects rendering but I thought I would point it out.

For example, this java block is indented one level above the "```java" whereas the one below with kotlin isn't.

It looks like prior all code is indented to the same level as the opening block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Architecture Everything related to the Doc backend FAQ Content impacting a FAQ Guide Content impacting a guide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants