Add flush_every_n_blocks config option to BufWriter generators #1683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 6, 2026
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
a2c8d36 to
0e90fb1
Compare
TheSafo
changed the base branch from
jsaf/block-based-limiter
to
graphite-base/1683
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
0e90fb1 to
b69f29c
Compare
TheSafo
force-pushed
the
graphite-base/1683
branch
from
9ae8ce6 to
648642c
Compare
TheSafo
changed the base branch from
graphite-base/1683
to
jsaf/block-based-limiter
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
648642c to
a636e4c
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
b69f29c to
403c48a
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
403c48a to
e13d903
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
a636e4c to
661d654
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
e13d903 to
a62c9fd
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
2 times, most recently
from
867b097 to
e1d8abc
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
a62c9fd to
8180361
Compare
TheSafo
force-pushed
the
jsaf/block-based-limiter
branch
from
e1d8abc to
e73bb21
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
8180361 to
899bfeb
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
899bfeb to
886980b
Compare
TheSafo
force-pushed
the
jsaf/flush-every-n
branch
from
886980b to
8071239
Compare
TheSafo
changed the title
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds flush_every_n_blocks to traditional and logrotate generators. This is designed to be used in conjunction with block-based throttling to ensure that blocks are still flushed regularly.
Motivation
BufWriter generally only writes out to disk once its capacity is full (or on log rotate). For standard usage of lading, this works fine since the capacity is set at the maximum throttler capacity (in bytes), which lading trires its best to run at, so it flushes ~every second. However, for block-based throttling (and varying block sizes) it's less likely that 1 second of blocks fills the maximum possible bytes capacity for those blocks (blocks per second times max block size), so having a config option to manually flush every few blocks ensures regular flush intervals.
Related issues
Follow up of #1675