[nodejs@ccapell/check-discarded-payloads] Fix Hardcoded passwords and secrets flaky tests

[CarlesDD]

Motivation

Changes

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
• A docker base image is modified?
  • the relevant build-XXX-image label is present
• A scenario is added, removed or renamed?
  • Get a review from R&P team

[github-actions]

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js

[datadog-official]

⚠️ Tests

✨ Fix all issues with Cursor

⚠️ Warnings

❄️ 5 New flaky tests detected

tests.appsec.iast.sink.test_hardcoded_passwords.Test_HardcodedPasswords_ExtendedLocation.test_extended_location_data[uds-express4] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: No hardcoded vulnerabilities found
assert []

self = <tests.appsec.iast.sink.test_hardcoded_passwords.Test_HardcodedPasswords_ExtendedLocation object at 0x7f4b33be2180>

    def test_extended_location_data(self):
>       hardcoded_passwords = get_hardcoded_vulnerabilities("HARDCODED_PASSWORD")

tests/appsec/iast/sink/test_hardcoded_passwords.py:68: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
...

tests.appsec.iast.sink.test_hardcoded_passwords.Test_HardcodedPasswords.test_hardcoded_passwords_exec[uds-express4] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: No hardcoded vulnerabilities found
assert []

self = <tests.appsec.iast.sink.test_hardcoded_passwords.Test_HardcodedPasswords object at 0x7f4b33be1dc0>

    def test_hardcoded_passwords_exec(self):
        assert self.r_hardcoded_passwords_exec.status_code == 200
>       hardcoded_passwords = get_hardcoded_vulnerabilities("HARDCODED_PASSWORD")

tests/appsec/iast/sink/test_hardcoded_passwords.py:30: 
...

tests.appsec.iast.sink.test_hardcoded_secrets.Test_HardcodedSecrets_ExtendedLocation.test_extended_location_data[uds-express4] from system_tests_suite (Datadog) (Fix with Cursor)

AssertionError: No hardcoded vulnerabilities found
assert []

self = <tests.appsec.iast.sink.test_hardcoded_secrets.Test_HardcodedSecrets_ExtendedLocation object at 0x7f4b33be2c30>

    def test_extended_location_data(self):
>       hardcode_secrets = get_hardcoded_vulnerabilities("HARDCODED_SECRET")

tests/appsec/iast/sink/test_hardcoded_secrets.py:92: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
...

View all

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: f3c8918 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}