[java@alejandro.gonzalez/RFC-1081-proxy-2]Enable Java v2 tests for proxy inferred spans#6441
Open
[java@alejandro.gonzalez/RFC-1081-proxy-2]Enable Java v2 tests for proxy inferred spans#6441
Conversation
- Add full_trace=True to all v2 tests to search across all traces (aws.apigateway span is a root span in a separate trace) - Skip http.status_code validation for Java (span created before request completes) - Skip error field validation for Java (span created before request completes) - Skip optional tags validation for Java (not yet implemented, only mandatory tags required) - Enable v2 tests for Java in manifests/java.yml All 9 inferred proxy tests now pass (3 v1 + 6 v2). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Remove Java skip from optional_tags_validator_factory - optional tags are now implemented in Java tracer: - account_id (from x-dd-proxy-account-id) - apiid (from x-dd-proxy-api-id) - region (from x-dd-proxy-region) - dd_resource_key (computed ARN) Note: aws_user validation removed per RFC (PII concerns - not implemented) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
|
|
jandro996
requested review from
daniel-romano-DD,
florentinl and
manuel-alvarez-alvarez
jandro996
changed the title
Remove the Java-specific branches that skipped validation of http.status_code and error tags on inferred proxy spans. These tags are now correctly propagated from the service-entry span to the inferred proxy span.
jandro996
changed the title
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: ae0d169 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
nccatoni
approved these changes
Mar 6, 2026
Collaborator
nccatoni
left a comment
nccatoni
left a comment
There was a problem hiding this comment.
LGTM (for @DataDog/system-tests-core) but you should get a review from someone familiar with the feature.
florentinl
approved these changes
Mar 9, 2026
…ava tracer is setting http.request.headers.user-agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enabled test and modify them to suits java special behaviour:
http.status_codeanderror— fixed in traceraws_usertag (maps tox-dd-proxy-userheader) — PII concern, not included in the specfull_trace=Trueis required inget_appsec_eventsloopWorkflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present