Skip to content

[ruby@appsec-61515-add-content-headers-when-appsec-enabled] Enable tests for content-* #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Strech wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −1
Draft

[ruby@appsec-61515-add-content-headers-when-appsec-enabled] Enable tests for content-* #6454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89f7da0
Enable tests for content-length and content-type
Strech Mar 9, 2026
4115f4b
Empty-Commit
Strech Mar 10, 2026
5f1253f
Exclude rails42 because of old Rack
Strech Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion manifests/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,11 @@ manifest:
tests/appsec/test_service_activation_metric.py::TestServiceActivationRemoteConfigMetric: missing_feature
tests/appsec/test_service_activation_metric.py::TestServiceActivationRemoteConfigurationConfigMetric: missing_feature
tests/appsec/test_shell_execution.py::Test_ShellExecution: missing_feature
tests/appsec/test_span_tags_headers.py: bug (APPSEC-61286)
tests/appsec/test_span_tags_headers.py:
- weblog_declaration:
"*": v2.30.0-dev
graphql23: irrelevant
rails42: missing_feature # Old Rack does not support to_ary for content-length computation
tests/appsec/test_suspicious_attacker_blocking.py::Test_Suspicious_Attacker_Blocking: missing_feature
tests/appsec/test_trace_tagging.py::Test_TraceTaggingRules: v2.22.0-dev
tests/appsec/test_trace_tagging.py::Test_TraceTaggingRulesRcCapability: v2.22.0-dev
Expand Down
4 changes: 4 additions & 0 deletions utils/build/docker/ruby/rack/config.ru
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,10 @@ class TraceSamplingMiddleware
end

use TraceSamplingMiddleware
# NOTE: Most of the frameworks rely on Web Server to compute `Content-Length` header.
# But in this case to make it different from Rails and Sinatra we are going
# to provide it.
use Rack::ContentLength
Copy link
Member Author

@Strech Strech Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a separate example, we will pre-compute here a Content-Length header, but rest of the weblogs don't do it as they rely on web-server to compute it


# /flush
module Flush
Expand Down
Loading