feat(DRC-2121/DRC-2067): disambiguate artifact name and before/after colors #957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define envBase and envCurrent semantic tokens in theme and apply to EnvInfo component to distinguish base (amber) and current (blue) environments. Signed-off-by: Kent <iamcxa@gmail.com>
iamcxa
force-pushed
the
feature/drc-2121-disambiguate-artifact-name-and-beforeafter
branch
from
3d9e211 to
c854a17
Compare
iamcxa
changed the title
gcko
requested changes
Nov 20, 2025
Contributor
gcko
left a comment
gcko
left a comment
There was a problem hiding this comment.
Everything looks good, although there is an added comment that is unattached to the fix. is this necessary? can you remove it?
js/src/lib/api/track.ts
Outdated
| export function trackNavigation(props: TrackNavProps) { | ||
| track("[Web] navigation_change", props); | ||
| } | ||
| // fixed |
iamcxa
force-pushed
the
feature/drc-2121-disambiguate-artifact-name-and-beforeafter
branch
from
c854a17 to
57b9d4a
Compare
gcko
approved these changes
Nov 20, 2025
gcko
deleted the
feature/drc-2121-disambiguate-artifact-name-and-beforeafter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
What type of PR is this?
feat
What this PR does / why we need it:
To distinguish between different artifacts with the same name (e.g. in
dbtstate comparisons) and to visually separate "Base" and "Current" environments, this PR:envBase(Amber) andenvCurrent(Blue/Iochmara) in the theme.Which issue(s) this PR fixes:
Fixes DRC-2121
Special notes for your reviewer:
src/lib/api/track.ts.Does this PR introduce a user-facing change?:
YES