Open
Conversation
Collaborator
|
Sorry about the long delay in getting back to you about this. What is the benefit of removing the overlay, and adding event listeners to the document to close the menu on click of the document anyway? The only reason I could see (and it is a valid one!) is to allow immediate interaction with the rest of the document. Was that the intention here? I wonder if it might be better to put that ability into TableTools, as I'm ultimately planning to merge ColVis and TableTools together - or at least using TableTools to provide the buttons interface for ColVis. |
Author
|
Yes, the reason is the immediate interaction with the rest of the document as it seems "more natural" and interactive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to choose whether to display the overlay.