fix(laserflow): correct aspect-ratio scaling in shader#903
Open
EunHyeokJung wants to merge 1 commit intoDavidHDev:mainfrom
Open
fix(laserflow): correct aspect-ratio scaling in shader#903EunHyeokJung wants to merge 1 commit intoDavidHDev:mainfrom
EunHyeokJung wants to merge 1 commit intoDavidHDev:mainfrom
Conversation
- apply axis-aware uv scaling for portrait/landscape consistency - regenerate LaserFlow registry artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent
verticalSizing/verticalBeamOffsetbehavior inLaserFlowon portrait/mobile aspect ratios.Fixes #896
Root Cause
mainImageused a single scalar scale derived from width:That scalar was applied to both X/Y, so Y mapping changed incorrectly when aspect ratio changed (especially portrait).
Changes
Applied the same shader fix across all 4 variants:
src/content/Animations/LaserFlow/LaserFlow.jsxsrc/tailwind/Animations/LaserFlow/LaserFlow.jsxsrc/ts-default/Animations/LaserFlow/LaserFlow.tsxsrc/ts-tailwind/Animations/LaserFlow/LaserFlow.tsxUpdated from scalar scale to axis-aware scale:
float sc->vec2 sc = (512.0 / iResolution.xy) * 0.4sc.x/sc.yRegenerated registry artifacts:
public/r/LaserFlow-JS-CSS.jsonpublic/r/LaserFlow-JS-TW.jsonpublic/r/LaserFlow-TS-CSS.jsonpublic/r/LaserFlow-TS-TW.jsonVerification
horizontalSizing={0.5}verticalSizing={0.9}verticalBeamOffset={0.0}npm run registry:buildnpm run buildVisual Comparison
360x640
1024x576
Scope