Skip to content

Fix AbstractDealProduct, DealProductUpdate, NewDealProduct to match discount breaking changes in API #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scorbeil-atmanco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix AbstractDealProduct, DealProductUpdate, NewDealProduct to match discount breaking changes in API #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Pipedrive.net.Tests.Integration/Clients/DealsClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,7 +728,8 @@ public async Task AddProductToDeal()
{
var newDealProduct = new NewDealProduct(1, 10, 30)
{
DiscountPercentage = 55,
Discount = 55,
DiscountType = "percentage",
EnabledFlag = true
};

Expand All @@ -742,7 +743,8 @@ public async Task AddProductToDeal()
Assert.Equal(10, dealProduct.ItemPrice);
Assert.Equal(30, dealProduct.Quantity);
Assert.Equal(135, dealProduct.Sum);
Assert.Equal(55, dealProduct.DiscountPercentage);
Assert.Equal(55, dealProduct.Discount);
Assert.Equal("percentage", dealProduct.DiscountType);

// Cleanup
await fixture.DeleteProduct(1, dealProduct.ProductAttachmentId.Value);
Expand All @@ -764,7 +766,8 @@ public async Task UpdateDealProduct()
ItemPrice = 44,
Quantity = 1,
Duration = 1,
DiscountPercentage = 11
Discount = 11,
DiscountType = "percentage"
};

var updatedDealProduct = await fixture.UpdateProduct(1, createdDealProduct.ProductAttachmentId.Value, dealProductUpdate);
Expand Down
7 changes: 5 additions & 2 deletions src/Pipedrive.net/Models/Request/Deals/DealProductUpdate.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ public class DealProductUpdate
[JsonProperty("quantity")]
public long Quantity { get; set; }

[JsonProperty("discount_percentage")]
public decimal DiscountPercentage { get; set; }
[JsonProperty("discount")]
public decimal Discount { get; set; }

[JsonProperty("discount_type")]
public string DiscountType { get; set; }

[JsonProperty("duration")]
public long Duration { get; set; } = 1;
Expand Down
7 changes: 5 additions & 2 deletions src/Pipedrive.net/Models/Request/Deals/NewDealProduct.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ public class NewDealProduct
[JsonProperty("quantity")]
public long Quantity { get; set; }

[JsonProperty("discount_percentage")]
public decimal DiscountPercentage { get; set; }
[JsonProperty("discount")]
public decimal Discount { get; set; }

[JsonProperty("discount_type")]
public string DiscountType { get; set; }

[JsonProperty("duration")]
public long Duration { get; set; } = 1;
Expand Down
7 changes: 5 additions & 2 deletions src/Pipedrive.net/Models/Response/Products/AbstractDealProduct.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ public abstract class AbstractDealProduct
[JsonProperty("item_price")]
public decimal ItemPrice { get; set; }

[JsonProperty("discount_percentage")]
public decimal DiscountPercentage { get; set; }
[JsonProperty("discount")]
public decimal Discount { get; set; }

[JsonProperty("discount_type")]
public string DiscountType { get; set; }

[JsonProperty("duration")]
public long Duration { get; set; }
Expand Down