Adjust role for buliding AMIs with Packer #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszkiewicz
changed the title
andyshinn
reviewed
Jul 14, 2018
| notify: | ||
| - restart filebeat | ||
|
|
||
| - name: modify filebeat service file to include environment variables |
Contributor
There was a problem hiding this comment.
This would probably make sense as a drop-in unit instead of modifying the unit directly: https://www.freedesktop.org/software/systemd/man/systemd.unit.html#Description
Along with a unit file foo.service, a "drop-in" directory foo.service.d/ may exist. All files with the suffix ".conf" from this directory will be parsed after the unit file itself is parsed. This is useful to alter or add configuration settings for a unit, without having to modify unit files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added a little switch I use often in Ansible for building AMI packages in AWS using Packer tool.
The thing is that while building we don't want to start the services, because they are often in unconfigured state, so setting start_services to false prevents that.
The default behaviour is unchanged, so running playbook with this role installs and starts filebeat.
The other thing I've added (only for RedHat, as I know how to do it in RH) is the environment file reference for systemd file - this is to be used in templates, where you can use env variables for dynamic configuration of filebeat.
Best regards
Łukasz Tomaszkiewicz