Canonization #15
Open
Canonization #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentElement
requested changes
Feb 4, 2025
src/canonize.rs
Outdated
| pub fn canonize(m: &Molecule) -> String { | ||
| let mol_graph = m.get_graph(); | ||
|
|
||
| /* |
Collaborator
There was a problem hiding this comment.
I think this entire comment block should be removed
| capacity: 0, | ||
| } | ||
| } | ||
| pub fn get_element(&self) -> String { |
Collaborator
There was a problem hiding this comment.
Maybe have .element() return the element, and implement a to_string() on the element type?
| Self { graph: g } | ||
| } | ||
|
|
||
| pub fn get_graph(&self) -> &MGraph { |
Collaborator
There was a problem hiding this comment.
We can use .graph() instead, it does the same thing.
|
|
||
| let (curr, level) = visited.pop_front().unwrap(); | ||
|
|
||
| // println!("Current:{:?}", curr); |
Collaborator
There was a problem hiding this comment.
Remove all of these print statements (and other commented out code) as well
Collaborator
|
Additionally, I'd be too scared to try to work with this without a handful of tests. The commented-out block constructing the dummy molecule would make a good test. |
jdaymude
added
duplicate
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.