[feat] Add drift correction area selection to ui

[patrickcleeve2]

note: reworking this in feat-drift-correction-settings

[pep8speaks]

Hello @patrickcleeve2! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file fibsem/microscope.py:

Line 1628:1: W293 blank line contains whitespace
Line 1629:9: E303 too many blank lines (3)
Line 1637:77: W291 trailing whitespace
Line 1638:1: W293 blank line contains whitespace
Line 1643:1: W293 blank line contains whitespace
Line 5535:80: E501 line too long (135 > 79 characters)

• In the file fibsem/structures.py:

Line 1096:80: E501 line too long (84 > 79 characters)

• In the file fibsem/ui/FibsemMillingWidget.py:

Line 82:33: E261 at least two spaces before inline comment
Line 210:1: W293 blank line contains whitespace
Line 211:80: E501 line too long (99 > 79 characters)
Line 214:9: E303 too many blank lines (2)
Line 214:80: E501 line too long (97 > 79 characters)
Line 215:80: E501 line too long (89 > 79 characters)
Line 216:80: E501 line too long (97 > 79 characters)
Line 222:1: W293 blank line contains whitespace
Line 226:1: W293 blank line contains whitespace
Line 228:5: E303 too many blank lines (2)
Line 234:80: E501 line too long (106 > 79 characters)
Line 235:80: E501 line too long (85 > 79 characters)
Line 238:80: E501 line too long (107 > 79 characters)
Line 239:80: E501 line too long (88 > 79 characters)
Line 240:1: W293 blank line contains whitespace
Line 242:1: W293 blank line contains whitespace
Line 244:1: W293 blank line contains whitespace
Line 245:80: E501 line too long (119 > 79 characters)
Line 246:80: E501 line too long (111 > 79 characters)
Line 252:32: W291 trailing whitespace
Line 253:1: W293 blank line contains whitespace
Line 254:80: E501 line too long (150 > 79 characters)
Line 264:1: W293 blank line contains whitespace
Line 266:17: E303 too many blank lines (2)
Line 266:80: E501 line too long (180 > 79 characters)
Line 268:80: E501 line too long (132 > 79 characters)
Line 269:1: W293 blank line contains whitespace
Line 270:80: E501 line too long (95 > 79 characters)
Line 270:96: W291 trailing whitespace
Line 271:29: E128 continuation line under-indented for visual indent
Line 271:70: W291 trailing whitespace
Line 272:29: E128 continuation line under-indented for visual indent
Line 276:1: W293 blank line contains whitespace
Line 277:13: E303 too many blank lines (2)
Line 280:1: W293 blank line contains whitespace
Line 281:9: E303 too many blank lines (2)
Line 283:1: W293 blank line contains whitespace
Line 285:80: E501 line too long (80 > 79 characters)
Line 287:1: W293 blank line contains whitespace
Line 289:5: E303 too many blank lines (2)
Line 294:80: E501 line too long (98 > 79 characters)
Line 294:99: W291 trailing whitespace
Line 295:76: W291 trailing whitespace
Line 299:80: E501 line too long (135 > 79 characters)
Line 300:80: E501 line too long (129 > 79 characters)
Line 302:80: E501 line too long (80 > 79 characters)
Line 303:80: E501 line too long (133 > 79 characters)
Line 304:1: W293 blank line contains whitespace
Line 323:80: E501 line too long (82 > 79 characters)
Line 325:1: W293 blank line contains whitespace
Line 329:60: W291 trailing whitespace
Line 330:80: E501 line too long (99 > 79 characters)
Line 333:80: E501 line too long (99 > 79 characters)
Line 334:80: E501 line too long (118 > 79 characters)
Line 336:80: E501 line too long (108 > 79 characters)
Line 339:80: E501 line too long (118 > 79 characters)
Line 343:80: E501 line too long (138 > 79 characters)
Line 344:1: W293 blank line contains whitespace
Line 348:1: W293 blank line contains whitespace
Line 350:80: E501 line too long (139 > 79 characters)
Line 353:35: W291 trailing whitespace
Line 639:80: E501 line too long (81 > 79 characters)
Line 763:80: E501 line too long (83 > 79 characters)
Line 764:80: E501 line too long (98 > 79 characters)
Line 780:80: E501 line too long (80 > 79 characters)
Line 781:80: E501 line too long (93 > 79 characters)

• In the file fibsem/ui/qtdesigner_files/FibsemMillingWidget.py:

Line 66:80: E501 line too long (81 > 79 characters)
Line 67:80: E501 line too long (89 > 79 characters)
Line 68:80: E501 line too long (83 > 79 characters)
Line 70:80: E501 line too long (81 > 79 characters)
Line 76:80: E501 line too long (83 > 79 characters)
Line 77:80: E501 line too long (81 > 79 characters)
Line 103:80: E501 line too long (86 > 79 characters)
Line 104:80: E501 line too long (105 > 79 characters)
Line 105:80: E501 line too long (92 > 79 characters)
Line 117:80: E501 line too long (80 > 79 characters)
Line 118:80: E501 line too long (97 > 79 characters)
Line 119:80: E501 line too long (88 > 79 characters)
Line 168:80: E501 line too long (114 > 79 characters)
Line 194:80: E501 line too long (86 > 79 characters)
Line 195:80: E501 line too long (83 > 79 characters)
Line 196:80: E501 line too long (109 > 79 characters)
Line 197:80: E501 line too long (94 > 79 characters)
Line 198:80: E501 line too long (87 > 79 characters)
Line 199:80: E501 line too long (113 > 79 characters)
Line 200:80: E501 line too long (96 > 79 characters)
Line 246:80: E501 line too long (92 > 79 characters)
Line 249:80: E501 line too long (80 > 79 characters)
Line 253:80: E501 line too long (101 > 79 characters)
Line 254:80: E501 line too long (94 > 79 characters)
Line 256:80: E501 line too long (81 > 79 characters)
Line 266:80: E501 line too long (113 > 79 characters)

• In the file fibsem/ui/utils.py:

Line 404:37: E231 missing whitespace after ','
Line 404:49: E231 missing whitespace after ','
Line 404:60: E231 missing whitespace after ','
Line 404:80: E501 line too long (114 > 79 characters)

[thomasmfish]

Hi Patrick, I was looking through this and I'm curious about what your plan is? We've been having some drift issues and was looking into using the DcPatterningEngine from autoscript_toolkit, which would ideally use a defined drift correction area like what you're doing here. Do you think this is something that could be built on top of what you're doing here?