Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

DeMarcoLab / fibsem Public

Notifications You must be signed in to change notification settings
Fork 15
Star 30

Code
Issues 14
Pull requests 4
Actions
Projects
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

Typing changes#346

Draft

thomasmfish wants to merge 25 commits intoDeMarcoLab:mainDeMarcoLab/fibsem:mainfrom

rosalindfranklininstitute:improve-typingrosalindfranklininstitute/fibsem:improve-typingCopy head branch name to clipboard

Conversation Commits25 (25)Checks Files changed

Draft

Typing changes#346
thomasmfish wants to merge 25 commits intoDeMarcoLab:mainfrom
rosalindfranklininstitute:improve-typing

Commits

Commits on Jun 6, 2025

base typing improvements
thomasmfish
committed
conversions type improvements
thomasmfish
committed
Update MillingStrategy and MillingStrategyConfig
thomasmfish
committed
image_settings.path is expected to be of type Path
thomasmfish
committed
Add some milling Optionals
thomasmfish
committed
Improve MIllingStrategy typing
thomasmfish
committed
Fix acquire_images_after_milling typing
thomasmfish
committed
Add missing milling_voltage argument to run_milling
thomasmfish
committed
Raise errors for unexpected types handling strategy widgets
thomasmfish
committed
Handle if ref_image attribute is unset in StandardMillingStrategy
thomasmfish
committed
Improve FibsemPatternSettings typing
thomasmfish
committed
Improve pattern typing (and fix dataclass default argument issue)
thomasmfish
committed
Smaller plotting type fixes
thomasmfish
committed
Various typing improvements for structures
thomasmfish
committed
Change default Nones to "Unknown"s to match from_dict
thomasmfish
committed

Commits on Jun 9, 2025

Fix typing changes
thomasmfish
committed
MillingStrategy.to_dict no longer an abstract method
thomasmfish
committed

Commits on Jun 10, 2025

Fix BasePattern inheritance issues
thomasmfish
committed
Improve alignment typing
thomasmfish
committed
estimate_milling_time: simplify cross_section check
thomasmfish
committed
Handle to_dict and from_dict in FibsemPatternSettings
thomasmfish
committed
Use collections.abc.Generator type hint
thomasmfish
committed
Update to newer typing style thanks to __future__.annotations
thomasmfish
committed
Update more typing with __future__.annotations
thomasmfish
committed
Type can also be updated to type
thomasmfish
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.