Skip to content

[FIX] [SANITIZER] Fix bitwise operations in _to_z3 with proper boolean conversion #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+13 −2
Open

[FIX] [SANITIZER] Fix bitwise operations in _to_z3 with proper boolean conversion #182

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
980dd57
[FIX] [SANITIZER] Fix bitwise operations in `_to_z3` with proper bool…
mark14wu Oct 3, 2025
64844b7
Merge branch 'main' into fix_missing_tl_int_1
mark14wu Oct 3, 2025
da14a00
Merge branch 'main' into fix_missing_tl_int_1
mark14wu Nov 4, 2025
27bcd67
Merge branch 'main' into fix_missing_tl_int_1
mark14wu Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions triton_viz/clients/sanitizer/sanitizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
And,
Or,
Not,
Xor,
sat,
simplify,
)
Expand Down Expand Up @@ -1085,6 +1086,9 @@ def eval(self) -> tuple[Union[ArithRef, list[ArithRef]], list[BoolRef]]:
return expr, constraints

def _to_z3(self) -> tuple[ArithRef, list]:
def _to_bool(x):
return x if isinstance(x, BoolRef) else (x != 0)

if self._z3 is not None:
return self._z3, self._constraints

Expand Down Expand Up @@ -1159,8 +1163,15 @@ def _to_z3(self) -> tuple[ArithRef, list]:
self._z3 = If(lhs >= rhs, lhs, rhs)
if self.op == "minimum":
self._z3 = If(lhs <= rhs, lhs, rhs)
if self.op == "bitwise_and":
self._z3 = And(lhs, rhs)
if "bitwise" in self.op:
lhs = _to_bool(lhs)
Copy link
Member

@Jokeren Jokeren Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the logic of to_bool.

You should probably look into BitVec in Z3

rhs = _to_bool(rhs)
if self.op == "bitwise_and":
self._z3 = And(lhs, rhs)
if self.op == "bitwise_or":
self._z3 = Or(lhs, rhs)
if self.op == "bitwise_xor":
self._z3 = Xor(lhs, rhs)
if self.op == "ashr":
raise NotImplementedError(
"Arithmetic shift right is not implemented in Z3"
Expand Down