sys: let bindgen handle target triple mapping#669
Merged
richarddd merged 1 commit intoDelSkayn:masterfrom Apr 15, 2026
Merged
Conversation
The build script manually passed `--target={rust_triple}` to clang via
`.clang_args()`, bypassing bindgen's `rust_to_clang_target()` which
correctly maps Rust triples to clang-compatible ones (e.g.
`riscv64gc-unknown-linux-gnu` to `riscv64-unknown-linux-gnu`, and
`*-windows-gnullvm` to `*-windows-gnu`). This broke builds on riscv64
because clang does not recognize the `gc` ISA extension suffix in the
target triple.
The manual `--target` and the gnullvm workaround from DelSkayn#506 are both
unnecessary since bindgen 0.65+ handles these mappings internally.
amaanq
force-pushed
the
fix-bindgen-target
branch
from
c9b7c9e to
6e91fb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The build script manually passed
--target={rust_triple}to clang via.clang_args(), bypassing bindgen'srust_to_clang_target()which correctly maps Rust triples to clang-compatible ones (e.g.riscv64gc-unknown-linux-gnutoriscv64-unknown-linux-gnu, and*-windows-gnullvmto*-windows-gnu). This broke builds on riscv64 because clang does not recognize thegcISA extension suffix in the target triple.The manual
--targetand the gnullvm workaround from #506 are both unnecessary since bindgen 0.65+ handles these mappings internally.(My use case is getting riscv64 bindings generated for tree-sitter now that we have a risc-v runner in theory)
Checklist