Skip to content

replace revert with return bool result #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ququzone wants to merge 2 commits into
base: main
Choose a base branch
from
Open

replace revert with return bool result #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37b659b
replace revert with return bool result
ququzone Oct 12, 2023
abe4680
Merge branch 'DelphinusLab:main' into main
ququzone Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions sol/contracts/AggregatorVerifier.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ contract AggregatorVerifier {
uint256[] calldata verify_instance,
uint256[] calldata aux,
uint256[][] calldata target_instance
) public view {
) public view returns (bool checked) {
// step 0: verify target_instance commitment with target_instance
for (uint256 i = 0; i < target_instance.length; i++) {
uint256[] memory target_instance_buf = AggregatorConfig
Expand Down Expand Up @@ -86,10 +86,7 @@ contract AggregatorVerifier {
);
}

bool checked;

AggregatorConfig.fill_verify_circuits_g2(verify_circuit_pairing_buf);
checked = AggregatorLib.pairing(verify_circuit_pairing_buf);
require(checked, "verify circuit pairing check failed");
}
}