Implement HAND. #55
Open
Implement HAND. #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow, that looks great. Managed to get some nice results when using the D8() flow and threshold: HAND: 
Elevation for reference: 
Elevation colorscale didn't come through 🥺 
|
Member
Author
|
There are also some pictures in the PR preview: I still needs some edits here to pass a local mask. That would also improve the performance performance as we don't need to calculate the flow accumulation. Also, it would be wise to compare the results to some existing software package before you fully trust this implementation. I've started some reference validation over at https://deltares.github.io/Geomorphometry.jl/dev/validation, but that's just for slope/aspect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54 (somewhat, API should be extended still).
@allixender, given my comment with the pseudocode, I had a first try at it myself.