Skip to content

Made determinations more clear in EntityExplosionPrimesScriptEvent meta #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Made determinations more clear in EntityExplosionPrimesScriptEvent meta #2776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3255303
Made determinations more clear for EntityExplosionPrimesScriptEvent
MC-Samuel Sep 10, 2025
cb118f8
added deprecation message
MC-Samuel Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 33 additions & 28 deletions ...c/main/java/com/denizenscript/denizen/events/entity/EntityExplosionPrimesScriptEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@

import com.denizenscript.denizen.objects.EntityTag;
import com.denizenscript.denizen.events.BukkitScriptEvent;
import com.denizenscript.denizencore.objects.Argument;
import com.denizenscript.denizen.utilities.BukkitImplDeprecations;
import com.denizenscript.denizencore.objects.core.ElementTag;
import com.denizenscript.denizencore.objects.ArgumentHelper;
import com.denizenscript.denizencore.objects.ObjectTag;
import org.bukkit.event.EventHandler;
import org.bukkit.event.Listener;
Expand All @@ -25,13 +24,36 @@ public class EntityExplosionPrimesScriptEvent extends BukkitScriptEvent implemen
// @Triggers when an entity decides to explode.
//
// @Context
// <context.entity> returns the EntityTag.
// <context.radius> returns an ElementTag of the explosion's radius.
// <context.fire> returns an ElementTag with a value of "true" if the explosion will create fire and "false" otherwise.
// <context.entity> returns an EntityTag of the explosive.
// <context.radius> returns the explosion's radius.
// <context.fire> returns whether the explosion will create fire.
//
// @Determine
// ElementTag(Decimal) to change the explosion radius.
// "FIRE:<ElementTag(Boolean)>" to set whether the explosion will produce fire.
// -->

public EntityExplosionPrimesScriptEvent() {
registerCouldMatcher("<entity> explosion primes");
this.<EntityExplosionPrimesScriptEvent, ElementTag>registerOptionalDetermination(null, ElementTag.class, (evt, context, value) -> {
if (value.isBoolean()) {
BukkitImplDeprecations.explosionPrimeDetermination.warn();
evt.event.setFire(value.asBoolean());
return true;
}
if (value.isFloat()) {
evt.event.setRadius(value.asFloat());
return true;
}
return false;
});
this.<EntityExplosionPrimesScriptEvent, ElementTag>registerOptionalDetermination("fire", ElementTag.class, (evt, context, value) -> {
if (value.isBoolean()) {
evt.event.setFire(value.asBoolean());
return true;
}
return false;
});
}

public EntityTag entity;
Expand All @@ -48,31 +70,14 @@ public boolean matches(ScriptPath path) {
return super.matches(path);
}

@Override
public boolean applyDetermination(ScriptPath path, ObjectTag determinationObj) {
String determination = determinationObj.toString();
if (ArgumentHelper.matchesDouble(determination)) {
event.setRadius(Float.parseFloat(determination));
return true;
}
if (Argument.valueOf(determination).matchesBoolean()) {
event.setFire(determination.equalsIgnoreCase("true"));
return true;
}
return super.applyDetermination(path, determinationObj);
}

@Override
public ObjectTag getContext(String name) {
switch (name) {
case "entity":
return entity;
case "radius":
return new ElementTag(event.getRadius());
case "fire":
return new ElementTag(event.getFire());
}
return super.getContext(name);
return switch (name) {
case "entity" -> entity.getDenizenObject();
case "radius" -> new ElementTag(event.getRadius());
case "fire" -> new ElementTag(event.getFire());
default -> super.getContext(name);
};
}

@EventHandler
Expand Down
3 changes: 3 additions & 0 deletions plugin/src/main/java/com/denizenscript/denizen/utilities/BukkitImplDeprecations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,9 @@ public class BukkitImplDeprecations {
// Added 2025/07/10
public static Warning entityKnockback = new Warning("entityKnockback", "The 'EntityTag.knockback' property is deprecated. You should adjust the knockback enchantment on the weapon itself.");

// Added 2025/10/24
public static Warning explosionPrimeDetermination = new Warning("explosionPrimeDetermination", "The determination to control fire in the '<entity> explosion primes' event is now formatted as 'FIRE:<ElementTag(Boolean)>'.");

// ==================== SLOW deprecations ====================
// These aren't spammed, but will show up repeatedly until fixed. Server owners will probably notice them.

Expand Down