-
Notifications
You must be signed in to change notification settings - Fork 24
refactor: styles #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: styles #258
Conversation
✅ Deploy Preview for ds-user-guide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@susanunit @rstijerina @taoteg (as time allows), Imagine being a person who would contribute CSS to a docs repository: would this structure both welcome you and not overwhelm you? Review structure, not necessarily the styles. No contributions expected; I just wanna know if I met my goal, and any other feedback you have. |
|
Description changed such that no need to review file diff! 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving newcomer info toward top of file. Remove obvious info (like stating this folder is for styles). consider similar updates to the js/README.md.
Suggestion given to me internally:
- Create your CSS file in the appropriate folder (or inbox.css if unsure)
- Add an @import for it in _import.css in the respective section
What Did You Change?
Break up styles so "entrypoint" to contribute CSS is smaller.
Details
inbox.css(free-form) andimport.css(structured).(unused, empty)
Do You Want Support (syntax, design, etc)?
Does this structure to make CSS approachable or more intimidating?
BEFORE
One 300-line stylesheet (organized and commented).
AFTER
Many small stylesheets. One import stylesheet. One "inbox" stylesheet.