Upgrade to Rust 2024 edition

[lucperkins]

Summary by CodeRabbit

• Chores

  • Upgraded Rust edition from 2021 to 2024
  • Optimized dependency management configuration with improved workspace integration
  • Enhanced explicit feature handling for core dependencies

• Tests

  • Updated error message validation tests for improved grammar consistency

[coderabbitai]

Walkthrough

The PR upgrades Rust edition from 2021 to 2024 across both root and parse-flake-lock packages, modernizes workspace dependency declarations using shorthand syntax, and makes tracing-related dependencies explicit with disabled default features and curated feature lists. Additionally, imports are reordered across several source files, and test error-message expectations are updated.

Changes

Cohort / File(s)	Summary
Manifest files Cargo.toml, parse-flake-lock/Cargo.toml	Edition bumped from 2021 to 2024. Workspace dependencies refactored to shorthand syntax: serde.workspace = true, serde_json.workspace = true, thiserror.workspace = true. Tracing-related crates made explicit: tracing and tracing-subscriber now include default-features = false and explicit feature lists. detsys-ids-client explicit features configuration updated.
Import reordering src/main.rs, src/summary.rs	Import paths reordered for consistency: EnvFilter moved earlier in main.rs; FlakeCheckConfig import repositioned in summary.rs. No functional changes.
Source formatting and tests src/condition.rs, src/flake.rs	Trailing comma added in error construction in condition.rs. Test case removed from cel_conditions in flake.rs. Test expectations updated for error message grammar: singular "key" vs. plural "keys" in nixpkgs dependency error messages.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Note: The changes are largely homogeneous (manifest updates, import reordering, and test expectation adjustments). Verify that the grammar changes in error messages ("key" vs. "keys") are intentional and complete across all test cases. Confirm that the new default-features = false configuration for tracing crates does not unintentionally disable required features in the runtime behavior.

Poem

🐰 A bunny hops through workspace deps,
Shorthand syntax shortens each step,
Edition two-four brings the cheer,
Imports dance and clarity's near,
Tests now speak in grammar so clear! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: upgrading from Rust edition 2021 to 2024 across multiple Cargo.toml files, which aligns with the primary objective.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch rust-2024-edition

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/flake.rs (1)

157-201: Consider removing duplicated CEL condition test case

The last two entries in cases use the same CEL condition with the same expected result. If this isn’t intentionally checking repeat evaluation, you could drop one to reduce noise:

-            (
-                "has(gitRef) && has(numDaysOld) && has(owner) && has(supportedRefs) && supportedRefs.contains(gitRef) && owner != 'NixOS'",
-                false,
-            ),

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eab0cac and edcc22a.

📒 Files selected for processing (6)

• Cargo.toml (3 hunks)
• parse-flake-lock/Cargo.toml (1 hunks)
• src/condition.rs (1 hunks)
• src/flake.rs (3 hunks)
• src/main.rs (1 hunks)
• src/summary.rs (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

src/main.rs (2)

src/condition.rs (1)

• evaluate_condition (18-69)

src/flake.rs (1)

• check_flake_lock (79-137)

src/flake.rs (2)

src/condition.rs (1)

• evaluate_condition (18-69)

src/main.rs (1)

• supported_refs (100-113)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: Check flake.lock test (clean 👼)
• GitHub Check: Nix and Rust checks
• GitHub Check: Check flake.lock test (CEL condition)
• GitHub Check: Test Rust
• GitHub Check: Check flake.lock test (dirty 😈)

🔇 Additional comments (16)

parse-flake-lock/Cargo.toml (1)

4-9: Edition bump and workspace deps look consistent

The 2024 edition setting and workspace-scoped serde/serde_json/thiserror entries are consistent and keep this crate aligned with the workspace setup. No issues spotted.

src/summary.rs (2)

1-1: Import reorder is harmless

Pulling FlakeCheckConfig to the top of the import block is style-only and doesn’t affect behavior.

---

130-136: Disallowed-input message block unchanged in behavior

The formatting tweak around the Disallowed branch keeps the string content intact; the user-facing message remains the same and still reads clearly.

src/main.rs (1)

16-21: Import group reordering only

Reordering the tracing_subscriber and flake imports keeps the same items and doesn’t change runtime behavior. Looks good.

src/condition.rs (1)

59-62: Trailing comma in error construction is fine

Adding the trailing comma in the NonBooleanCondition constructor is formatting-only and keeps behavior identical while improving diffs.

src/flake.rs (4)

5-7: Issue-type import grouping is fine

The regrouped crate::issue::{...} import is a style-only change; all previously used types are still imported.

---

68-73: Improved error message pluralization for missing nixpkgs keys

The new format string correctly switches between “key” and “keys” based on missing.len(), and still prefixes the missing key list. This aligns with the updated tests and makes the error clearer.

---

150-155: Test imports regrouping is non-functional

The consolidated crate::{...} import in the test module keeps the same symbols and doesn’t affect test behavior.

---

309-346: Missing-nixpkgs-keys tests now match pluralized error text

The cases expectations for single vs multiple missing keys match the new error message format and cover both plural and singular wording. This keeps the error contract well specified.

Cargo.toml (7)

18-20: Workspace dependency shorthand syntax looks good.

The switch from inline { workspace = true } tables to shorthand .workspace = true syntax is the modern, idiomatic approach in Cargo and aligns with best practices.

---

30-32: detsys-ids-client: Explicit default-features handling is sound.

Disabling default features and explicitly enabling "tracing-instrument" is a good practice for clarity and supply-chain hygiene.

---

4-4: Edition 2024 upgrade is valid and established.

Rust 1.85.0 stabilized the 2024 edition on February 20, 2025, making this upgrade safe and appropriate for production use. The edition change aligns with the Rust 3-year cadence.

---

41-41: No issues found—tracing configuration is correct.

The codebase does not use the #[instrument] macro or other features disabled by default-features = false on the tracing crate. The "tracing-instrument" feature mentioned in Cargo.toml is from the detsys-ids-client crate, not the tracing crate. The tracing dependency is used only implicitly through transitive dependencies, and the explicitly enabled features in tracing-subscriber (env-filter, fmt, registry) are all available regardless of tracing's default-features setting. The configuration is sound.

---

42-46: Feature selection verified and confirmed correct.

The three features—"env-filter" (EnvFilter type), "fmt" (fmt module), and "registry" (registry module)—are exactly what the codebase uses. An exhaustive search confirms tracing_subscriber is only used in src/main.rs, with imports for EnvFilter, fmt, and prelude, and usage of registry(). All selected features are necessary and there are no missing features required for the observed initialization pattern.

---

4-4: Edition "2024" is valid and stable. Rust 2024 edition was released as stable with Rust 1.85 on February 20, 2025, and has been available for months as of now.

---

41-41: Configuration is correct; tracing crate functions without disabled defaults.

The codebase does not use any tracing macros or the #[instrument] attribute—only tracing_subscriber is used for logging setup (src/main.rs). The disabled default features (attributes, std, tracing-attributes) are unnecessary here. The tracing dependency is primarily transitive (from tokio and detsys-ids-client) and does not require those features. The explicit feature configuration for tracing_subscriber is sufficient.