feat: Consolidate Multi-Provider Code to Shared Package #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathannorris
force-pushed
the
feat-migrate-multi-provider
branch
2 times, most recently
from
03c26d7 to
5f966fd
Compare
Cleanup: removing `release-as` properties from release-please config
after successfully validating OIDC npm publishing.
<!-- av pr metadata
This information is embedded by the av CLI when creating PRs to track
the status of stacks when using Aviator. Please do not delete or edit
this section of the PR.
```
{"parent":"main","parentHead":"","trunk":"main"}
```
-->
Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
This PR migrates the `MultiProvider` functionality from the [js-sdk-contrib](https://github.com/open-feature/js-sdk-contrib) repository into the main js-sdk, providing built-in support for multi-provider evaluation strategies. Addresses #1217 ### What's Changed - **Added `MultiProvider`** for server SDK with support for multiple evaluation strategies - **Added `WebMultiProvider`** for web SDK with web-specific optimizations - **Included 3 evaluation strategies**: FirstMatch, FirstSuccessful, and Comparison - **Comprehensive test coverage** for both server and web implementations - **Updated documentation** with usage examples and strategy explanations ### Testing - ✅ All existing tests pass - ✅ New comprehensive test suites for both server and web MultiProvider - ✅ ESLint compliance across all new code --------- Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
# Conflicts: # packages/web/src/provider/multi-provider/status-tracker.ts
…types Signed-off-by: Jonathan Norris <jonathan@taplytics.com>
jonathannorris
force-pushed
the
feat-shared-multi-provider
branch
from
92cf47a to
847278f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the multi-provider implementation by moving duplicate code from
@openfeature/server-sdkand@openfeature/web-sdkinto@openfeature/shared.Changes
Moved to shared package:
StatusTracker- Generic status tracking for multiple providersBaseEvaluationStrategyand concrete strategy implementations (FirstMatchStrategy,FirstSuccessfulStrategy,ComparisonStrategy)ProviderEntryInput,RegisteredProvider)Made generic and type-safe:
TProviderStatus,TProvider)anytypes in favor of explicit generic constraintsStatusTrackerfor provider compatibilityUpdated implementations:
ProviderStatus,Provider) when using shared utilities